| 2011-11-02 11:23:31 |
Ilya Novoselov |
bug |
|
|
added bug |
| 2011-11-02 11:54:50 |
Stuart Bishop |
pytz: status |
New |
Confirmed |
|
| 2011-11-02 11:54:51 |
Stuart Bishop |
pytz: importance |
Undecided |
High |
|
| 2011-11-02 12:31:29 |
Ilya Novoselov |
attachment added |
|
pacificapia.diff https://bugs.launchpad.net/pytz/+bug/885163/+attachment/2582837/+files/pacificapia.diff |
|
| 2011-11-04 10:34:22 |
Launchpad Janitor |
branch linked |
|
lp:~stub/pytz/samoa-idl |
|
| 2011-11-04 10:41:57 |
Stuart Bishop |
pytz: status |
Confirmed |
Fix Committed |
|
| 2011-11-04 11:02:49 |
Stuart Bishop |
pytz: assignee |
|
Stuart Bishop (stub) |
|
| 2011-11-04 11:02:54 |
Stuart Bishop |
pytz: status |
Fix Committed |
Fix Released |
|
| 2011-12-30 14:01:55 |
Forest Bond |
bug task added |
|
python-tz (Ubuntu) |
|
| 2011-12-30 14:13:58 |
Forest Bond |
bug |
|
|
added subscriber Forest Bond |
| 2011-12-30 14:23:48 |
James Troup |
bug |
|
|
added subscriber The Canonical Sysadmins |
| 2011-12-30 14:23:51 |
Launchpad Janitor |
python-tz (Ubuntu): status |
New |
Confirmed |
|
| 2011-12-30 16:15:23 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2011-12-30 16:15:34 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2012-01-01 07:40:06 |
Stuart Bishop |
tags |
patch |
|
|
| 2012-01-01 14:17:45 |
Stuart Bishop |
tags |
|
patch |
|
| 2012-01-02 13:46:09 |
Andreas Hasenack |
bug |
|
|
added subscriber Andreas Hasenack |
| 2012-01-02 20:30:28 |
Launchpad Janitor |
branch linked |
|
lp:~ahasenack/ubuntu/maverick/python-tz/day-leap-fix-885163 |
|
| 2012-01-02 20:30:33 |
Launchpad Janitor |
branch linked |
|
lp:~ahasenack/ubuntu/lucid/python-tz/day-leap-fix-885163 |
|
| 2012-01-02 20:31:23 |
Launchpad Janitor |
branch linked |
|
lp:~ahasenack/ubuntu/oneiric/python-tz/day-leap-fix-885163 |
|
| 2012-01-02 20:31:25 |
Launchpad Janitor |
branch linked |
|
lp:~ahasenack/ubuntu/natty/python-tz/day-leap-fix-885163 |
|
| 2012-01-03 12:11:04 |
Oliver Beattie |
bug |
|
|
added subscriber Oliver Beattie |
| 2012-01-03 14:38:26 |
Peter Matulis |
bug |
|
|
added subscriber Canonical PSE |
| 2012-01-03 19:44:03 |
Launchpad Janitor |
branch linked |
|
lp:~ahasenack/ubuntu/precise/python-tz/day-leap-fix-885163 |
|
| 2012-01-06 18:35:13 |
Launchpad Janitor |
python-tz (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2012-01-06 18:37:39 |
Evan Broder |
nominated for series |
|
Ubuntu Lucid |
|
| 2012-01-06 18:37:39 |
Evan Broder |
bug task added |
|
python-tz (Ubuntu Lucid) |
|
| 2012-01-06 18:37:39 |
Evan Broder |
nominated for series |
|
Ubuntu Maverick |
|
| 2012-01-06 18:37:39 |
Evan Broder |
bug task added |
|
python-tz (Ubuntu Maverick) |
|
| 2012-01-06 18:37:39 |
Evan Broder |
nominated for series |
|
Ubuntu Oneiric |
|
| 2012-01-06 18:37:39 |
Evan Broder |
bug task added |
|
python-tz (Ubuntu Oneiric) |
|
| 2012-01-06 18:37:39 |
Evan Broder |
nominated for series |
|
Ubuntu Natty |
|
| 2012-01-06 18:37:39 |
Evan Broder |
bug task added |
|
python-tz (Ubuntu Natty) |
|
| 2012-01-06 18:40:38 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/python-tz |
|
| 2012-01-09 17:31:32 |
Andreas Hasenack |
description |
>>> from datetime import datetime
>>> import pytz
>>> tz = pytz.timezone('Pacific/Apia')
>>> d1 = datetime(2011, 11, 1)
>>> d2 = datetime(2012, 1, 1)
>>> tz.dst(d1)
datetime.timedelta(0, 3600)
>>> tz.dst(d2)
datetime.timedelta(1, 3600)
while utcoffset is correct:
>>> tz.utcoffset(d1)
datetime.timedelta(-1, 50400)
>>> tz.utcoffset(d2)
datetime.timedelta(0, 50400) |
Request for SRU for Lucid, Maverick, Natty and Oneiric
======================================================
1. Impact
- Incorrect calculation of DST changes
- Landscape failure to accept new users or edit current users' setting
- "Django timezones app "timezones.zones" module unimportable" (reported on comment #11)
2. Development fix
The issue was fixed upstream in revision 268:
http://bazaar.launchpad.net/~stub/pytz/devel/revision/268
That is the diff grabbed for this SRU.
The same diff is also applied to the python-tz package in the current ubuntu development version (precise).
3. Stable fix
The development fix applies cleanly to the stable releases.
4. Test case
Run the script below. If you get a backtrace, you are affected. If not, the bug is fixed in your environment:
#!/usr/bin/python
import pytz
from datetime import datetime
tz = pytz.timezone("Pacific/Apia")
d2 = datetime(2012,1,1)
local = tz.localize(d2)
local.dst()
print "All is good, NOT hit by bug #885163!"
5. Regression potential
Not sure, timezones can be tricky. I welcome comments from upstream for this section since I basically packaged their fix. The patch is minimal, and it fixed the problems we were having in our production servers.
Original bug description follows:
=================================
>>> from datetime import datetime
>>> import pytz
>>> tz = pytz.timezone('Pacific/Apia')
>>> d1 = datetime(2011, 11, 1)
>>> d2 = datetime(2012, 1, 1)
>>> tz.dst(d1)
datetime.timedelta(0, 3600)
>>> tz.dst(d2)
datetime.timedelta(1, 3600)
while utcoffset is correct:
>>> tz.utcoffset(d1)
datetime.timedelta(-1, 50400)
>>> tz.utcoffset(d2)
datetime.timedelta(0, 50400) |
|
| 2012-01-09 17:31:53 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2012-01-09 17:32:33 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2012-01-09 19:48:03 |
Stefano Rivera |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2012-01-09 19:48:13 |
Stefano Rivera |
python-tz (Ubuntu Lucid): status |
New |
Fix Committed |
|
| 2012-01-09 19:48:23 |
Stefano Rivera |
python-tz (Ubuntu Lucid): importance |
Undecided |
High |
|
| 2012-01-09 19:48:26 |
Stefano Rivera |
python-tz (Ubuntu Maverick): importance |
Undecided |
High |
|
| 2012-01-09 19:48:28 |
Stefano Rivera |
python-tz (Ubuntu Natty): importance |
Undecided |
High |
|
| 2012-01-09 19:48:32 |
Stefano Rivera |
python-tz (Ubuntu Oneiric): importance |
Undecided |
High |
|
| 2012-01-09 20:04:06 |
Stefano Rivera |
python-tz (Ubuntu Maverick): status |
New |
Fix Committed |
|
| 2012-01-09 20:06:49 |
Stefano Rivera |
python-tz (Ubuntu Natty): status |
New |
Fix Committed |
|
| 2012-01-09 20:15:24 |
Stefano Rivera |
python-tz (Ubuntu Oneiric): status |
New |
Fix Committed |
|
| 2012-01-12 16:32:03 |
Colin Watson |
bug |
|
|
added subscriber SRU Verification |
| 2012-01-12 16:32:06 |
Colin Watson |
tags |
patch |
patch verification-needed |
|
| 2012-01-12 16:44:22 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/oneiric-proposed/python-tz |
|
| 2012-01-12 16:44:25 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/maverick-proposed/python-tz |
|
| 2012-01-12 16:44:27 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/natty-proposed/python-tz |
|
| 2012-01-12 16:44:33 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/lucid-proposed/python-tz |
|
| 2012-01-18 18:54:48 |
Andreas Hasenack |
attachment added |
|
test-case.cloud-init https://bugs.launchpad.net/pytz/+bug/885163/+attachment/2681373/+files/test-case.cloud-init |
|
| 2012-01-19 05:45:06 |
Martin Pitt |
tags |
patch verification-needed |
patch verification-done |
|
| 2012-01-19 05:45:17 |
Launchpad Janitor |
python-tz (Ubuntu Lucid): status |
Fix Committed |
Fix Released |
|
| 2012-01-19 05:45:26 |
Launchpad Janitor |
python-tz (Ubuntu Maverick): status |
Fix Committed |
Fix Released |
|
| 2012-01-19 05:45:33 |
Launchpad Janitor |
python-tz (Ubuntu Natty): status |
Fix Committed |
Fix Released |
|
| 2012-01-19 05:45:41 |
Launchpad Janitor |
python-tz (Ubuntu Oneiric): status |
Fix Committed |
Fix Released |
|
| 2012-02-07 20:08:49 |
Reed Loden |
bug |
|
|
added subscriber Reed Loden |
