php5: FILTER_VALIDATE_URL will invalidate a hostname that includes '-'

Bug #651049 reported by Sven 'Darkman' Michels
44
This bug affects 7 people
Affects Status Importance Assigned to Milestone
php5 (Ubuntu)
Fix Released
Medium
Jordan Hagan
Lucid
Won't Fix
Undecided
Unassigned

Bug Description

Binary package hint: php5

Hi,

there is a bug in php 5.3.2 which makes filter_var to fail on urls/domains/hosts that contain a dash ('-').

Since filter_var is used in some well known webfrontends (syscp for example), the bug stops users from using domains like "ubuntu-linux.org".

The patch is included in php 5.3.3.

More can be found here: http://bugs.php.net/bug.php?id=51192

Regards,
Sven

Related branches

Thierry Carrez (ttx)
Changed in php5 (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Ondřej Surý (ondrej) wrote :

BTW This bug is security and has assigned CVE: http://security-tracker.debian.org/tracker/CVE-2010-3710

Revision history for this message
Adam Harvey (lawngnome) wrote :

That CVE is actually for a different filter bug, namely http://bugs.php.net/52929. You'll probably want to backport that fix as well, but they're separate issues.

Revision history for this message
Ondřej Surý (ondrej) wrote :

Adam, you're right. This affects only lucid php5. And as I have suggested in 685014, it seems to be a good idea to pick the fixes from 5.3.3-6 to maverick and now it seems to be a good idea to pick them also for 5.3.2 (plus all other segfault bugs which can be found in upstream SVN).

Revision history for this message
Chuck Short (zulcss) wrote :

Hi,

This is fixed in natty. Thanks for the bug report.

Regards
chuck

tags: added: bitesize server-easy-sru
Revision history for this message
Steve Beattie (sbeattie) wrote :

Removing the reference to CVE-2010-3710; that was fixed in USN 1042-1 (http://www.ubuntu.com/usn/usn-1042-1) and is a separate issue anyway.

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Hi Guys, any update on this for lucid? We experience this bug in TYPO3. Thanks, Olivier

Jordan Hagan (ephess)
Changed in php5 (Ubuntu):
assignee: nobody → Jordan Hagan (ephess)
Revision history for this message
Ingo Renner (ingo-typo3) wrote :

will there be progress here? This is quite an annoying issue as it affects a lot of websites and php frameworks...

Revision history for this message
Jordan Hagan (ephess) wrote :

I've backported the fix - just working on getting it tested now... shouldn't be too long

Changed in php5 (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Ingo Renner (ingo-typo3) wrote :

thanks for letting us know!

Revision history for this message
Jordan Hagan (ephess) wrote :

Fix is tested and backported.. waiting on change to be reviewed and approved =)

Changed in php5 (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Scott Moser (smoser) wrote :

I've marked this as fix-released as it is reported to be fixed in natty. And then nominated it for Lucid.

Changed in php5 (Ubuntu):
status: Fix Committed → Fix Released
Changed in php5 (Ubuntu Lucid):
status: New → Confirmed
Revision history for this message
Jordan Hagan (ephess) wrote :

Debdiff attached =) Hopefully this will work.

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Hi. Any news on this? Can we foresee a release date yet? Many thanks!

Revision history for this message
Jordan Hagan (ephess) wrote :

Updated debdiff attached:

Revision history for this message
Jordan Hagan (ephess) wrote :

Updated debdiff attached:

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

FYI: I have created a ppa with the patch from Jordan here: https://launchpad.net/~olivier-dobberkau/+archive/ppa/+packages
Patch works.

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Just a question. Cant find the any mention in Ubuntu Security Notice USN-1231-1 if this bug was fixed too.
Any info on that. this Bug is really annoying. thanks!

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Hi. This is a kind reminder on this Bug. it is a nobrainer. please take the patch and commit it... thank you!

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Dear Santa.
Please inspire the Guys in charge here to include this tiny patch in the next fix!
Thank you! ;-)

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Hi Scott,

can have a look at this one please?
Looks like this is a simple fix and it could be added to the next release of php5 on lucid.

Thanks! Olivier.

Revision history for this message
Guy Van Sanden (gvs) wrote :

Won't this be fixed for Lucid? It's pretty annoying and there's no other fix than upgrading to 12.04?

Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

I maintain a private ppa with this fix..

https://launchpad.net/~olivier-dobberkau/+archive/php5-usn-1437-1

i try to stay uptodate with the current security patches in lucid php5.

the patch it self is a no brainer!

Revision history for this message
Andreas Otto (andreas-otto) wrote :

What is the status of this bug?

Will this ever be fixed for 10.04 LTS?

Revision history for this message
Rolf Leggewie (r0lf) wrote :

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".

Changed in php5 (Ubuntu Lucid):
status: Confirmed → Won't Fix
Revision history for this message
Olivier Dobberkau (olivier-dobberkau) wrote :

Lets hope that the next no-brainer with patch does not gets the same treatment.
this really weakens my perception of ubuntu LTS: :-(

Revision history for this message
Sven 'Darkman' Michels (sven+launchpad) wrote :

Yeah, hopefully. I mean, a patch exists, its no big change, and 5 years nothing. This is not what i thought that LTS is about....

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.