[SRU] raspi-config is looking at the wrong directory
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
raspi-config (Ubuntu) |
Fix Released
|
High
|
Dave Jones | ||
Jammy |
Fix Released
|
High
|
Dave Jones | ||
Kinetic |
Fix Released
|
High
|
Dave Jones |
Bug Description
[ Impact ]
raspi-config is currently looking at /boot which is where the boot partition is mounted on RaspiOS ... not Ubuntu (where it's /boot/firmware). Which effectively means it's looking at a blank config.txt (because it won't find any) and is writing any changes to /boot/config.txt where they won't work.
[ Test Plan ]
To be performed on the following configurations:
* Pi 4B with Ubuntu Desktop
* Pi 4B with Ubuntu Server
* Pi 2B/3B/3B+/Zero 2W with Ubuntu Server
* Enable proposed (https:/
* Install raspi-config from -proposed: sudo apt install -t jammy-proposed raspi-config
* sudo raspi-config
* Test as many options as reasonably possible. In particular the following are expected to work (or at least state they're unsupported):
- 1 / S1 Wireless LAN (this is expected to fail under Server due to LP: #1981071, but should work under Desktop)
- 1 / S3 Password
- 1 / S4 Hostname
- 1 / S7 Splash screen
- 1 / S8 Power LED
- 2 / D4 Screen Blanking
- 2 / D5 VNC Resolution (should just state this is disabled)
- 2 / D6 Composite (if you have a composite display!)
- 3 / I1 Legacy Camera
- 3 / I2 SSH
- 3 / I3 VNC (should just state this is disabled)
- 3 / I4 SPI
- 3 / I5 I2C
- 3 / I6 Serial Port
- 3 / I7 1-Wire
- 4 / P2 GPU Memory
- 4 / P3 Overlay File System
- 4 / P4 Fan
- 5 / L1 Locale
- 5 / L2 Timezone
- 5 / L3 Keyboard
- 5 / L4 WLAN Country
- 6 / A1 Expand Filesystem (will need to prevent auto-expansion with growpart: mode: off to cloud-init)
- 6 / A3 Compositor (should just state this is disabled)
- 6 / A4 Network Interface Names
- 6 / A5 Network Proxy Settings
- 6 / A6 Boot Order (Pi 4 only)
- 6 / A7 Bootloader Version (Pi 4 only)
- 6 / A9 Wayland (desktop images only)
* Other options can be tested but are not expected to work, though equally they should not actively break important things (like boot / networking)
[ Regression Potential ]
The package as uploaded basically doesn't work on Ubuntu (it runs, but it won't report the current settings correctly and changes it makes go to the wrong place). However, in fixing the package to look at the right location, some of the options become downright dangerous. For example: the overlayfs option (when being disabled) would break boot on Ubuntu by removing the initramfs line from config.txt (perfectly fine under RaspiOS which doesn't rely on an initramfs, but fatal on Ubuntu).
Therefore the regression potential is that we move from "doesn't work" to "actively breaks things". I've patched as much as I reasonably can, and while there are definitely still some pieces that "don't work" I *hope* I've fixed all the "actively breaks" cases.
The options listed in the test plan above should be run through on several different Pi models (in particular a 4B and a non-4B as those are the ones that raspi-config distinguishes) to ensure that nothing breaks horrifically. If certain options merely "don't work", then bugs should be filed, but I don't regard that as a regression as such (because they definitely didn't work before).
However, if any of the options results in the Pi being unable to boot, or connect to the network, etc. (and didn't result in a similar failure under the original version): *that* is a regression and should prevent migration of the package.
Changed in raspi-config (Ubuntu): | |
assignee: | nobody → Dave Jones (waveform) |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in raspi-config (Ubuntu Jammy): | |
status: | New → Confirmed |
assignee: | nobody → Dave Jones (waveform) |
importance: | Undecided → High |
summary: |
- raspi-config is look at the wrong directory + raspi-config is looking at the wrong directory |
summary: |
- raspi-config is looking at the wrong directory + [SRU] raspi-config is looking at the wrong directory |
description: | updated |
This bug was fixed in the package raspi-config - 20220506-0ubuntu1
---------------
raspi-config (20220506-0ubuntu1) kinetic; urgency=medium
* Convert to quilt packaging for ease of Ubuntu patches init-resize. patch: Remove init_resize.sh (never used on Ubuntu) xcompmgr. patch: Disable the xcompmgr compositor option mount.patch: Correct the path of the boot partition overlayfs. patch: Use overlayroot for overlayfs handling ver-check. patch: Remove checks against /etc/debian_version blanking. patch: Fix screen blanking to work under Ubuntu
* Disabled broken and unsupported functions:
- d/p/no-
- d/p/no-vnc.patch: Disable the VNC options
- d/p/no-lua.patch: Replace lua calls with awk to remove a dependency
- d/p/no-
* Fixed other functions:
- d/p/boot-
(LP: #1972982)
- d/p/fix-
- d/p/deb-
- d/p/fix-leds.patch: Fix activity function for the power LED
- d/p/fix-
- d/p/fix-wifi.patch: Fix Wifi SSID and regdom selection
-- Dave Jones <email address hidden> Wed, 29 Jun 2022 14:27:17 +0100