build-depends on obsolete python3-nose-timer

[Steve Langasek]

nose has been removed from Debian as obsolete, and with it python3-nose-timer, which walinuxagent build-depends on. It should be updated to not have this requirement.

[Daniel Draper (danpdraper)]

Hi Steve,

Does the removal of the build dependency need to transpire prior to the Noble release?

Daniel

[Steve Langasek (vorlon)]

On Mon, Apr 22, 2024 at 05:42:33PM -0000, Daniel Draper wrote:
> Does the removal of the build dependency need to transpire prior to the
> Noble release?

It does not.

[Miriam España Acebal (mirespace)]

python3-nose-timer was added in 5685bc3b683473fd6a36e32a18b45c14e1b9ec6b by us (as Ubuntu developers) for making unittest work.

Searching on upstream, from python 3.10, they use pytest instead of nose:

WALinuxAgent: Run unit tests with pytest on Python >= 3.10 CLOSED [1]

Therefore, we need to make changes as a consequence.

[1] https://github.com/Azure/WALinuxAgent/pull/3081

[Miriam España Acebal (mirespace)]

I created a patch with the PR #3081 commented above, but the test part on the building fails because the source tree is incomplete/not matching: a refactor was done in [1] and included on a more recent version of WALinuxagent [2].

Therefore, the plan is to first upgrade WALinuxagent to the latest released version (bug 2068019) and then apply the patch from #3081.

[1] https://github.com/Azure/WALinuxAgent/pull/2902
[2] https://github.com/Azure/WALinuxAgent/releases/tag/v2.10.0.8

[Christian Ehrhardt  (paelzer)]

I've put a reminder to bug 2068019 and we are happy to wait for this new upload to unblock this.
But since we know what it actually waits for it makes no sense to show up in the bug housekeeping weekly - dropping the server-todo tag.

[Miriam España Acebal (mirespace)]

I'm also targeting Jammy because we have there python 3.10.12 and, due to bug 1800499, to make the test work, we can move to pytest following upstream's direction for this (comment #3).

[Launchpad Janitor (janitor)]

This bug was fixed in the package walinuxagent - 2.11.1.4-0ubuntu1

---------------
walinuxagent (2.11.1.4-0ubuntu1) oracular; urgency=medium

  * New upstream release (LP: #2068019):
    - Full list of changes is available at:
      https://github.com/Azure/WALinuxAgent/releases/tag/v2.11.1.4
    - Remove patches:
      + d/p/fix_systemd_networkd_lease_file_path.patch: Merged
        upstream (#2979) and released in version 2.10.0.8.
      + d/p/fix_cgroup_v2_mounting_and_systemd_process.patch: Drop
        because for now is intentional that the agent does not enable
        cgroup usage when v2 is detected, but it is allowed that users
        run the log collector by command line without cgroup monitoring
        (#2939). This was released in version 2.10.0.8.
    - Refresh patches:
      + d/p/update_dhcp_client_ubuntu_supported_versions.patch:
        Merged upstream (#2980) and released in version 2.10.0.8.,
        but still need to fix a version (#3159).
      + d/p/fix_escape_sequence_warning.patch.
  * d/p/complete_exception_info_on_test.patch: Fix incomplete
    mocked exception creation to prevent it from being lost
    when another exception occurs.
  * d/p/disable_udev_overrides.patch: Refresh to make it compliant
    with DEP-3.
  * d/p/embed-distutils-to-azurelinuxagent.patch: due to distutils
    deprecation, upstream embedded it (#3063).
  * d/p/update-test-certificate-data.patch: Avoid decryption failure
    that was making some tests behave unexpectedly (#3166) (fixes #3163).
  * Drop the use of nose (LP: #2063046):
    - d/control: Remove nose dependencies in favor of pytest.
    - d/p/run-unit-test-with-pytest-python3_10.patch: Apply upstream
      (#3081) merged at develop.
    - d/rules: Test overriding to avoid launching tests that require
      sudo.
  * Some polishing actions were taken:
    - d/control:
      + No need to rely on dh-systemd anymore since we have
        debhelper > 11.
      + Drop redundant build-dependency.
    - d/rules:
      + Get DEB_* variables from pkg-info.mk instead of parsing
        changelog.
      + Drop get-packaged-orig-source target because it is deprecated
        since Debian Policy version 4.1.4.
    - d/copyright: Change protocol to use https

 -- Miriam España Acebal <email address hidden> Thu, 20 Jun 2024 09:49:05 +0200