Untranslated desktop file

Bug #1971473 reported by Quentin PAGÈS
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
system-config-printer (Ubuntu)
Fix Released
Undecided
Gunnar Hjalmarsson
Jammy
Fix Committed
Undecided
Gunnar Hjalmarsson

Bug Description

[Impact]

While the Ubuntu changes include translatable strings, the .pot file does not get refreshed when building, but upstream's .pot already in the po/ directory gets imported to LP. As a result, some strings such as "Printers" in the .desktop file show up untranslated.

There is a temorary workaround in place, but this proposal makes sure that the fix won't be overwritten by the upstream .pot in case of some additional package upload to jammy-proposed/jammy-updates.

[Test Plan]

It may be advisable to install system-config-printer{,-common} from jammy-proposed and confirm that the updated packages work as usual.

But this is all about language packs in future point releases, and to confirm the intention with this upload, please take these steps:

* Check out the translation import queue:

  https://translations.launchpad.net/ubuntu/jammy/+source/system-config-printer/+imports

  and confirm that the new po/system-config-printer.pot file was imported successfully.

* Visit this page:

  https://translations.launchpad.net/ubuntu/jammy/+source/system-config-printer/+pots/system-config-printer/oc/569

  and confirm that it still leads to the "Printers" page with an Occitan translation.

[Where problems could occur]

The buildlogs include some warnings related to the creation of the .pot file. But we don't really know if upstream does it better, and I have not identified any significant resulting issue.

[Original description]

Hello,

I am using Ubuntu MATE and on its control centre the entry "Printers" is not translated whereas 100% translated.
It comes from the desktop file apparently. It happens to me in Occitan, Catalan and French, didn't try more locales.
I opened an issue here:
https://github.com/mate-desktop/mate-control-center/issues/693#issuecomment-1115713053

Revision history for this message
Quentin PAGÈS (kwentin) wrote :
Revision history for this message
Till Kamppeter (till-kamppeter) wrote :

The "Printers" part of the GNOME Control Center is not system-config-printer, moving ...

affects: system-config-printer (Ubuntu) → gnome-control-center (Ubuntu)
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Nice try, Till, but g-c-c is not part of Ubuntu MATE. ;)

I pushed this commit:

https://salsa.debian.org/gnome-team/system-config-printer/-/commit/a8b851a6

As regards jammy I uploaded an updated translation template manually. Looks good:

https://translations.launchpad.net/ubuntu/jammy/+source/system-config-printer/+pots/system-config-printer/oc/569

So that string will hopefully be shown translated in the 22.04.1 point release.

P.S. This is an Ubuntu only bug, so you should close the upstream issue.

affects: gnome-control-center (Ubuntu) → system-config-printer (Ubuntu)
Changed in system-config-printer (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
status: New → Fix Committed
Revision history for this message
Quentin PAGÈS (kwentin) wrote :

Many thanks Gunnar!
Ubuntu's i18n is getting better again!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package system-config-printer - 1.5.16-0ubuntu4

---------------
system-config-printer (1.5.16-0ubuntu4) kinetic; urgency=medium

  * debian/rules: Refresh the .pot file when building (LP: #1971473)

 -- Gunnar Hjalmarsson <email address hidden> Mon, 25 Jul 2022 23:59:43 +0200

Changed in system-config-printer (Ubuntu):
status: Fix Committed → Fix Released
Changed in system-config-printer (Ubuntu Jammy):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
status: New → In Progress
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Quentin, or anyone else affected,

Accepted system-config-printer into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/system-config-printer/1.5.16-0ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in system-config-printer (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
tags: added: block-proposed-jammy
Revision history for this message
Chris Halse Rogers (raof) wrote :

This looks like it should be uploaded, but doesn't need to actually be released into -updates, as there's no user-visible change?

I've marked this as block-proposed, so it will sit happily on the pending SRU page until we need to make other changes to system-config-printer. If I've misunderstood, and that's not appropriate, feel free to remove the block-proposed-jammy tag.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Chris: I think you understood it perfectly well. The block-proposed-jammy tag sounds fine to me.

To prepare for a possible migration to -updates later, I followed the steps in the test plan and verified the upload.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Quentin PAGÈS (kwentin) wrote :

Hello!
I am away and I can only have my PC with Jammy Friday, I will see this by then :D
Many thanks again!

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Quentin: Actually there is not much to see. The language packs are fine, and the purpose of the upload was to make sure that they keep being so.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.