sysdig FTBS with linux 6.5 on jammy

Bug #2049919 reported by Roxana Nicolescu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sysdig (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
In Progress
Medium
Roxana Nicolescu

Bug Description

[Impact]

671s /var/lib/dkms/sysdig/0.27.1/build/main.c: In function ‘sysdig_init’:
671s ./include/linux/export.h:29:22: error: passing argument 1 of ‘class_create’ from incompatible pointer type [-Werror=incompatible-pointer-types]
671s 29 | #define THIS_MODULE (&__this_module)
671s | ~^~~~~~~~~~~~~~~
671s | |
671s | struct module *
671s /var/lib/dkms/sysdig/0.27.1/build/main.c:2484:36: note: in expansion of macro ‘THIS_MODULE’
671s 2484 | g_ppm_class = class_create(THIS_MODULE, PROBE_DEVICE_NAME);
671s | ^~~~~~~~~~~
671s In file included from ./include/linux/device.h:31,
671s from ./include/linux/cdev.h:8,
671s from /var/lib/dkms/sysdig/0.27.1/build/main.c:26:
671s ./include/linux/device/class.h:230:54: note: expected ‘const char *’ but argument is of type ‘struct module *’
671s 230 | struct class * __must_check class_create(const char *name);
671s | ~~~~~~~~~~~~^~~~
671s /var/lib/dkms/sysdig/0.27.1/build/main.c:2484:23: error: too many arguments to function ‘class_create’
671s 2484 | g_ppm_class = class_create(THIS_MODULE, PROBE_DEVICE_NAME);
671s | ^~~~~~~~~~~~
671s ./include/linux/device/class.h:230:29: note: declared here
671s 230 | struct class * __must_check class_create(const char *name);
671s |
                          ^~~~~~~~~~~~
[Test case]

 $ sudo apt install sysdig

[Fix]

Backport changes in the sysdig module from mantic to properly support the new linux 6.5 ABI.
it is a simple change, create_class now takes 1 argument for kernel > 6.4 and 2 args for kernel < 6.4

[Regression potential]

We may experience regressions in systems that are using this module especially with the new 6.5 kernel.

Changed in sysdig (Ubuntu):
status: New → Invalid
Changed in sysdig (Ubuntu Jammy):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Roxana Nicolescu (roxanan)
Revision history for this message
Roxana Nicolescu (roxanan) wrote :
Revision history for this message
Roxana Nicolescu (roxanan) wrote :

Tested with jammy:hwe-6.5
Building for 6.5.0-14-generic
Building initial module for 6.5.0-14-generic
Secure Boot not enabled on this system.
Done.

sysdig-probe.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/6.5.0-14-generic/updates/dkms/

depmod...

Tested with jammy-ga
Building initial module for 5.15.0-91-generic

sysdig-probe.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-91-generic/updates/dkms/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.