[jammy] Missing ovn-detrace binary

[Frode Nordahl]

[Impact]
The `ovn-detrace` command, which was previously available in Ubuntu, became unavailable starting Jammy.

[Test Case]
Install package, execute `ovn-detrace` command.

[Regression Potential]
None, this fixes a already released regression in Ubuntu Jammy.

[Original Bug Description]
Upstream changes [0] has made `ovn-detrace` into a symbolical link to `ovn_detrace.py`. As a consequence the package now only contains the link and not the actual binary.

0: https://github.com/ovn-org/ovn/commit/1cafb6306df95311d31124bde26bebb2bb76d308

[Steve Langasek (vorlon)]

> Upstream changes [0] has made `ovn-detrace` into a symbolical
> link to `ovn_detrace.py`. As a consequence the package now only
> contains the link and not the actual binary.

The expected solution, under Debian and Ubuntu policy, is to rename the ovn_detrace.py file to /usr/bin/ovn-detrace, NOT to ship both in /usr/bin. It is against policy to include files on PATH that have the implementation language specified as an extension.

[Frode Nordahl (fnordahl)]

Thank you for pointing that out. A new upload for Jammy has been made which correctly fixes the issue in line with policy.

The correct fix has also been committed to the Kinetic package repository, and that will be uploaded along with the next update of the upstream OVN release to go into Kinetic. If you'd prefer we fix it in Kinetic sooner, we can also do that.

[Robie Basak (racb)]

An upload of ovn to jammy-proposed has been rejected from the upload queue for the following reason: "Bad upload: missing bug references against 22.03.1-0ubuntu1. Please re-upload with -v.".

[Chris Halse Rogers (raof)]

An upload of ovn to jammy-proposed has been rejected from the upload queue for the following reason: "Unnecessary packaging changes in the disable-these-tests infrastructure. If you think they are necessary, please ping RAOF on #ubuntu-release and I can accept from the rejected queue.".

[Chris Halse Rogers (raof)]

Hello Frode, or anyone else affected,

Accepted ovn into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ovn/22.03.2-0ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Frode Nordahl (fnordahl)]

Before upgrade:
root@choice-owl:~# dpkg -l | grep ovn
ii ovn-common 22.03.0-0ubuntu1 amd64 OVN common components
root@choice-owl:~# ovn-detrace
Command 'ovn-detrace' not found, but can be installed with:
apt install ovn-common
root@choice-owl:~# ls -l /usr/bin/ovn-detrace
lrwxrwxrwx 1 root root 14 Mar 25 2022 /usr/bin/ovn-detrace -> ovn_detrace.py

After upgrade:
root@choice-owl:~# dpkg -l | grep ovn
ii ovn-common 22.03.2-0ubuntu0.22.04.1 amd64 OVN common components
root@choice-owl:~# :|ovn-detrace -V
/usr/bin/ovn-detrace (OVN) 22.03.2
root@choice-owl:~# ls -l /usr/bin/ovn-detrace
-rwxr-xr-x 1 root root 19459 Jan 17 08:45 /usr/bin/ovn-detrace

[Launchpad Janitor (janitor)]

This bug was fixed in the package ovn - 22.03.2-0ubuntu0.22.04.1

---------------
ovn (22.03.2-0ubuntu0.22.04.1) jammy; urgency=medium

  * New upstream version 22.03.2 (LP: #2003056).
  * d/p/lp-1982454-northd-stateless-nat-fix.patch: Drop, included in point release.
  * d/control: Bump openvswitch build requirement.
  * d/flaky-tests.txt: Extend list of flaky tests.

ovn (22.03.1-0ubuntu2) jammy; urgency=medium

  * d/rules, d/ovn-common.install: Properly fix the ovn-detrace binary
    (LP: #1971178).
  * d/gbp.conf: Add the package components.

ovn (22.03.1-0ubuntu1) jammy; urgency=medium

  [ Frode Nordahl ]
  * New upstream point release (LP: #1980809).
  * d/ovn-common.install: Add missing ovn_detrace.py binary (LP: #1971178).
  * d/rules, d/testlist.py, d/flaky-tests.txt:
    - Dynamically build list of tests to run from list of test descriptions.
  * d/p/lp-1982454-northd-stateless-nat-fix.patch (LP: #1982454).

  [ James Page ]
  * d/control: Update openvswitch build requirement.

 -- Frode Nordahl <email address hidden> Tue, 17 Jan 2023 09:45:31 +0100

[Robie Basak (racb)]

The verification of the Stable Release Update for ovn has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.