Manuskript crashes on start

[Biep]

[Impact]

Manuskript is an open-source tool for writers. Its main purpose is writing novels, books, and the like. It does not have any reverse dependencies.

In Ubuntu 22.04 and presumably all flavors thereof (at least Lubuntu), the Manuskript package is currently entirely broken. Attempting to launch it from its button in the application menu does nothing, while attempting to launch it from a terminal results in a very messy error message, which is detailed more thoroughly in the original bug report. This renders Manuskript entirely unusable.

This patch backports the following Git commits to the existing version of Manuskript in Ubuntu: https://github.com/olivierkes/manuskript/commit/15edb6efb7305b9d1a192712660857ca38facace and https://github.com/olivierkes/manuskript/commit/dc86e3b14e1969ebdc62884126c372b971620da6. This appears to fix the problem in my testing.

Those who have Manuskript already installed on their systems currently are unable to use it at all, from my testing. Those who have Manuskript installed already should be able to use Manuskript again after this upgrade is installed.

[Test Plan]

  1. Install Ubuntu 22.04 or 22.10 into a virtual machine, or use an existing installation thereof.
  2. Fully update the new installation (sudo apt update && sudo apt -y full-upgrade)
  3. Install the current version of Manuskript (sudo apt install manuskript)
  4. Attempt to launch the program from the terminal - the error message described in the original bug report should appear.
  5. Enable -proposed and install the new version of Manuskript from -proposed.
  6. Attempt to launch Manuskript from the terminal - it should launch successfully this itme.
  7. Create a new Manuskript project, and ensure that colors appear to be rendering correctly in multiple places.
  8. Attempt to open the saved project. The saved changes should appear.
  9. Open the sample "book-of-acts" project and make sure it renders properly.

[Where problems could occur]

If the code being backported is incompatible with the existing code, it could potentially result in Manuskript being still unable to launch, or cause strange behavior with the modified code (which appears to mainly deal with colors and size/position values, and so would likely cause colors somewhere to look wrong or result in erratic behavior). The above test plan will catch major failures.

---

Original bug report:

On Wayland it warns about it not liking Wayland before crashing; on Xorg it immediately crashes on the unhandled exception:

biep@blok:~$ manuskript
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
CRITICAL> An unhandled exception has occurred!
Traceback (most recent call last):
  File "/usr/bin/manuskript", line 30, in <module>
    main.run()
  File "/usr/share/manuskript/manuskript/main.py", line 292, in run
    app, MW = prepare(arguments)
  File "/usr/share/manuskript/manuskript/main.py", line 171, in prepare
    from manuskript.mainWindow import MainWindow
  File "/usr/share/manuskript/manuskript/mainWindow.py", line 23, in <module>
    from manuskript.models.worldModel import worldModel
  File "/usr/share/manuskript/manuskript/models/worldModel.py", line 11, in <module>
    from manuskript.ui import style as S
  File "/usr/share/manuskript/manuskript/ui/style.py", line 36, in <module>
    highlightLight = F.mixColors(highlight, window, .3)
  File "/usr/share/manuskript/manuskript/functions/__init__.py", line 197, in mixColors
    return QColor(r, g, b) if not fromString else QColor(r, g, b).name()
TypeError: arguments did not match any overloaded call:
  QColor(Qt.GlobalColor): argument 1 has unexpected type 'float'
  QColor(int): argument 1 has unexpected type 'float'
  QColor(QRgba64): argument 1 has unexpected type 'float'
  QColor(Any): too many arguments
  QColor(): too many arguments
  QColor(int, int, int, alpha: int = 255): argument 1 has unexpected type 'float'
  QColor(str): argument 1 has unexpected type 'float'
  QColor(Union[QColor, Qt.GlobalColor, QGradient]): argument 1 has unexpected type 'float'

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: manuskript 0.12.0-1
ProcVersionSignature: Ubuntu 5.15.0-47.51-generic 5.15.46
Uname: Linux 5.15.0-47-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.1
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Fri Sep 9 16:44:06 2022
InstallationDate: Installed on 2020-04-27 (864 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
PackageArchitecture: all
SourcePackage: manuskript
UpgradeStatus: Upgraded to jammy on 2022-09-08 (1 days ago)

[Hans Joachim Desserud (hjd)]

Thanks for taking your time to report this issue and help making Ubuntu better.

I found a corresponding Debian bug report with the same error message, so I have attached a bug watch.

[Biep (biep)]

Thanks.
The version in the repository is 0.12.0 - a version that brought a bunch of new features.
Since all of 0.13.0, 0.13.1, and 0.14.0 are stability releases, without new features, it seems reasonable to include 0.14.0 in the repository instead of 0.12.0.

[Aaron Rainbolt (arraybolt3)]

Confirmed on a fresh install of Lubuntu 22.04.1. Using command-line options had no effect. This bug renders the Manuskript package in Ubuntu 22.04 entirely unusable.

[Biep (biep)]

The problem has been [solved in the latest version](https://github.com/olivierkes/manuskript/issues/1062) - so having that in the repo ought to solve it.

Is there a way to make this happen fast, so that all those wanting to go on writing can do so again soon?

[Aaron Rainbolt (arraybolt3)]

OK, I verified that this bug is indeed already fixed in Debian Testing. I'm preparing the SRUs and will be editing the bug into an SRU template in the near future (like, within the next few hours most likely). My testing seems to show that the fix works in Kinetic, and I'm about to test in Jammy.

[Aaron Rainbolt (arraybolt3)]

Internet woes make it tricky for me to upload the patches here, so Simon Quigley is doing it for me. Thank you :)

[Simon Quigley (tsimonq2)]

Attaching a debdiff per the request of Aaron Rainbolt.

[Simon Quigley (tsimonq2)]

Attaching another debdiff per the request of Aaron Rainbolt.

[Aaron Rainbolt (arraybolt3)]

Manuskript 0.14.0 is already present in Lunar, and the bug does not exist there in my testing.

[Aaron Rainbolt (arraybolt3)]

Kinetic debian tarball

[Aaron Rainbolt (arraybolt3)]

Jammy debian tarball

[Aaron Rainbolt (arraybolt3)]

Also here's a PPA with the update. It should finish building shortly. https://launchpad.net/~arraybolt3/+archive/ubuntu/manuskript

[Aaron Rainbolt (arraybolt3)]

The tarballs I uploaded earlier have a problem - I forgot a change that I needed to make in debian/control (changing the Maintainer field), so they shouldn't be used. I also can't seem to delete them...

[AdlerHorst (adlerhorst)]

Problem still not solved:
manuskript/kinetic,kinetic,now 0.12.0-1 all [installiert]

CRITICAL> An unhandled exception has occurred!
Traceback (most recent call last):
  File "/usr/bin/manuskript", line 30, in <module>
    main.run()
  File "/usr/share/manuskript/manuskript/main.py", line 292, in run
    app, MW = prepare(arguments)
  File "/usr/share/manuskript/manuskript/main.py", line 171, in prepare
    from manuskript.mainWindow import MainWindow
  File "/usr/share/manuskript/manuskript/mainWindow.py", line 23, in <module>
    from manuskript.models.worldModel import worldModel
  File "/usr/share/manuskript/manuskript/models/worldModel.py", line 11, in <module>
    from manuskript.ui import style as S
  File "/usr/share/manuskript/manuskript/ui/style.py", line 36, in <module>
    highlightLight = F.mixColors(highlight, window, .3)
  File "/usr/share/manuskript/manuskript/functions/__init__.py", line 197, in mixColors
    return QColor(r, g, b) if not fromString else QColor(r, g, b).name()
TypeError: arguments did not match any overloaded call:
  QColor(Qt.GlobalColor): argument 1 has unexpected type 'float'
  QColor(int): argument 1 has unexpected type 'float'
  QColor(QRgba64): argument 1 has unexpected type 'float'
  QColor(Any): too many arguments
  QColor(): too many arguments
  QColor(int, int, int, alpha: int = 255): argument 1 has unexpected type 'float'
  QColor(str): argument 1 has unexpected type 'float'
  QColor(Union[QColor, Qt.GlobalColor, QGradient]): argument 1 has unexpected type 'float'

[Aaron Rainbolt (arraybolt3)]

Alright, take 2. This time I only backported just the bugfix, not the entire Manuskript version. Here's the Kinetic patch.

[Aaron Rainbolt (arraybolt3)]

And here's the Jammy patch.

[Aaron Rainbolt (arraybolt3)]

Updated patches with a couple of fixes. Kinetic patch:

[Aaron Rainbolt (arraybolt3)]

Jammy patch:

[Aaron Rainbolt (arraybolt3)]

Fix attempt 3. Kinetic patch.

[Aaron Rainbolt (arraybolt3)]

Fix attempt 3. Jammy patch.

[Alex Murray (alexmurray)]

Thanks for the updated patches - I have sponsored them to -proposed for jammy and kinetic.

[Timo Aaltonen (tjaalton)]

Hello Biep, or anyone else affected,

Accepted manuskript into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/manuskript/0.12.0-1ubuntu0.22.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Biep, or anyone else affected,

Accepted manuskript into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/manuskript/0.12.0-1ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Biep (biep)]

All right - but this may take a while. I am not in a position to go tinkering with computers at the moment.

 ---- Op vr, 10 feb 2023 15:31:00 +0100 schreef Timo Aaltonen ----
 > Hello Biep, or anyone else affected,
 >
 > Accepted manuskript into kinetic-proposed. The package will build now
 > and be available at
 > https://launchpad.net/ubuntu/+source/manuskript/0.12.0-1ubuntu0.22.10.1
 > in a few hours, and then in the -proposed repository.
 >
 > Please help us by testing this new package. See
 > https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
 > to enable and use -proposed. Your feedback will aid us getting this
 > update out to other Ubuntu users.
 >
 > If this package fixes the bug for you, please add a comment to this bug,
 > mentioning the version of the package you tested, what testing has been
 > performed on the package and change the tag from verification-needed-
 > kinetic to verification-done-kinetic. If it does not fix the bug for
 > you, please add a comment stating that, and change the tag to
 > verification-failed-kinetic. In either case, without details of your
 > testing we will not be able to proceed.
 >
 > Further information regarding the verification process can be found at
 > https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
 > advance for helping!
 >
 > N.B. The updated package will be released to -updates after the bug(s)
 > fixed by this package have been verified and the package has been in
 > -proposed for a minimum of 7 days.
 >
 > ** Changed in: manuskript (Ubuntu Kinetic)
 > Status: In Progress => Fix Committed
 >
 > ** Tags added: verification-needed verification-needed-kinetic
 >
 > ** Changed in: manuskript (Ubuntu Jammy)
 > Status: In Progress => Fix Committed
 >
 > ** Tags added: verification-needed-jammy
 >
 > --
 > You received this bug notification because you are subscribed to the bug
 > report.
 > https://bugs.launchpad.net/bugs/1989203
 >
 > Title:
 > Manuskript crashes on start
 >
 > Status in manuskript package in Ubuntu:
 > Fix Released
 > Status in manuskript source package in Jammy:
 > Fix Committed
 > Status in manuskript source package in Kinetic:
 > Fix Committed
 > Status in manuskript package in Debian:
 > New
 >
 > Bug description:
 > [Impact]
 >
 > Manuskript is an open-source tool for writers. Its main purpose is
 > writing novels, books, and the like. It does not have any reverse
 > dependencies.
 >
 > In Ubuntu 22.04 and presumably all flavors thereof (at least Lubuntu),
 > the Manuskript package is currently entirely broken. Attempting to
 > launch it from its button in the application menu does nothing, while
 > attempting to launch it from a terminal results in a very messy error
 > message, which is detailed more thoroughly in the original bug report.
 > This renders Manuskript entirely unusable.
 >
 > This patch backports the following Git commit to the existing version
 > of Manuskript in Ubuntu:
 > https://github.com/olivierkes/manuskript/commit/15edb6efb7305b9d1a192712660857ca38facace
 > This appears to fix the problem in my testing.
 >
 > Those who have ...

[Aaron Rainbolt (arraybolt3)]

@Biep: There's no need for you to test, that's just an automated message that's pinging you since you filed the bug report. I finally got the fix in, but you're using an already-fixed version from my PPA so you don't need to do anything. I can test the fix so that other users with Manuskript problems can get things working without a PPA.

(You're welcome to remove the PPA and install Manuskript from the archive if you prefer once it's all the way in the archive, but the version in the archive is older and might not work as well.)

[Biep (biep)]

Ah, all right. Thanks for the explanation.
Why did you go for an older version, by the way? The newer ones were basically all bug fixes - did you backport all those?

 ---- Op vr, 10 feb 2023 22:14:54 +0100 schreef Aaron Rainbolt ----
 > @Biep: There's no need for you to test, that's just an automated message
 > that's pinging you since you filed the bug report. I finally got the fix
 > in, but you're using an already-fixed version from my PPA so you don't
 > need to do anything. I can test the fix so that other users with
 > Manuskript problems can get things working without a PPA.
 >
 > (You're welcome to remove the PPA and install Manuskript from the
 > archive if you prefer once it's all the way in the archive, but the
 > version in the archive is older and might not work as well.)
 >
 > --
 > You received this bug notification because you are subscribed to the bug
 > report.
 > https://bugs.launchpad.net/bugs/1989203
 >
 > Title:
 > Manuskript crashes on start
 >
 > Status in manuskript package in Ubuntu:
 > Fix Released
 > Status in manuskript source package in Jammy:
 > Fix Committed
 > Status in manuskript source package in Kinetic:
 > Fix Committed
 > Status in manuskript package in Debian:
 > New
 >
 > Bug description:
 > [Impact]
 >
 > Manuskript is an open-source tool for writers. Its main purpose is
 > writing novels, books, and the like. It does not have any reverse
 > dependencies.
 >
 > In Ubuntu 22.04 and presumably all flavors thereof (at least Lubuntu),
 > the Manuskript package is currently entirely broken. Attempting to
 > launch it from its button in the application menu does nothing, while
 > attempting to launch it from a terminal results in a very messy error
 > message, which is detailed more thoroughly in the original bug report.
 > This renders Manuskript entirely unusable.
 >
 > This patch backports the following Git commit to the existing version
 > of Manuskript in Ubuntu:
 > https://github.com/olivierkes/manuskript/commit/15edb6efb7305b9d1a192712660857ca38facace
 > This appears to fix the problem in my testing.
 >
 > Those who have Manuskript already installed on their systems currently
 > are unable to use it at all, from my testing. Those who have
 > Manuskript installed already should be able to use Manuskript again
 > after this upgrade is installed.
 >
 > [Test Plan]
 >
 >   1. Install Ubuntu 22.04 or 22.10 into a virtual machine, or use an existing installation thereof.
 >   2. Fully update the new installation (sudo apt update && sudo apt -y full-upgrade)
 >   3. Install the current version of Manuskript (sudo apt install manuskript)
 >   4. Attempt to launch the program from the terminal - the error message described in the original bug report should appear.
 >   5. Enable -proposed and install the new version of Manuskript from -proposed.
 >   6. Attempt to launch Manuskript from the terminal - it should launch successfully this itme.
 >   7. Create a new Manuskript project, make sure that Markdown highlighting works, and
 >   8. Attempt to open the saved project. The saved changes should appear.
 >
 > [Where problems ...

[Aaron Rainbolt (arraybolt3)]

For the sake of stability, Ubuntu doesn't usually update to an entirely
new version of a piece of software, instead choosing to backport bug
fixes. I tried to do a whole version update since it was mostly bug
fixes, but was told that doing it that way would make review more
difficult, and also Manuskript's development process doesn't appear to
meet all of the qualifications for a full version update to be permitted
usually. It was easier and faster doing it this way (and most of the
reason it took this long was because I tried to do it the other way first).

On 2/10/23 16:53, Biep wrote:
> Ah, all right. Thanks for the explanation.
> Why did you go for an older version, by the way? The newer ones were basically all bug fixes - did you backport all those?
>
> ---- Op vr, 10 feb 2023 22:14:54 +0100 schreef Aaron Rainbolt ----
> > @Biep: There's no need for you to test, that's just an automated message
> > that's pinging you since you filed the bug report. I finally got the fix
> > in, but you're using an already-fixed version from my PPA so you don't
> > need to do anything. I can test the fix so that other users with
> > Manuskript problems can get things working without a PPA.
> >
> > (You're welcome to remove the PPA and install Manuskript from the
> > archive if you prefer once it's all the way in the archive, but the
> > version in the archive is older and might not work as well.)
> >
> > --
> > You received this bug notification because you are subscribed to the bug
> > report.
> > https://bugs.launchpad.net/bugs/1989203
> >
> > Title:
> > Manuskript crashes on start
> >
> > Status in manuskript package in Ubuntu:
> > Fix Released
> > Status in manuskript source package in Jammy:
> > Fix Committed
> > Status in manuskript source package in Kinetic:
> > Fix Committed
> > Status in manuskript package in Debian:
> > New
> >
> > Bug description:
> > [Impact]
> >
> > Manuskript is an open-source tool for writers. Its main purpose is
> > writing novels, books, and the like. It does not have any reverse
> > dependencies.
> >
> > In Ubuntu 22.04 and presumably all flavors thereof (at least Lubuntu),
> > the Manuskript package is currently entirely broken. Attempting to
> > launch it from its button in the application menu does nothing, while
> > attempting to launch it from a terminal results in a very messy error
> > message, which is detailed more thoroughly in the original bug report.
> > This renders Manuskript entirely unusable.
> >
> > This patch backports the following Git commit to the existing version
> > of Manuskript in Ubuntu:
> > https://github.com/olivierkes/manuskript/commit/15edb6efb7305b9d1a192712660857ca38facace
> > This appears to fix the problem in my testing.
> >
> > Those who have Manuskript already installed on their systems currently
> > are unable to use it at all, from my testing. Those who have
> > Manuskript installed already should be able to use Manuskript again
> > after this upgrade is installed.
...

[Biep (biep)]

All right. Thanks!
(Both for the explanation, and certainly for all the work you put in this!)

 ---- Op Sat, 11 Feb 2023 00:19:09 +0100 schreef Aaron Rainbolt ----
 > For the sake of stability, Ubuntu doesn't usually update to an entirely
 > new version of a piece of software, instead choosing to backport bug
 > fixes. I tried to do a whole version update since it was mostly bug
 > fixes, but was told that doing it that way would make review more
 > difficult, and also Manuskript's development process doesn't appear to
 > meet all of the qualifications for a full version update to be permitted
 > usually. It was easier and faster doing it this way (and most of the
 > reason it took this long was because I tried to do it the other way first).
 >
 > On 2/10/23 16:53, Biep wrote:
 > > Ah, all right. Thanks for the explanation.
 > > Why did you go for an older version, by the way? The newer ones were basically all bug fixes - did you backport all those?
 > >
 > > ---- Op vr, 10 feb 2023 22:14:54 +0100 schreef Aaron Rainbolt ----
 > > > @Biep: There's no need for you to test, that's just an automated message
 > > > that's pinging you since you filed the bug report. I finally got the fix
 > > > in, but you're using an already-fixed version from my PPA so you don't
 > > > need to do anything. I can test the fix so that other users with
 > > > Manuskript problems can get things working without a PPA.
 > > >
 > > > (You're welcome to remove the PPA and install Manuskript from the
 > > > archive if you prefer once it's all the way in the archive, but the
 > > > version in the archive is older and might not work as well.)
 > > >
 > > > --
 > > > You received this bug notification because you are subscribed to the bug
 > > > report.
 > > > https://bugs.launchpad.net/bugs/1989203
 > > >
 > > > Title:
 > > > Manuskript crashes on start
 > > >
 > > > Status in manuskript package in Ubuntu:
 > > > Fix Released
 > > > Status in manuskript source package in Jammy:
 > > > Fix Committed
 > > > Status in manuskript source package in Kinetic:
 > > > Fix Committed
 > > > Status in manuskript package in Debian:
 > > > New
 > > >
 > > > Bug description:
 > > > [Impact]
 > > >
 > > > Manuskript is an open-source tool for writers. Its main purpose is
 > > > writing novels, books, and the like. It does not have any reverse
 > > > dependencies.
 > > >
 > > > In Ubuntu 22.04 and presumably all flavors thereof (at least Lubuntu),
 > > > the Manuskript package is currently entirely broken. Attempting to
 > > > launch it from its button in the application menu does nothing, while
 > > > attempting to launch it from a terminal results in a very messy error
 > > > message, which is detailed more thoroughly in the original bug report.
 > > > This renders Manuskript entirely unusable.
 > > >
 > > > This patch backports the following Git commit to the existing version
 > > > of Manuskript in Ubuntu:
 > > > https://github.com/olivierkes/manuskript/commit/15edb6efb7305b9d1a192712660857ca38facace
 > > > This appears to fix the problem in ...

[Aaron Rainbolt (arraybolt3)]

Alright, so I messed something up apparently (probably some more backporting needs done). The app randomly crashed during verification, with a similar looking error, and trying to open the Manuskript project I had initially created in the process immediately crashed again with the below stacktrace (typed by hand, sorry if there's errors):

CRITICAL> An unhandled exception has occurred!
Traceback (most recent call last):
  File "/usr/share/manuskript/manuskript/ui/welcome.py", line 165, in openFile
    self.mw.loadProject(filename)
  File "/usr/share/manuskript/manuskript/mainWindow.py", line 605, in loadProject
    self.loadDatas(projects)
  File "/usr/share/manuskript/manuskript/mainWindow.py", line 896, in loadDatas
    F.statusMessage(
  File "/usr/share/manuskript/manuskript/functions/__init__.py", line 412, in statusMessage
    g.setLeft(s)
TypeError: setLeft(self, int): argument 1 has unexpected type 'float'

Sigh. This is gonna be harder than I thought.

[Steve Langasek (vorlon)]

The version of manuskript in the proposed pocket of Jammy that was purported to fix this bug report has been removed because one or more bugs that were to be fixed by the upload have failed verification and been in this state for more than 10 days.

[Steve Langasek (vorlon)]

Unsubscribing ubuntu-sponsors as there doesn't appear to be a patch ready for sponsorship at the moment.

[Steve Langasek (vorlon)]

(Please subscribe ubuntu-sponsors again when you have another patch you want reviewed)

[Łukasz Zemczak (sil2100)]

The version of manuskript in the proposed pocket of Kinetic that was purported to fix this bug report has been removed because one or more bugs that were to be fixed by the upload have failed verification and been in this state for more than 10 days.

[Utkarsh Gupta (utkarsh)]

Ubuntu 22.10 (Kinetic Kudu) has reached end of life, so this bug will not be fixed for that specific release.

[Hal (halcyonwriter)]

Please tell me there's a fix for this coming.
I have 5 years of work in an .msk file and I can't access it since Manuskript isn't launching.
If the program isn't working, my backups don't mean much anymore.

Running 22.04

[Aaron Rainbolt (arraybolt3)]

For whomever needs a fix right now, install Manuskript from this PPA: https://launchpad.net/~arraybolt3/+archive/ubuntu/manuskript I uploaded this as part of trying to get the bug fixed, and while it ultimately wasn't accepted into the Ubuntu archive, it should be usable.

I tried to backport a bug fix and it failed quite badly. I need to give it another shot, but I'm too busy to do so at the moment. I do hope to try and fix this again at some point.

[Aaron Rainbolt (arraybolt3)]

I believe I have found the commit with the additional remaining fixes needed to resolve this bug. https://github.com/olivierkes/manuskript/commit/dc86e3b14e1969ebdc62884126c372b971620da6 Going to try to backport this along with the other commit next time I work with this package.

[Aaron Rainbolt (arraybolt3)]

I have created and tested a new patch. This time it seems to work even when giving Manuskript a bit of a workout.

[Simon Quigley (tsimonq2)]

Wheeeeeeeee.

[Mauricio Faria de Oliveira (mfo)]

Hi Aaron and Simon,

Thanks for the additional fix!

The upload does not take into account the previous version that had been accepted [1]/removed from -proposed [2] (build command likely needs '-v0.12.0-1' so the .changes file includes ubuntu0.22.04.1 before .2).

Also, although a bit of style/preference, I would strongly suggest using the upstream patches individually, as this preserves author information and simplifies DEP-3 tags (in practice, most SRUs with patches use a git-based patch plus Origin: and Bug-Ubuntu:, AFAICT), and makes the changes more contained and easier to review.

I'll attach such debdiff for reference, for your consideration.
Could you please re-upload based on the 2 points above, if you agree?

Thanks again!

[1] https://launchpad.net/ubuntu/+source/manuskript/0.12.0-1ubuntu0.22.04.1
[2] https://launchpad.net/ubuntu/+source/manuskript/+publishinghistory

[Aaron Rainbolt (arraybolt3)]

Full ACK. I have some style changes I would make if it were me, but I'm not about to block a good bugfix over packaging style. I do not have the upload privileges, so if you would like to sponsor this, that would be great.

[Mauricio Faria de Oliveira (mfo)]

Aaron confirmed the package builds and works correctly in #ubuntu-release.
Uploaded to Jammy.
Thanks!

<arraybolt3> mfo: Tested and functional. Thank you!
<arraybolt3> (I followed the test plan as laid out in the SRU, except reusing an existing VM and I did two steps in a slightly different order.)

[Steve Langasek (vorlon)]

Hello Biep, or anyone else affected,

Accepted manuskript into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/manuskript/0.12.0-1ubuntu0.22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Aaron Rainbolt (arraybolt3)]

Full test plan run through on Jammy in the correct order. All operations went as expected.

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for manuskript has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package manuskript - 0.12.0-1ubuntu0.22.04.2

---------------
manuskript (0.12.0-1ubuntu0.22.04.2) jammy; urgency=medium

  * Improve upstream fixes for Python 3.10. (LP: #1989203)
    - d/p/fix_qcolor_types.patch: remove; switch to git patch.
    - d/p/lp1989203-1-fix_qcolor_types.patch
    - d/p/lp1989203-2-adjusted-fixes-for-python-3.10.patch

manuskript (0.12.0-1ubuntu0.22.04.1) jammy; urgency=medium

  * debian/patches/fix_qcolor_types.patch: Backport commit
    15edb6efb7305b9d1a192712660857ca38facace from upstream, ensuring that QColor
    is not accidentally passed floating-point numbers. (LP: #1989203)
  * debian/control: Update the Maintainer field

 -- Aaron Rainbolt <email address hidden> Wed, 27 Dec 2023 19:51:27 +0000