Add support of TAS2781 amp of audio

Bug #2064064 reported by AaronMa
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
In Progress
High
AaronMa
linux (Ubuntu)
In Progress
High
Unassigned
Jammy
Won't Fix
Undecided
Unassigned
Mantic
Won't Fix
Undecided
Unassigned
Noble
Fix Committed
High
Unassigned
linux-firmware (Ubuntu)
Invalid
High
Unassigned
Jammy
Fix Released
High
Unassigned
Mantic
Won't Fix
Undecided
Unassigned
Noble
Fix Released
High
Unassigned
linux-oem-6.5 (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
High
Unassigned
Mantic
Invalid
High
Unassigned
Noble
Invalid
Undecided
Unassigned

Bug Description

[Impact]
No output from the right speaker.

[Fix]
Add driver for TAS2781 and firmware to support the new hardware.

[Test]
Tested on hardware, the output of speakers works fine
on bootup and resume for 10 times.

[Where problems could occur]
It may break audio output.

It includes 7 commits from 6.8 kernel and 1 from 6.9-rc5 as a new driver.
SRU for OEM-6.5 and Noble only.

AaronMa (mapengyu)
tags: added: oem-priority originate-from-2059381 sutton
Changed in linux (Ubuntu Mantic):
status: New → Won't Fix
Changed in linux (Ubuntu Jammy):
status: New → Won't Fix
Changed in linux-firmware (Ubuntu Mantic):
status: New → Won't Fix
Changed in linux-oem-6.5 (Ubuntu Jammy):
status: New → In Progress
Changed in linux-oem-6.5 (Ubuntu Mantic):
importance: Undecided → High
status: New → Invalid
Changed in linux-oem-6.5 (Ubuntu Noble):
status: New → Invalid
Changed in hwe-next:
importance: Undecided → High
status: New → In Progress
assignee: nobody → AaronMa (mapengyu)
Changed in linux (Ubuntu Noble):
importance: Undecided → High
status: New → In Progress
Changed in linux-firmware (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in linux-firmware (Ubuntu Noble):
importance: Undecided → High
status: New → In Progress
Changed in linux-oem-6.5 (Ubuntu Jammy):
importance: Undecided → High
Juerg Haefliger (juergh)
tags: added: kern-10802
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello AaronMa, or anyone else affected,

Accepted linux-firmware into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/20240318.git3b128b60-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in linux-firmware (Ubuntu Noble):
status: In Progress → Fix Committed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello AaronMa, or anyone else affected,

Accepted linux-firmware into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/20220329.git681281e4-0ubuntu3.31 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in linux-firmware (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (linux-firmware/20240318.git3b128b60-0ubuntu2.1)

All autopkgtests for the newly accepted linux-firmware (20240318.git3b128b60-0ubuntu2.1) for noble have finished running.
The following regressions have been reported in tests triggered by the package:

linux-firmware-raspi/unknown (arm64, armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/noble/update_excuses.html#linux-firmware

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
AaronMa (mapengyu) wrote :

Installed 20220329.git681281e4-0ubuntu3.31,
With patched kernel, audio works fine.

Timo Aaltonen (tjaalton)
Changed in linux-oem-6.5 (Ubuntu Jammy):
status: In Progress → Fix Committed
Timo Aaltonen (tjaalton)
Changed in linux-firmware (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-6.5/6.5.0-1023.24 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-oem-6.5' to 'verification-done-jammy-linux-oem-6.5'. If the problem still exists, change the tag 'verification-needed-jammy-linux-oem-6.5' to 'verification-failed-jammy-linux-oem-6.5'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-oem-6.5-v2 verification-needed-jammy-linux-oem-6.5
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.8 KiB)

This bug was fixed in the package linux-oem-6.5 - 6.5.0-1023.24

---------------
linux-oem-6.5 (6.5.0-1023.24) jammy; urgency=medium

  * jammy/linux-oem-6.5: 6.5.0-1023.24 -proposed tracker (LP: #2063580)

  * Add support for Quectel RM520N-GL modem [1eac:1007] (LP: #2063529)
    - bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL modem
    - bus: mhi: host: pci_generic: Add support for Quectel RM520N-GL Lenovo
      variant

  * S2idle regression (LP: #2064595)
    - drm/amd: Evict resources during PM ops prepare() callback
    - drm/amd: Add concept of running prepare_suspend() sequence for IP blocks
    - drm/amd: Flush GFXOFF requests in prepare stage

  * Add support of TAS2781 amp of audio (LP: #2064064)
    - ALSA: hda/tas2781: Add tas2781 HDA driver
    - ALSA: hda/tas2781: Add tas2781 HDA driver
    - ALSA: hda/tas2781: handle missing EFI calibration data
    - ALSA: hda/tas2781: Add new vendor_id and subsystem_id to support ThinkPad
      ICE-1
    - ALSA: hda/realtek: tas2781: enable subwoofer volume control
    - ALSA: hda/tas2781: leave hda_component in usable state
    - ALSA: hda/tas2781: call cleanup functions only once
    - ALSA: hda/tas2781: do not use regcache
    - [Config] enable TAS2781 amplifier

  * Fix system hang while entering suspend with AMD Navi3x graphics
    (LP: #2063417)
    - drm/amdgpu: skip to program GFXDEC registers for suspend abort
    - drm/amdgpu: Reset dGPU if suspend got aborted
    - SAUCE: drm/amdgpu/mes: fix use-after-free issue

  * Add support for Quectel EM160R-GL modem [1eac:100d] (LP: #2063399)
    - bus: mhi: host: pci_generic: Add support for Quectel EM160R-GL modem

  * RTL8852BE fw security fail then lost WIFI function during suspend/resume
    cycle (LP: #2063096)
    - wifi: rtw89: download firmware with five times retry

  * Fix bluetooth connections with 3.0 device (LP: #2063067)
    - Bluetooth: hci_event: Fix handling of HCI_EV_IO_CAPA_REQUEST

  * Fix the RTL8852CE BT FW Crash based on SER false alarm (LP: #2060904)
    - wifi: rtw89: disable txptctrl IMR to avoid flase alarm
    - SAUCE: wifi: rtw89: pci: correct TX resource checking for PCI DMA channel of
      firmware command

  * Add Cirrus Logic CS35L56 amplifier support (LP: #2062135)
    - ASoC: cs35l56: Patch soft registers to defaults
    - ASoC: cs35l56: Move shared data into a common data structure
    - ASoC: cs35l56: Make cs35l56_system_reset() code more generic
    - ASoC: cs35l56: Convert utility functions to use common data structure
    - ASoC: cs35l56: Move utility functions to shared file
    - ASoC: cs35l56: Move runtime suspend/resume to shared library
    - ASoC: cs35l56: Move cs_dsp init into shared library
    - ASoC: cs35l56: Move part of cs35l56_init() to shared library
    - ASoC: cs35l56: Make common function for control port wait
    - ASoC: cs35l56: Make a common function to shutdown the DSP
    - ALSA: hda: Fix missing header dependencies
    - ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier
    - ALSA: hda: realtek: Re-work CS35L41 fixups to re-use for other amps
    - ALSA: hda/realtek: Add quirks for HP G11 Laptops using CS35L56
    - ALSA: hda: cs35l56: Add ACPI ...

Read more...

Changed in linux-oem-6.5 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
AaronMa (mapengyu) wrote :

Verified on 1023-oem kernel, audio play via 2 speakers normally, and mic works fine.

tags: added: verification-done-jammy-linux-oem-6.5
removed: verification-needed-jammy-linux-oem-6.5
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This bug is missing a noble verification for the linux-firmware package. Without that, jammy cannot be released, as users upgrading from jammy to noble would then regress.

AaronMa (mapengyu)
tags: added: verification-needed-noble
tags: removed: verification-needed-noble
tags: added: verification-done-noble
Revision history for this message
AaronMa (mapengyu) wrote :

Installed 20240318.git3b128b60-0ubuntu2.1, with oem-1023 kernel, audio works fine.

Changed in linux (Ubuntu Noble):
status: In Progress → Fix Committed
Revision history for this message
Bin Li (binli) wrote :

With the linux-firmware 20220329.git681281e4-0ubuntu3.31 in jammy-proposed, audio play via 2 speakers normally with 1023-oem kernel.

tags: added: verification-done-jammy
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/6.8.0-38.38 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-noble-linux' to 'verification-done-noble-linux'. If the problem still exists, change the tag 'verification-needed-noble-linux' to 'verification-failed-noble-linux'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-noble-linux-v2 verification-needed-noble-linux
Revision history for this message
AaronMa (mapengyu) wrote :

Boot with 6.8.0-38.38 kernel, both the left and right speakers work fine.

tags: added: verification-done-noble-linux
removed: verification-needed-noble-linux
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 20240318.git3b128b60-0ubuntu2.1

---------------
linux-firmware (20240318.git3b128b60-0ubuntu2.1) noble; urgency=medium

  * Fix the RTL8852CE BT FW Crash based on SER false alarm (LP: #2060904)
    - rtw89: 8852c: update fw to v0.27.56.14
  * Add support for DCN 3.5 (LP: #2063002)
    - amdgpu: add GC 11.5.0 firmware
    - amdgpu: add PSP 14.0.0 firmware
    - amdgpu: add SDMA 6.1.0 firmware
    - amdgpu: add UMSCH 4.0.0 firmware
    - amdgpu: add VCN 4.0.5 firmware
    - amdgpu: add VPE 6.1.0 firmware
    - amdgpu: add DMCUB 3.5 firmware
  * Add Cirrus Logic CS35L56 amplifier support (LP: #2062135)
    - linux-firmware: Add firmware for Cirrus CS35L56 for various HP laptops
  * Fix system hang while entering suspend with AMD Navi3x graphics (LP: #2063417)
    - amdgpu: DMCUB updates for various AMDGPU ASICs
    - amdgpu: DMCUB updates for various AMDGPU ASICs
  * Add support of TAS2781 amp of audio (LP: #2064064)
    - ASoC: tas2781: Add dsp firmware for Thinkpad ICE-1 laptop

 -- Juerg Haefliger <email address hidden> Mon, 06 May 2024 10:17:13 +0200

Changed in linux-firmware (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Update Released

The verification of the Stable Release Update for linux-firmware has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 20220329.git681281e4-0ubuntu3.31

---------------
linux-firmware (20220329.git681281e4-0ubuntu3.31) jammy; urgency=medium

  * Fix the RTL8852CE BT FW Crash based on SER false alarm (LP: #2060904)
    - rtw89: 8852c: update fw to v0.27.56.14
  * vp9 hw decode broken on modern AMD apus, needs amdgpu update (LP: #2058830)
    - amdgpu: Update VCN firmware binaries
  * Add Cirrus Logic CS35L56 amplifier support (LP: #2062135)
    - linux-firmware: Add firmware for Cirrus CS35L56 for various HP laptops
  * Fix system hang while entering suspend with AMD Navi3x graphics (LP: #2063417)
    - amdgpu: DMCUB updates for various AMDGPU ASICs
    - amdgpu: DMCUB updates for various AMDGPU ASICs
  * Add support of TAS2781 amp of audio (LP: #2064064)
    - ASoC: tas2781: Add dsp firmware for different laptops
    - ASoC: tas2781: Add dsp firmware for Thinkpad ICE-1 laptop

 -- Juerg Haefliger <email address hidden> Mon, 06 May 2024 10:46:30 +0200

Changed in linux-firmware (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.