[SRU] Fnic driver on needs to be updated to 1.6.0.57 on Jammy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
Michael Reed | ||
Jammy |
In Progress
|
Undecided
|
Michael Reed | ||
Lunar |
Won't Fix
|
Undecided
|
Michael Reed | ||
Mantic |
Won't Fix
|
Undecided
|
Michael Reed | ||
Noble |
Fix Released
|
Undecided
|
Michael Reed |
Bug Description
[Impact]
fnic_clean_
irrespective of failure or success.
This caused the caller of this function to assume that the
device reset had failed, even though it would succeed in
most cases. As a consequence, a successful device reset
would escalate to host reset.
sgreset is issued with a scsi command pointer.
The device reset code assumes that it was issued
on a hardware queue, and calls block multiqueue
layer. However, the assumption is broken, and
there is no hardware queue associated with the
sgreset, and this leads to a crash due to a
null pointer exception.
[Fix]
Fix the code to use the max_tag_id as a tag
which does not overlap with the other tags
issued by mid layer.
Below are the kernel patches which picked for the newer version of fins driver.
924cb24df4fc scsi: fnic: Stop using the SCSI pointer
b559b99a5c081 scsi: fnic: Replace DMA mask of 64 bits with 47 bits
5a43b07a87835 scsi: fnic: Replace return codes in fnic_clean_
15924b0503630 scsi: fnic: Replace sgreset tag with max_tag_id
514f0c400bde6 scsi: fnic: Fix sg_reset success path
[Test Plan]
Tested by running FC traffic for a few minutes,
and by issuing sgreset on the device in parallel.
Without the fix, the crash is observed right away.
With this fix, no crash is observed.
sg_reset performs a device reset/lun reset on a lun.
Since it is issued by the user, it does not come into the
driver with a tag or a queue id.
Fix the fnic driver to create an io_req and use a scsi command tag.
Fix the ITMF path to special case the sg_reset response.
[ Where problems could occur ]
[ Other Info ]
Jammy
https:/
Mantic
https:/
Links to first 3 patches
https://<email address hidden>/
https://<email address hidden>/
https://<email address hidden>/
Changed in linux (Ubuntu): | |
assignee: | nobody → Michael Reed (mreed8855) |
summary: |
- fnic driver on needs to be updated to 1.6.0.57 on Focal + [SRU] Fnic driver on needs to be updated to 1.6.0.57 on Focal |
description: | updated |
Changed in linux (Ubuntu Lunar): | |
assignee: | nobody → Michael Reed (mreed8855) |
Changed in linux (Ubuntu Jammy): | |
assignee: | nobody → Michael Reed (mreed8855) |
summary: |
- [SRU] Fnic driver on needs to be updated to 1.6.0.57 on Focal + [SRU] Fnic driver on needs to be updated to 1.6.0.57 on Jammy |
Changed in linux (Ubuntu Noble): | |
status: | Incomplete → Fix Released |
Changed in linux (Ubuntu Mantic): | |
status: | Incomplete → In Progress |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 2036777
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.