vmxnet3: update to latest ToT

[Ronak Doshi]

This request is to port vmxnet3 patches to Ubuntu kernel. Below are the commits in order:

vmxnet3: prepare for version 7 changes https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=55f0395fcace9e675af2cbb96015ce1ae8856806

vmxnet3: add support for capability registers https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=6f91f4ba046e5de6a6e579620b32b8ecf56873f7

vmxnet3: add support for large passthrough BAR register https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=543fb67405410cc548a72d7a9a4087688d2f56ac

vmxnet3: add support for out of order rx completion https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=2c5a5748105a6bb901579d365c6f93e79f282b69

vmxnet3: add command to set ring buffer sizes https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=c7112ebd27ea0dbe4eecd5c96cad93757e34e73d

vmxnet3: limit number of TXDs used for TSO packet https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=d2857b99a74b082368ee80f359372faa1d051043

vmxnet3: use ext1 field to indicate encapsulated packet https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=60cafa0395c2bed44d13277ed328317ed16a58c0

vmxnet3: update to version 7 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=acc38e041bd304621d4f59cea4849747d13bba9c

vmxnet3: disable overlay offloads if UPT device does not support https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=a56b158a5078b8120d3d72fc9fd44efed5123b12

vmxnet3: do not reschedule napi for rx processing
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=5b91884bf50b21d34bd3daa5c8f8b7e92e0a2c46

This is a request to bring latest Ubuntu LTS releases' vmxnet3 driver up to date with ToT Linux kernel.

[Ronak Doshi (ronakdoshi)]

In general the request to bring the vmxnet3 driver in next upcoming Ubuntu LTS release up-to-date with upstream repo.

Let me know if you need any clarifications.

Thanks,
Ronak

[Ronak Doshi (ronakdoshi)]

== SRU Justification ==
Recently, a couple of features went in vmxnet3 driver. VMWare is requesting these patches in
Bionic and Xenial or upcoming all LTS releases.

== Fixes ==
Mentioned in the description

== Regression Potential ==
Low. Limited to vmxnet3 driver.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1995886

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Ronak Doshi (ronakdoshi)]

This is not a bug, but a task to port the upstream patches to ongoing ubuntu releases.

Thanks,
Ronak

[Ronak Doshi (ronakdoshi)]

Also, ensure below commits are present in the kernel. I am not sure if these are present in Ubuntu latest LTS releases. So, please double check and apply the above ones (in description) on the ones mentioned below.

vmxnet3: prepare for version 6 changes https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=69dbef0d1c22476c422ee255e99d0e112ddd829d

vmxnet3: add support for 32 Tx/Rx queues https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=39f9895a00f4c5f50e4e0a94f710c6a87afb1920

vmxnet3: add support for ESP IPv6 RSS https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=79d124bb36c0662e16e1ae01e7ff68ab80eb67a8

vmxnet3: set correct hash type based on rss information https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=b3973bb40041eb336188d16fcc249000ea3c4bf4

vmxnet3: increase maximum configurable mtu to 9190 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=8c5663e461e6914304bbbf2c1cf67e5dce18740f

vmxnet3: update to version 6 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=ce2639ad6921fbaf8a854b5d1b1033adee685e6e

vmxnet3: fix minimum vectors alloc issue https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=f71ef02f1a4a3c49962fa341ad8de19071f0f9bf

vmxnet3: remove power of 2 limitation on the queues https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/vmxnet3?id=15ccf2f4b09c4443435e815b8086bc161da27e24

[Tim Gardner (timg-tpi)]

Test kernels at (1). Please provide test results.

1 - https://kernel.ubuntu.com/~rtg/vmxnet3-update-to-6.0-lp1995886/

[Tim Gardner (timg-tpi)]

Git repositories at:

git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/jammy jammy-vmxnet3-update-to-6.0-lp1995886
git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/kinetic kinetic-vmxnet3-update-to-6.0-lp1995886

[Ronak Doshi (ronakdoshi)]

Hi Tim,

Can you confirm that these kernels already have patches mentioned in update 5?

Thanks,
Ronak

[Tim Gardner (timg-tpi)]

Ronak,

I did provide the git repo URL in #7 for you to examine what sources went into the test kernel.

A quick check of the Jammy repo indicates that all of the patches mentioned in #5 are included.

rtg

[vmware-gos-Yuhua (yhzou)]

> Can you confirm that these kernels already have patches mentioned in update 5?

Reply #5 and #8:
I can find all patches mentioned in update #5 when check the source code of vmxnet3 driver in the following images:

1) Image: ubuntu-22.10-desktop-amd64.iso
   kernel: 5.19.0-23-generic #24
   vmxnet3: /lib/modules/5.19.0-23-generic/kernel/drivers/net/vmxnet3/vmxnet3.ko
   vmxnet3 version: 1.6.0.0-k
   source code: /usr/src/linux-source-5.19.0/linux-source-5.19.0/drivers/net/vmxnet3/

2) Image: ubuntu-20.04-desktop-amd64.iso
   kernel: 5.15.0-30-generi #31
   vmxnet3: /lib/modules/5.15.0-30-generic/kernel/drivers/net/vmxnet3/vmxnet3.ko
   vmxnet3 version: 1.6.0.0-k
   source code: /usr/src/linux-source-5.15.0/linux-source-5.15.0/drivers/net/vmxnet3/

Best regards
Yuhua Zou

[vmware-gos-Yuhua (yhzou)]

Test kernel from https://kernel.ubuntu.com/~rtg/vmxnet3-update-to-6.0-lp1995886/ in ubuntu-22.10-desktop-amd64.iso and ubuntu-20.04-desktop-amd64.iso:
 No issue is found when sanity check vmxnet3 with following testcases:
  1) vmxnet3 version is 1.7.0.0-k with command "modinfo vmxnet3"
  2) hot-add / hot-remove NIC with vmxnet3
  3) add / remove NIC with vmxnet3 when VM is poweroff
  4) VM can recognize the vmxnet3 NIC when it’s added and the VM is pingable.

Env:
create VM and install guestOS with the image in ESXi and then update the kernel from https://kernel.ubuntu.com/~rtg/vmxnet3-update-to-6.0-lp1995886/

1) Image: ubuntu-22.10-desktop-amd64.iso
   kernel: 5.19.0-23-generic #24
   vmxnet3: /lib/modules/5.19.0-23-generic/kernel/drivers/net/vmxnet3/vmxnet3.ko
   vmxnet3 version: 1.7.0.0-k

2) Image: ubuntu-20.04-desktop-amd64.iso
   kernel: 5.15.0-53-generi #59
   vmxnet3: /lib/modules/5.15.0-53-generic/kernel/drivers/net/vmxnet3/vmxnet3.ko
   vmxnet3 version: 1.7.0.0-k

Best regards
Yuhua Zou

[Ronak Doshi (ronakdoshi)]

Hello Tim,

What is the status of these patches? Have they been merged to any release?

Thanks,
Ronak

[Ronak Doshi (ronakdoshi)]

Hello Team,

Can I get an update on this?

Thanks,
Ronak

[Ronak Doshi (ronakdoshi)]

Hello Tim, Team,

Can I get an update on this?

Thanks,
Ronak

[Utkarsh Gupta (utkarsh)]

Ubuntu 22.10 (Kinetic Kudu) has reached end of life, so this bug will not be fixed for that specific release.