Hi Ketan,

Thanks for this.  I'm waiting on advice from the kernel team now.. I'm not
sure if I should send a PR based on the branch I patched using your patch
set, or if I should just send the patch set directly to the kernel team ML
for consideration.  Indeed I was able to successfully apply all the patches
to a fresh master-next branch so now I just need to get advice on the best
way to request the inclusion.

Thanks
Jeff

On Mon, Jan 9, 2023 at 12:05 AM Ketan Mukadam <email address hidden>
wrote:

> Jeff, any update for merging patches into Jammy? Thanks
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1988711
>
> Title:
>   Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5 for Ubuntu 22.04
>
> Status in linux package in Ubuntu:
>   In Progress
> Status in linux source package in Jammy:
>   In Progress
> Status in linux source package in Kinetic:
>   Fix Released
>
> Bug description:
>   [IMPACT/Justification]
>   There are numerous bug fixes included in the more recent version of lpfc
> That Broadcom has asked to pull into Jammy and Kinetic to better support
> customers in the field who are using the GA kernel and cant or wont move to
> the HWE kernels.  These all are limited to the lpfc driver itself, no
> patches to core code are requested.
>
>   [FIX]
>   A few of these were already landed in Jammy, and all but 6 (ones landed
> in 6.0 upstream) were already in Kinetic.
>
>   b3d11f195cbb scsi: lpfc: Copyright updates for 14.2.0.5 patches
>   71faf8d30fdb scsi: lpfc: Update lpfc version to 14.2.0.5
>   b21c9deb1479 scsi: lpfc: Refactor lpfc_nvmet_prep_abort_wqe() into
> lpfc_sli_prep_abort_xri()
>   ffc566411ade scsi: lpfc: Revert RSCN_MEMENTO workaround for misbehaved
> configuration
>   ea92e173dc55 scsi: lpfc: Fix lost NVMe paths during LIF bounce stress
> test
>   2f67dc7970bc scsi: lpfc: Fix possible memory leak when failing to issue
> CMF WQE
>   0948a9c53860 scsi: lpfc: Remove extra atomic_inc on cmd_pending in
> queuecommand after VMID
>   35251b4d79db scsi: lpfc: Set PU field when providing D_ID in
> XMIT_ELS_RSP64_CX iocb
>   f8191d40aa61 scsi: lpfc: Prevent buffer overflow crashes in debugfs with
> malformed user input
>   4ecc9b0271a7 scsi: lpfc: Fix uninitialized cqe field in
> lpfc_nvme_cancel_iocb()
>   1af48fffd7ff scsi: lpfc: Update lpfc version to 14.2.0.4
>   2e7e9c0c1ec0 scsi: lpfc: Allow reduced polling rate for
> nvme_admin_async_event cmd completion
>   ea7bd1f39331 scsi: lpfc: Add more logging of cmd and cqe information for
> aborted NVMe cmds
>   336d63615466 scsi: lpfc: Fix port stuck in bypassed state after LIP in
> PT2PT topology
>   b1b3440f437b scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO
> is aborted
>   6f808bd78e82 scsi: lpfc: Address NULL pointer dereference after
> starget_to_rport()
>   e27f05147bff scsi: lpfc: Resolve some cleanup issues following SLI path
> refactoring
>   24e1f056677e scsi: lpfc: Resolve some cleanup issues following abort
> path refactoring
>   44ba9786b673 scsi: lpfc: Correct BDE type for XMIT_SEQ64_WQE in
> lpfc_ct_reject_event()
>   a5b168efba21 scsi: lpfc: Add support for ATTO Fibre Channel devices
>   348efeca7487 scsi: lpfc: Rework lpfc_vmid_get_appid() to be protocol
> independent
>   ed913cf4a533 scsi: lpfc: Commonize VMID code location
>   fcb9e738667c scsi: lpfc: Update lpfc version to 14.2.0.3
>   a14396b6d139 scsi: lpfc: Use sg_dma_address() and sg_dma_len() macros
> for NVMe I/O
>   e6f510414502 scsi: lpfc: Alter FPIN stat accounting logic
>   de3ec318fee3 scsi: lpfc: Rework FDMI initialization after link up
>   5099478e436f scsi: lpfc: Change VMID registration to be based on fabric
> parameters
>   dc8a71bd414f scsi: lpfc: Decrement outstanding gidft_inp counter if
> lpfc_err_lost_link()
>   4a0f4aff3ce5 scsi: lpfc: Use list_for_each_entry_safe() in
> rscn_recovery_check()
>   596fc8adb171 scsi: lpfc: Fix dmabuf ptr assignment in
> lpfc_ct_reject_event()
>   ead76d4c09b8 scsi: lpfc: Inhibit aborts if external loopback plug is
> inserted
>   b7e952cbc63c scsi: lpfc: Fix ndlp put following a LOGO completion
>   ba3d58a1df46 scsi: lpfc: Fill in missing ndlp kref puts in error paths
>   84c6f99e3907 scsi: lpfc: Fix element offset in
> __lpfc_sli_release_iocbq_s4()
>   775266207105 scsi: lpfc: Correct BDE DMA address assignment for
> GEN_REQ_WQE
>   cc28fac16ab7 scsi: lpfc: Fix split code for FLOGI on FCoE
>   c2024e3b33ee scsi: lpfc: Remove redundant lpfc_sli_prep_wqe() call
>   92bd903da12b scsi: lpfc: Fix additional reference counting in
> lpfc_bsg_rport_els()
>   db05628435aa blk-cgroup: move blkcg_{get,set}_fc_appid out of line
>   646db1a560f4 scsi: lpfc: Fix resource leak in lpfc_sli4_send_seq_to_ulp()
>   3d1d34ec1fbc scsi: lpfc: Remove unnecessary null ndlp check in
> lpfc_sli_prep_wqe()
>   a346f28ad231 scsi: lpfc: Remove unneeded variable
>   66c20a97367a scsi: lpfc: Copyright updates for 14.2.0.2 patches
>   4af4d0e2ea94 scsi: lpfc: Update lpfc version to 14.2.0.2
>   fd4a0c6da5c1 scsi: lpfc: Expand setting ELS_ID field in ELS_REQUEST64_WQE
>   f4fbf4acaa50 scsi: lpfc: Update stat accounting for READ_STATUS mbox
> command
>   ef47575fd982 scsi: lpfc: Refactor cleanup of mailbox commands
>   d51cf5bd926c scsi: lpfc: Fix field overload in lpfc_iocbq data structure
>   1045592fc968 scsi: lpfc: Introduce FC_RSCN_MEMENTO flag for tracking
> post RSCN completion
>   6c983d327b9e scsi: lpfc: Register for Application Services FC-4 type in
> Fabric topology
>   6c8a3ce64b2c scsi: lpfc: Remove false FDMI NVMe FC-4 support for NPIV
> ports
>   c364c453d30a scsi: lpfc: Revise FDMI reporting of supported port speed
> for trunk groups
>   d6d45f67a111 scsi: lpfc: Fix call trace observed during I/O with CMF
> enabled
>   5295d19d4f97 scsi: lpfc: Correct CRC32 calculation for congestion stats
>   39a1a86b9da2 scsi: lpfc: Move MI module parameter check to handle
> dynamic disable
>   d531d9874da8 scsi: lpfc: Remove unnecessary NULL pointer assignment for
> ELS_RDF path
>   76395c88d0af scsi: lpfc: Transition to NPR state upon LOGO cmpl if link
> down or aborted
>   31e887864eb2 scsi: lpfc: Update fc_prli_sent outstanding only after
> guaranteed IOCB submit
>   672d1cb40551 scsi: lpfc: Protect memory leak for NPIV ports sending
> PLOGI_RJT
>   577a942df3de scsi: lpfc: Fix null pointer dereference after failing to
> issue FLOGI and PLOGI
>   3483a44bdfb4 scsi: lpfc: Clear fabric topology flag before initiating a
> new FLOGI
>   03cbbd7c2f5e scsi: lpfc: Fix SCSI I/O completion and abort handler
> deadlock
>   b6474465e962 scsi: lpfc: Requeue SCSI I/O to upper layer when fw reports
> link down
>   787d0580ca18 scsi: lpfc: Zero SLI4 fcp_cmnd buffer's fcpCntl0 field
>   a6de9a2fa0d6 scsi: lpfc: Fix diagnostic fw logging after a function reset
>   e294647b1aed scsi: lpfc: Move cfg_log_verbose check before calling
> lpfc_dmp_dbg()
>   b83a8c21f3fe scsi: lpfc: Tweak message log categories for ELS/FDMI/NVMe
> rescan
>   c26bd6602e1d scsi: lpfc: Fix locking for lpfc_sli_iocbq_lookup()
>   7294a9bcaa7e scsi: lpfc: Fix broken SLI4 abort path
>   4f3beb36b1e4 scsi: lpfc: Update lpfc version to 14.2.0.1
>   df0101197c4d scsi: lpfc: Fix queue failures when recovering from PCI
> parity error
>   a4691038b407 scsi: lpfc: Fix unload hang after back to back PCI EEH
> faults
>   35ed9613d83f scsi: lpfc: Improve PCI EEH Error and Recovery Handling
>   f45775bf562a scsi: lpfc: Copyright updates for 14.2.0.0 patches
>   64de6108f410 scsi: lpfc: Update lpfc version to 14.2.0.0
>   0e082d926f59 scsi: lpfc: SLI path split: Refactor BSG paths
>   31a59f75702f scsi: lpfc: SLI path split: Refactor Abort paths
>   3512ac094293 scsi: lpfc: SLI path split: Refactor SCSI paths
>   61910d6a5243 scsi: lpfc: SLI path split: Refactor CT paths
>   2d1928c57df6 scsi: lpfc: SLI path split: Refactor misc ELS paths
>   351849800157 scsi: lpfc: SLI path split: Refactor VMID paths
>   9d41f08aa2eb scsi: lpfc: SLI path split: Refactor FDISC paths
>   e0367dfe90d6 scsi: lpfc: SLI path split: Refactor LS_RJT paths
>   3f607dcb43f1 scsi: lpfc: SLI path split: Refactor LS_ACC paths
>   3bea83b68d54 scsi: lpfc: SLI path split: Refactor the
> RSCN/SCR/RDF/EDC/FARPR paths
>   cad93a089031 scsi: lpfc: SLI path split: Refactor PLOGI/PRLI/ADISC/LOGO
> paths
>   6831ce129f19 scsi: lpfc: SLI path split: Refactor base ELS paths and the
> FLOGI path
>   561341425bcc scsi: lpfc: SLI path split: Introduce lpfc_prep_wqe
>   1b64aa9eae28 scsi: lpfc: SLI path split: Refactor fast and slow paths to
> native SLI4
>   a680a9298e7b scsi: lpfc: SLI path split: Refactor lpfc_iocbq
>   dc2646417d54 scsi: lpfc: Use kcalloc()
>   9a866e6aaf4e scsi: lpfc: Fix typos in comments
>   e81ce97f5716 scsi: lpfc: Use rport as argument for lpfc_chk_tgt_mapped()
>   123a3af35d08 scsi: lpfc: Use rport as argument for lpfc_send_taskmgmt()
>   bb21fc9911ee scsi: lpfc: Use fc_block_rport()
>   45c59287ff01 scsi: lpfc: Drop lpfc_no_handler()
>   bf180cc1a5da scsi: lpfc: Kill lpfc_bus_reset_handler()
>   7f4c5a26f735 scsi: lpfc: Fix pt2pt NVMe PRLI reject LOGO loop
>   5852ed2a6a39 scsi: lpfc: Reduce log messages seen after firmware download
>   c80b27cfd93b scsi: lpfc: Remove NVMe support if kernel has NVME_FC
> disabled
>   d1d87c33f47d scsi: lpfc: Remove redundant flush_workqueue() call
>   ce5a58a96ccc scsi: lpfc: Use irq_set_affinity()
>
>   [TESTCASE]
>   modinfo for lpfc should indicate version is 14.2.0.5 or greater.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1988711/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: distribution=ubuntu; sourcepackage=linux; component=main;
> status=In Progress; importance=Medium; <email address hidden>
> ;
> Launchpad-Bug: distribution=ubuntu; distroseries=jammy;
> sourcepackage=linux; component=main; status=In Progress; importance=Medium;
> <email address hidden>;
> Launchpad-Bug: distribution=ubuntu; distroseries=kinetic;
> sourcepackage=linux; component=main; status=Fix Released;
> importance=Medium; <email address hidden>;
> Launchpad-Bug-Tags: kernel-spammed-kinetic-linux scd-1
> verification-needed-kinetic
> Launchpad-Bug-Information-Type: Public
> Launchpad-Bug-Private: no
> Launchpad-Bug-Security-Vulnerability: no
> Launchpad-Bug-Commenters: aravindvalloormana bladernr janitor
> ketan-mukadam ubuntu-kernel-bot
> Launchpad-Bug-Reporter: Aravind Valloor Mana (aravindvalloormana)
> Launchpad-Bug-Modifier: Ketan Mukadam (ketan-mukadam)
> Launchpad-Message-Rationale: Subscriber
> Launchpad-Message-For: bladernr
>
>

-- 
Jeff Lane
Engineering Manager
IHV/OEM Alliances and Server Certification

"Entropy isn't what it used to be."