[Ubuntu 22.04] mpt3sas: Request to include latest bug fix patches

[Sreekanth Reddy]

[Impact]
Request to include below mpt3sas driver bug fix patches in Ubuntu 22.04 kernel. These patches got accepted by the upstream and please find the corresponding commit IDs as below,

5db207d66d mpt3sas: Fix incorrect 4gb boundary check
ca23ac823c mpt3sas: Remove scsi_dma_map errors messages
9211faa39a scsi: mpt3sas: Update persistent trigger pages from sysfs interface

[Fix]
Below is the summary of each of the above bug fix commits,

1. mpt3sas: Fix incorrect 4gb boundary check:
   Without this patch, driver was checking whether any of it's pool crosses the 4gb boundary or not using the pool's virtual address instead of using it's dma address. So some time driver may false positively assume that the pool as crossed the 4gb boundary region (as it observes that pool's virtual address is crossing the 4gb boundary) even though it is really not.

2. mpt3sas: Remove scsi_dma_map errors messages:
   When driver set the DMA mask to 32bit then we observe that the SWIOTLB bounce buffers are getting exhausted quickly. For most of the IOs driver observe that scsi_dma_map() API returned with failure status and hence driver was printing below error message. Since this error message is getting printed per IO and if user issues heavy IOs then we observe that kernel overwhelmed with this error message. Also we will observe the kernel panic when the serial console is enabled. So to limit this issue, we removed this error message though this patch.
    "scsi_dma_map failed: request for 1310720 bytes!"

3. mpt3sas: Update persistent trigger pages from sysfs interface:
   When user set's any diag buffer trigger conditions then driver has to save these trigger conditions in the controller Firmware's NVRAM region. So that when system reboots then driver can get these trigger conditions from Firmware's NVRAM region and set these trigger conditions automatically. so that user no need to set these conditions again. Without this patch driver was not not saving these user provided trigger conditions in the Firmware's NVRAM region.

Please let me if I have missed to add any data.

[Test Plan]

1. All drives attached to the controller are Enumerated in OS
2. IO stress for 5Hrs
3. Created a filesystem and done some IO transitions
4. Controller reset and TMs and while IOs are running
5. driver load and unload
6. Reboot loop
7. Verified that the diag trigger settings are persistent across the reboots.

[Where problems could occur]

The regression risk is low.

[Other Info]

https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/mpt3sas_lp_1965927

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1965927

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Sreekanth Reddy (srreddy)]

I don't see above bug fixes changes in the below jammy repository and hence raised this launchpad to consider these bug fixes,

https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy/log/drivers/scsi/mpt3sas?h=master-next

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1965927

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Jeff Lane  (bladernr)]

5.19/scsi-staging as of 4/7/2022, need to wait until it at least merges into linux-next.

Correction:
9211faa39a found in 5.17

The other two I've searched various branches of scsi-staging and haven't found them yet, nor did I find them in mainline or linux-next.

[Launchpad Janitor (janitor)]

[Expired for linux (Ubuntu) because there has been no activity for 60 days.]

[Michael Reed (mreed8855)]

The first patch (scsi: mpt3sas: Fix incorrect 4GB boundary check) was included in 5.15.33:

https://bugs.launchpad.net/bugs/1969110

[Michael Reed (mreed8855)]

I have located 9211faa39a scsi: mpt3sas: Update persistent trigger pages from sysfs interface in the linux-next tree but the second patch "ca23ac823c mpt3sas: Remove scsi_dma_map errors messages" has yet to show up in linux-next

[Michael Reed (mreed8855)]

I did locate the second patch and I have created a test kernel, please test

https://people.canonical.com/~mreed/misc/lp_1965927_mpt3sas/

[Michael Reed (mreed8855)]

Hi Sreekanth,

Have you had an opportunity to test the test kernel in comment #8?

[Sreekanth Reddy (srreddy)]

Hi,

I have tested the mpt3sas driver embodied in the above provided test kernel. Results are positive and no issue is found during the testing.

Below are the main test cases that got executed during the testing and results of these test cases are positive,

1. All drives attached to the controller are Enumerated in OS
2. IO stress for 5Hrs
3. Created a filesystem and done some IO transitions
4. Controller reset and TMs and while IOs are running
5. driver load and unload
6. Reboot loop
7. Verified that the diag trigger settings are persistent across the reboots.

Thanks,
Sreekanth

[Michael Reed (mreed8855)]

Hi Sreekanth,

Can you tell me what the regression risk is with this set of patches?

Thanks,
Michael

[Sreekanth Reddy (srreddy)]

Hi Michael,

Regression risk of this patch set is very less. It just includes minor bug fixes. We have tested these patches and didn't find any issues.

Thanks,
Sreekanth

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.15.0-53.59

---------------
linux (5.15.0-53.59) jammy; urgency=medium

  * Fix blank screen on Thinkpad ADL 4K+ panel (LP: #1980621)
    - drm/i915: Implement WaEdpLinkRateDataReload

  * Kernel regresses openjdk on riscv64 (LP: #1992484)
    - SAUCE: Revert "riscv: mmap with PROT_WRITE but no PROT_READ is invalid"

  * iavf: SR-IOV VFs error with no traffic flow when MTU greater than 1500
    (LP: #1983656)
    - iavf: Fix set max MTU size with port VLAN and jumbo frames
    - i40e: Fix VF set max MTU size

  * [Ubuntu 22.04] mpt3sas: Request to include latest bug fix patches
    (LP: #1965927)
    - scsi: mpt3sas: Remove scsi_dma_map() error messages
    - scsi: mpt3sas: Update persistent trigger pages from sysfs interface

  * ACPI: processor idle: Practically limit "Dummy wait" workaround to old Intel
    systems (LP: #1990985)
    - ACPI: processor idle: Practically limit "Dummy wait" workaround to old Intel
      systems

  * Fix resume on AMD platforms when TBT monitor is plugged (LP: #1990920)
    - SAUCE: Revert "drm/amd/display: Add helper for blanking all dp displays"
    - drm/amd/display: Detect dpcd_rev when hotplug mst monitor
    - drm/amd/display: Release remote dc_sink under mst scenario

  * LSM: Configuring Too Many LSMs Causes Kernel Panic on Boot (LP: #1987998)
    - SAUCE: LSM: Change Landlock from LSMBLOB_NEEDED to LSMBLOB_NOT_NEEDED

  * To support Intel Maple Ridge Thunderbolt [8086:1134] (LP: #1990240)
    - thunderbolt: Add support for Intel Maple Ridge single port controller

  * Intel graphic driver is not probing[8086:468b] (LP: #1990242)
    - drm/i915/adl_s: Update ADL-S PCI IDs
    - drm/i915: Add new ADL-S pci id

  * Add HDMI codec ID for Intel Raptor Lake (LP: #1989578)
    - ALSA: hda: Add PCI and HDMI IDs for Intel Raptor Lake

  * Jammy update: v5.15.64 upstream stable release (LP: #1991717)
    - wifi: rtlwifi: remove always-true condition pointed out by GCC 12
    - eth: sun: cassini: remove dead code
    - audit: fix potential double free on error path from fsnotify_add_inode_mark
    - cgroup: Fix race condition at rebind_subsystems()
    - parisc: Make CONFIG_64BIT available for ARCH=parisc64 only
    - parisc: Fix exception handler for fldw and fstw instructions
    - kernel/sys_ni: add compat entry for fadvise64_64
    - x86/entry: Move CLD to the start of the idtentry macro
    - block: add a bdev_max_zone_append_sectors helper
    - block: add bdev_max_segments() helper
    - btrfs: zoned: revive max_zone_append_bytes
    - btrfs: replace BTRFS_MAX_EXTENT_SIZE with fs_info->max_extent_size
    - btrfs: convert count_max_extents() to use fs_info->max_extent_size
    - Input: i8042 - move __initconst to fix code styling warning
    - Input: i8042 - merge quirk tables
    - Input: i8042 - add TUXEDO devices to i8042 quirk tables
    - Input: i8042 - add additional TUXEDO devices to i8042 quirk tables
    - drivers/base: fix userspace break from using bin_attributes for cpumap and
      cpulist
    - scsi: qla2xxx: Fix response queue handler reading stale packets
    - scsi: qla2xxx: edif: Fix dropped IKE message
    - btrfs: put initial index value of a...

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux-bluefield/5.15.0-1010.12 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux-nvidia/5.15.0-1011.11 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Paul Menzel (paulmenzel)]

For the record:

> 5db207d66d mpt3sas: Fix incorrect 4gb boundary check
> ca23ac823c mpt3sas: Remove scsi_dma_map errors messages
> 9211faa39a scsi: mpt3sas: Update persistent trigger pages from sysfs interface

The upstream commit hashes from Linux’ master branch are:

1. 208cc9fe6f21112b5cc6cb87065fb8ab66e79316 (scsi: mpt3sas: Fix incorrect 4GB boundary check), v5.18-rc1
2. 0c25422d34b4726b2707d5f38560943155a91b80 (scsi: mpt3sas: Remove scsi_dma_map() error messages), v5.18-rc1
3. 9211faa39a0350fb2239a0bce03b9459cd14fc40 (scsi: mpt3sas: Update persistent trigger pages from sysfs interface), v5.17-rc1

Only the first one has been backported to the Linux 5.15 series upstream. The second one has been queued up by Greg today [1], and, probably the third one should be backported too.

[1]: https://<email address hidden>/T/#t

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux-mtk/5.15.0-1030.34 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-mtk' to 'verification-done-jammy-linux-mtk'. If the problem still exists, change the tag 'verification-needed-jammy-linux-mtk' to 'verification-failed-jammy-linux-mtk'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Ranjan Kumar (kranjan2404)]

Please provide the kernel link on which testing is needed.

[Ranjan Kumar (kranjan2404)]

Hi,

I have tested the mpt3sas driver embodied in the above-provided test kernel. Results are positive and no issue is found during the testing.

Below are the test cases that got executed during the testing and the results of these test cases are positive,

1. All drives attached to the controller are Enumerated in OS
2. IO stress done
3. Created a filesystem and done some IO transitions
4. Controller reset and TMs and while IOs are running
5. driver load and unload

Thanks,
Ranjan