kernel panic when using conntrack tcp pedit

[William Tu]

* Explain the bug(s)

when setting up conntrack offload with tcp pedit (test-ct-tcp-pedit.sh), encounter kernel panic.

* brief explanation of fixes

In tc_setup_flow_action, need to properly assign action.
Which fixes previous commit ("UBUNTU: SAUCE: net/sched: Provide act to offload action")

* Kernel log

[ 226.156222] Unable to handle kernel access to user memory outside uaccess routines at
[ 226.177783] Mem abort info:
[ 226.183408] ESR = 0x0000000096000004
[ 226.190953] EC = 0x25: DABT (current EL), IL = 32 bits
[ 226.201641] SET = 0, FnV = 0
[ 226.207786] EA = 0, S1PTW = 0
[ 226.214095] FSC = 0x04: level 0 translation fault
[ 226.223906] Data abort info:
[ 226.229695] ISV = 0, ISS = 0x00000004
[ 226.237410] CM = 0, WnR = 0
[ 226.243372] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000123f25000
[ 226.256328] [0000000000000090] pgd=0000000000000000, p4d=0000000000000000
[ 226.269984] Internal error: Oops: 96000004 [#1] SMP
[ 226.279779] Modules linked in: act_pedit act_ct nf_flow_table iptable_raw xt_CT xt_tcpudp bpfilter xt_comment xt_mark
[ 226.279938] async_raid6_recov async_memcpy async_pq async_xor async_tx xor xor_neon raid6_pq raid1 raid0 multipath
[ 226.544260] CPU: 2 PID: 4293 Comm: handler3 Tainted: G
[ 226.565581] Hardware name: https://www.mellanox.com BlueField SoC/BlueField SoC, BIOS 4.2.0.12795 Jun 30 2023
[ 226.585497] pstate: a0400005 (NzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 226.599481] pc : tcf_action_update_stats+0x8/0xc4
[ 226.608933] lr : mlx5e_tc_act_stats_fill_stats+0xf8/0x19c [mlx5_core]
[ 226.622089] sp : ffff80000e073130
[ 226.628735] x29: ffff80000e073130 x28: 0000000000000008 x27: 0000000000000020
[ 226.643067] x26: ffffffffffffffe0 x25: ffff5913c62dfe71 x24: ffff5913c62dfe00
[ 226.657398] x23: 0000000000000000 x22: 0000000000000000 x21: ffff5913c62dfe70
[ 226.671730] x20: ffff5913c2fc3b00 x19: ffff5913f0058000 x18: 0000000000000014
[ 226.686059] x17: 00000000b96d1a87 x16: ffffc6320acb93e0 x15: 0000000000000000
[ 226.700390] x14: 0000000000000001 x13: 0000000000000000 x12: 0000000000000002
[ 226.714720] x11: 7f7f7f7f7f7f7f7f x10: 0000000000000000 x9 : ffffc631ce0b66ac
[ 226.729052] x8 : ffff80000e073130 x7 : 0000000000000000 x6 : 000000000000000d
[ 226.743384] x5 : 0000000000000c62 x4 : 0000000000000001 x3 : 0000000000000000
[ 226.757715] x2 : 0000000000000000 x1 : 0000000000000000 x0 : 0000000000000000
[ 226.772047] Call trace:
[ 226.776947] tcf_action_update_stats+0x8/0xc4
[ 226.785695] mlx5e_tc_act_stats_fill_stats_flow+0x78/0xc0 [mlx5_core]
[ 226.798833] mlx5e_stats_flower+0x394/0x3c0 [mlx5_core]
[ 226.809502] mlx5e_rep_setup_tc_cls_flower+0x8c/0xa0 [mlx5_core]
[ 226.821732] mlx5e_rep_setup_tc_cb+0x74/0xb0 [mlx5_core]
[ 226.832549] tc_setup_cb_call+0xa4/0x160
[ 226.840426] fl_hw_update_stats+0x98/0x164 [cls_flower]
[ 226.850927] fl_dump.part.0+0x224/0x260 [cls_flower]
[ 226.860891] fl_dump+0x20/0x34 [cls_flower]
[ 226.869284] tcf_fill_node+0x164/0x244
[ 226.876803] tfilter_notify+0xc0/0x140
[ 226.884323] tc_new_tfilter+0x454/0x8bc
[ 226.892018] rtnetlink_rcv_msg+0x2e8/0x3cc
[ 226.900245] netlink_rcv_skb+0x64/0x130
[ 226.907942] rtnetlink_rcv+0x20/0x30
[ 226.915110] netlink_unicast+0x2ec/0x360
[ 226.922977] netlink_sendmsg+0x278/0x490
[ 226.930846] sock_sendmsg+0x5c/0x6c
[ 226.937845] ____sys_sendmsg+0x290/0x2d4
[ 226.945712] ___sys_sendmsg+0x84/0xd0
[ 226.953059] __sys_sendmsg+0x70/0xd0
[ 226.960229] __arm64_sys_sendmsg+0x2c/0x40
[ 226.968447] invoke_syscall+0x78/0x100
[ 226.975974] el0_svc_common.constprop.0+0x54/0x184
[ 226.985587] do_el0_svc+0x30/0xac
[ 226.992231] el0_svc+0x48/0x160
[ 226.998528] el0t_64_sync_handler+0xa4/0x130
[ 227.007094] el0t_64_sync+0x1a4/0x1a8
[ 227.014444] Code: 9407cf7e d503201f aa1e03e9 d503201f (f9404805)
[ 227.026679] ---[ end trace 2aa44f8c6701f98e ]---
[ 236.273308] Kernel panic - not syncing: Oops: Fatal exception
[ 236.284885] SMP: stopping secondary CPUs
[ 236.292761] Kernel Offset: 0x463201de0000 from 0xffff800008000000
[ 236.304996] PHYS_OFFSET: 0xffffa6ed40000000
[ 236.313387] CPU features: 0x800804a1,20000846
[ 236.322129] Memory Limit: none
[ 273.872736] Rebooting in 10 seconds..

[Bartlomiej Zolnierkiewicz (bzolnier)]

This bug is awaiting verification that the linux-bluefield/5.15.0-1020.22 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!