Desktop area may get clipped to a small rectangle if the hypervisor changes X11 screen resolution during the login animation

[Marco Trevisan (Treviño)]

[ Impact ]

GNOME Shell startup animation may not complete during startup, leading to a non-functional GNOME shell because the workarea could be clipped or input events are ignored.

[ Test case ]

1. Run this script: https://gitlab.gnome.org/3v1n0/gnome-shell/-/snippets/5749
2. It's expected to launch a gnome-shell nested instance and perform monitor changes
3. The shell should animate to the final state and everything should be usable:
   - Clicking in shell widgets should work
   - No area is hidden or clipped

[ Regression potential ]

GNOME Shell may not start properly, input events are ignored and/or the desktop area is clipped.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 81ubuntu1

---------------
gnome-shell-extension-ubuntu-dock (81ubuntu1) mantic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * New upstream release
  * docking: Set dance timeline duration to 1 if animations are disabled
  * appInconIndicators: Improve the computing of the counter badge size
  * notificationsMonitor: Do not count the acknowledged resident notifications
  * docking: Initialize settings before than other classes that could use them
  * notificationsMonitor: Add an options to disable notifications counter only
  * appIconIndicators: Add an option to control whether the counters are summed
  * docking: Initialize the Launcher remote model only if needed
  * locations: Use correct name for default handler finish function
  * locationsWorker: Use more async awaitness
  * docking: Cleanup startup animation injections once done
  * docking: Handling monitors changed events while preparing startup animation
    (LP: #2019751)
  * docking: Keep clip and coverPane size matching current setup (LP: #2019751)
  * schemas: Update some descriptions to match actual behavior
  * docking: Cleanup some stray lines
  * dash: Do DockDash class initialization at first thing
  * dash: Add option to keep the icons always centered in extended mode
  * Settings: improve wording on show-apps option
  * dash: Add option to show the show-apps button bound to icons in panel mode

  [ Amr Ibrahim ]
  * Update German translation
  * Change "dance" to "wiggle"

  [ hasecilu ]
  * Update Spanish translation
  * Update potfile changes to es.po

  [ Daniel van Vugt ]
  * prefs: Set default window height to 850, if it fits

  [ stuarthayhurst ]
  * Fix consistency of fullstops in strings
  * Updated translations

  [ Yaroslav Pronin ]
  * Update Russian translation

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 16 May 2023 01:21:24 +0200

[Daniel van Vugt (vanvugt)]

Did bug 1989170 regress in ubuntu-dock?

Also the issue was reported upstream in https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6473 with a "fix" that went into 44.rc though I'm skeptical that was enough.

[Fabio Augusto Miranda Martins (fabio.martins)]

@Daniel,

My understanding is that bug 2019751 is the same as bug 1989170, but public. Since the fix was not released to Jammy, bug 2019751 aims to address that (although your question might be targeted to Lunar, since I see bug 1989170 was released to Kinetic.

[Marco Trevisan (Treviño) (3v1n0)]

Daniel: No, no regression... It's just that such fix is not enough: there dash-to-dock was handling (properly) the part of Overview startup Animation, but the problem may happen ever earlier.

As explained in https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2763 (that would be the real fix), we may end up awaiting an event that won't ever happen.

Play with those scripts sleep values, and the problem happens since 42.

While we could fix this in gnome-shell itself, I preferred handling it in the dock first, and in future we could backport an upstream fix when merged.

[Andreas Hasenack (ahasenack)]

Is kinetic being skipped on purpose, or is it not affected?

[Andreas Hasenack (ahasenack)]

Hello Marco, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/79ubuntu2.23.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Hello Marco, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/72~ubuntu5.22.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Marco Trevisan (Treviño) (3v1n0)]

After installing the update the nested shell is perfectly usable, and there are not un-clickable areas or invisible areas in the screen.

❯ apt-cache policy gnome-shell-extension-ubuntu-dock
gnome-shell-extension-ubuntu-dock:
  Installed: 72~ubuntu5.22.04.2
  Candidate: 72~ubuntu5.22.04.2
  Version table:
 *** 72~ubuntu5.22.04.2 400
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main i386 Packages
        100 /var/lib/dpkg/status

[Marco Trevisan (Treviño) (3v1n0)]

Also tested the same in lunar, all working as expected following the test case script:

❯ apt-cache policy gnome-shell-extension-ubuntu-dock
gnome-shell-extension-ubuntu-dock:
  Installed: 79ubuntu2.23.04.1
  Candidate: 79ubuntu2.23.04.1
  Version table:
 *** 79ubuntu2.23.04.1 400
        400 http://archive.ubuntu.com/ubuntu lunar-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu lunar-proposed/main i386 Packages
        100 /var/lib/dpkg/status

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 79ubuntu2.23.04.1

---------------
gnome-shell-extension-ubuntu-dock (79ubuntu2.23.04.1) lunar; urgency=medium

  * debian: Update VCS references to ubuntu-dock-lunar branch
  * docking: Handle monitors changes during early startup (LP: #2019751)
    - docking: Cleanup startup animation injections once done
    - docking: Handle monitors changed events while preparing startup animation
    - docking: Keep clip and coverPane size matching current setup

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 16 May 2023 01:47:35 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-shell-extension-ubuntu-dock has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Timo Aaltonen (tjaalton)]

Hello Marco, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/72~ubuntu5.22.04.2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Marco Trevisan (Treviño) (3v1n0)]

Script tested with new version, no failure:

apt-cache policy gnome-shell-extension-ubuntu-dock
gnome-shell-extension-ubuntu-dock:
  Installed: 72~ubuntu5.22.04.2.1
  Candidate: 72~ubuntu5.22.04.2.1
  Version table:
 *** 72~ubuntu5.22.04.2.1 400
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     72~ubuntu5.22.04.1 500
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main i386 Packages
     72~ubuntu5 500
        500 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy/main i386 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72~ubuntu5.22.04.2.1

---------------
gnome-shell-extension-ubuntu-dock (72~ubuntu5.22.04.2.1) jammy; urgency=medium

  * Keep shell overview always visible and usable (LP: #1979096):
    - docking: Do ControlsManagerLayout allocation with box-adjusted workArea
    - docking: Be more consistent in reducing the overlay layout space
    - docking: Add both bottom and top spacing when there are no workspaces

gnome-shell-extension-ubuntu-dock (72~ubuntu5.22.04.2) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * debian/control: Update maintainer to myself
  * Ensure startup animations are performed on monitor changes (LP: #2019751):
    - utils: Ensure we destroy the Signals handler as last thing on destroy
    - docking: Do not wait for dash animation two times with no overview
    - docking: Ensure we perform the startup animation completely on docks
      updates (LP: #1965208)
    - docking: Use a try/catch statement on our promise to show errors in case
    - docking: Cleanup startup animation injections once done
    - docking: Handle monitors changed events while preparing startup animation
    - docking: Keep clip and coverPane size matching current setup
    - docking: Handle when dash is destroyed during the login animation
  * Do not hide the dock when menus are closed (LP: #1983130):
    - docking: Ignore hover changes if overview is visible (LP: #1983130)
    - docking: Check if autohide or intellihide is enabled on menu closed
  * Keep shell overview always visible and usable (LP: #1979096):
    - docking: Also reduce the app grid area when in auto-hide mode
      (LP: #1992847)
    - docking: Use an even width for the overview content area
    - docking: Keep overview controls layout proportions when resizing it
      (LP: #1992847)

  [ Daniel van Vugt ]
  * docking: Handle when dash is destroyed during the login animation
    (LP: #2019751)

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 02 Jun 2023 04:12:06 +0200

[Brian Murray (brian-murray)]

Ubuntu 23.04 (Lunar Lobster) has reached end of life, so this bug will not be fixed for that specific release.