Hi Chengen! Thank you very much for the detailed test plan! It's really good. Apologies for the extended delay in getting back to your changes. There are some points to address in the debdiffs. In order of importance: 1) The debdiff for Lunar and Jammy (equivalent) are for kernel 6.2, but Jammy now has the 6.5 HWE kernel [1] too. I suspect that the users/original reporter that looked for HWE kernel support back at 6.2 would likely switch to 6.5 too, so it would be beneficial and time saving to incorporate the 6.5 patches now, since you already have them in the Mantic debdiff [2]. What do you think? 2) There are 12 patches from crash 8.0.4 [3] in the Mantic debdiff, but these are not yet in Ubuntu (not even in Noble, the development release), which has 8.0.3. I will provide another Merge from Debian to crash, since upstream has now released 8.0.4 and Debian pulled it in. But for the future it's important to keep this in mind, as it may save the time of a review round trip, and more debdiff/build/test work. 3) The version numbers are incorrect for stable releases. Please see [4]. In general, you should increment by 'ubuntu0.1' in stable releases (and 'ubuntu1' in the development release), and if multiple stable releases have the same package version, increment by 'ubuntu0.YY.MM.1' to differentiate among them. i.e., $ rmadison -a source crash ... crash | 8.0.0-1ubuntu1 | jammy | source crash | 8.0.0-1ubuntu1 | lunar | source crash | 8.0.2-1ubuntu1 | mantic | source crash | 8.0.3+ds1-3ubuntu1 | noble | source debdiffs: $ grep -o '.crash (.*)' *.debdiff lp2038249-crash-jammy.debdiff:+crash (8.0.0-1ubuntu2) lp2038249-crash-jammy.debdiff: crash (8.0.0-1ubuntu1) lp2038249-crash-lunar.debdiff:+crash (8.0.0-1ubuntu2) lp2038249-crash-lunar.debdiff: crash (8.0.0-1ubuntu1) lp2038249-crash-mantic.debdiff:+crash (8.0.2-1ubuntu2) lp2038249-crash-mantic.debdiff: crash (8.0.2-1ubuntu1) per [4]: jammy: 8.0.0-1ubuntu1.22.04.1 lunar: 8.0.0-1ubuntu1.23.04.1 mantic: 8.0.2-1ubuntu1.1 4) The changes to 'debian/Makefile.ori' are not listed or explained in the changelog. If this is unintended (i.e., post-build noise in debian/, it should be removed), but if it's intended/required, then it should be listed and slightly documented, please. 5) The itemization in changelog is a bit weird. This is a style/cosmetic suggestion, not a requirement, but in practice, when you have multiple patches, the first item is the description with the LP bug number, and the sub items are the patches; e.g., + * Fix the dump file parsing issue arises from structural changes in Linux + kernel 6.5 (LP: #2038249) + - d/p/lp2038249-arm64-handle-vabits_actual-symbol-missing-case.patch + - d/p/lp2038249-x86_64-Fix-for-move-of-per-cpu-variables-into-struct.patch + - ... more patches 6) The patches are not numbered Again, a style/cosmetic suggestion; but it does help with parsing/organization over time for longer patch series like this one. You can use 'quilt rename' and a shell loop to easily adjust this, of course. Please let me know if you would like some help (I don't think so, but just in case!). 7) Special thanks for paying attention to 'upstream/backport' keyword in the 'Origin:' DEP-3 header! $ grep -ho 'Origin: [^ ]*' *.debdiff | sort | uniq -c 12 Origin: backport, 66 Origin: upstream, ... So, for now, if you have a chance, please feel free to adjust the debdiffs, and I'll work on merging 8.0.4 in Noble, to unblock the needed 12 patches. Thanks again, Mauricio [1] https://launchpad.net/ubuntu/+source/linux-hwe-6.5 [2] $ diff -U0 \ <(filterdiff --remove-timestamps lp2038249-crash-mantic.debdiff -i '*/debian/changelog') \ <(filterdiff --remove-timestamps lp2038249-crash-lunar.debdiff -i '*/debian/changelog') ... @@ -18,7 +29,0 @@ -+ d/p/lp2038249-Fix-kmem-n-option-to-display-memory-blocks-on-Linux-.patch -+ d/p/lp2038249-Fix-failure-of-dev-d-D-options-on-Linux-6.4-and-late.patch -+ d/p/lp2038249-Fix-kmem-v-option-displaying-no-regions-on-Linux-6.3.patch -+ d/p/lp2038249-x86_64-Fix-bt-command-printing-stale-entries-on-Linu.patch -+ d/p/lp2038249-Support-module-memory-layout-change-on-Linux-6.4.patch -+ d/p/lp2038249-Fix-failure-of-gathering-task-table-on-Linux-6.5-rc1.patch -+ d/p/lp2038249-Fix-compilation-error-due-to-new-strlcpy-function-th.patch @@ -26,2 +30,0 @@ -+ d/p/lp2038249-Exclude-zero-entries-from-do_maple_tree-return-value.patch -+ d/p/lp2038249-Fix-irq-a-s-options-on-Linux-6.5-rc1-and-later.patch @@ -32 +35 @@ -+ kernel 6.5 (LP: #2038249) ++ kernel 6.2 (LP: #2038249) ... [3] $ grep 'Origin: ' lp2038249-crash-mantic.debdiff | sed 's,.*/,,' | while read commit; do echo -n "COMMIT $commit is in "; GIT_DIR=~/git/crash/.git git describe --contains $commit; done COMMIT 222176a0a6c14b6a1cdcebb8dda020ccb17b90f8 is in 8.0.3~24 COMMIT 46344aa2f92b07ded52cf9841f8db24dd7fe67d7 is in 8.0.3~21 COMMIT d17d51a92a3a1c1cce1e646c38fe52ca99406cf9 is in 8.0.4~26 COMMIT 55a43bcefa20161c7e56ed0e309e90e941f47efc is in 8.0.4~2 COMMIT 4ee56105881d7bb1da1e668ac5bb47a4e0846676 is in 8.0.4~29 COMMIT 58c1816521c2e6bece3d69256b1866c9df8d93aa is in 8.0.4~42 COMMIT 88580068b7dd96bf679c82bdc05e146968ade10c is in 8.0.4~30 COMMIT 41d4b85ea50efc733df65ec8421a74be10e47987 is in 8.0.3~31 COMMIT f182d08bab202dddf20b742fef6cc2bda0a56d6c is in 8.0.3~43 COMMIT 6d0be1316aa3666895c0a8a0d3c98c235ec03bd4 is in 8.0.4~28 COMMIT 38d35bd1423ccafd0b8be0744155ce59ef3034ff is in 8.0.4~25 COMMIT 489093c2183f4f0365d8957e7275cd88225942ce is in 8.0.3~8 COMMIT 342cf340ed0386880fe2a3115d6bef32eabb511b is in 8.0.4~41 COMMIT 0172e35083b545fa7dd640fa5de0111f8474fc14 is in 8.0.4~5 COMMIT 9efc1f68a44f6fe521e64efe4a3dc36e9ba0bbc1 is in 8.0.3~23 COMMIT 872cad2d63b3a07f65323fe80a7abb29ea276b44 is in 8.0.3~26 COMMIT 120d6e89fc14eb7f1c9a3106305c7066730f36b8 is in 8.0.3~28 COMMIT ac96e17d1de51016ee1a983e68c7e840ff55ab8d is in 8.0.3~27 COMMIT d83df2fb66cd77877d365fda32cd45c531796599 is in 8.0.3~32 COMMIT 7750e61fdb2a083f26156a5338aa2ebe26447f3f is in 8.0.4~31 COMMIT c9a732d0f6abe8c63f19fee5233544633dfd309f is in 8.0.4~11 COMMIT 141e75f3c11cc9342f11418e0bec86877424bef8 is in 8.0.3~46 COMMIT 77d8621876c1c6a3a25b91e464ba588a542485fb is in 8.0.4~36 COMMIT df1f0cba729fa0e0d8a63220769c42cc9033acc1 is in 8.0.3~44 $ grep 'Origin: ' lp2038249-crash-mantic.debdiff | sed 's,.*/,,' | while read commit; do echo -n "COMMIT $commit is in "; GIT_DIR=~/git/crash/.git git describe --contains $commit; done | grep -c 8.0.4 12 [4] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging