| 2021-06-17 21:28:26 |
Benjamin Drung |
bug |
|
|
added bug |
| 2021-06-17 21:28:26 |
Benjamin Drung |
attachment added |
|
0001-media-uvcvideo-Fix-pixel-format-change-for-Elgato-Ca.patch https://bugs.launchpad.net/bugs/1932367/+attachment/5505364/+files/0001-media-uvcvideo-Fix-pixel-format-change-for-Elgato-Ca.patch |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
nominated for series |
|
Ubuntu Bionic |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
nominated for series |
|
Ubuntu Impish |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
bug task added |
|
linux (Ubuntu Impish) |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
nominated for series |
|
Ubuntu Focal |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
bug task added |
|
linux (Ubuntu Focal) |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
nominated for series |
|
Ubuntu Hirsute |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
bug task added |
|
linux (Ubuntu Hirsute) |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
nominated for series |
|
Ubuntu Groovy |
|
| 2021-06-17 21:30:40 |
Benjamin Drung |
bug task added |
|
linux (Ubuntu Groovy) |
|
| 2021-06-18 00:49:24 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2021-06-18 00:49:25 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Terry Rudd |
| 2021-06-23 09:48:26 |
Benjamin Drung |
attachment removed |
0001-media-uvcvideo-Fix-pixel-format-change-for-Elgato-Ca.patch https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1932367/+attachment/5505364/+files/0001-media-uvcvideo-Fix-pixel-format-change-for-Elgato-Ca.patch |
|
|
| 2021-06-23 09:48:49 |
Benjamin Drung |
attachment added |
|
v5-0001-media-uvcvideo-Fix-pixel-format-change-for-Elgato.patch https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1932367/+attachment/5506449/+files/v5-0001-media-uvcvideo-Fix-pixel-format-change-for-Elgato.patch |
|
| 2021-06-23 22:15:45 |
Benjamin Drung |
description |
The Elgato Cam Link 4K HDMI video capture card reports to support three
different pixel formats, where the first format depends on the connected
HDMI device.
```
$ v4l2-ctl -d /dev/video0 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
Type: Video Capture
[0]: 'NV12' (Y/CbCr 4:2:0)
Size: Discrete 3840x2160
Interval: Discrete 0.033s (29.970 fps)
[1]: 'NV12' (Y/CbCr 4:2:0)
Size: Discrete 3840x2160
Interval: Discrete 0.033s (29.970 fps)
[2]: 'YU12' (Planar YUV 4:2:0)
Size: Discrete 3840x2160
Interval: Discrete 0.033s (29.970 fps)
```
Changing the pixel format to anything besides the first pixel format
does not work:
```
$ v4l2-ctl -d /dev/video0 --try-fmt-video pixelformat=YU12
Format Video Capture:
Width/Height : 3840/2160
Pixel Format : 'NV12' (Y/CbCr 4:2:0)
Field : None
Bytes per Line : 3840
Size Image : 12441600
Colorspace : sRGB
Transfer Function : Rec. 709
YCbCr/HSV Encoding: Rec. 709
Quantization : Default (maps to Limited Range)
Flags :
```
User space applications like VLC might show an error message on the
terminal in that case:
```
libv4l2: error set_fmt gave us a different result than try_fmt!
```
Depending on the error handling of the user space applications, they
might display a distorted video, because they use the wrong pixel format
for decoding the stream.
The Elgato Cam Link 4K responds to the USB video probe
VS_PROBE_CONTROL/VS_COMMIT_CONTROL with a malformed data structure: The
second byte contains bFormatIndex (instead of being the second byte of
bmHint). The first byte is always zero. The third byte is always 1.
The firmware bug was reported to Elgato on 2020-12-01 and it was
forwarded by the support team to the developers as feature request.
There is no firmware update available since then. The latest firmware
for Elgato Cam Link 4K as of 2021-03-23 has MCU 20.02.19 and FPGA 67.
Therefore correct the malformed data structure for this device. The
change was successfully tested with VLC, OBS, and Chromium using
different pixel formats (YUYV, NV12, YU12), resolutions (3840x2160,
1920x1080), and frame rates (29.970 and 59.940 fps).
The fix was reviewed and accepted by the subsystem maintainer and will be included upstream: https://git.linuxtv.org/media_stage.git/commit/?id=4c6e0976295add7f0ed94d276c04a3d6f1ea8f83
Attached a backported patch for Ubuntu. I successfully tested it with Linux 5.11 on Ubuntu 21.04 and Linux 5.8 on Ubuntu 20.10. It should work on older kernel versions as well. |
[Impact]
The Elgato Cam Link 4K HDMI video capture card reports to support three
different pixel formats, where the first format depends on the connected
HDMI device.
```
$ v4l2-ctl -d /dev/video0 --list-formats-ext
ioctl: VIDIOC_ENUM_FMT
Type: Video Capture
[0]: 'NV12' (Y/CbCr 4:2:0)
Size: Discrete 3840x2160
Interval: Discrete 0.033s (29.970 fps)
[1]: 'NV12' (Y/CbCr 4:2:0)
Size: Discrete 3840x2160
Interval: Discrete 0.033s (29.970 fps)
[2]: 'YU12' (Planar YUV 4:2:0)
Size: Discrete 3840x2160
Interval: Discrete 0.033s (29.970 fps)
```
Changing the pixel format to anything besides the first pixel format
does not work:
```
$ v4l2-ctl -d /dev/video0 --try-fmt-video pixelformat=YU12
Format Video Capture:
Width/Height : 3840/2160
Pixel Format : 'NV12' (Y/CbCr 4:2:0)
Field : None
Bytes per Line : 3840
Size Image : 12441600
Colorspace : sRGB
Transfer Function : Rec. 709
YCbCr/HSV Encoding: Rec. 709
Quantization : Default (maps to Limited Range)
Flags :
```
User space applications like VLC might show an error message on the
terminal in that case:
```
libv4l2: error set_fmt gave us a different result than try_fmt!
```
Depending on the error handling of the user space applications, they
might display a distorted video, because they use the wrong pixel format
for decoding the stream.
[Fix]
The Elgato Cam Link 4K responds to the USB video probe
VS_PROBE_CONTROL/VS_COMMIT_CONTROL with a malformed data structure: The
second byte contains bFormatIndex (instead of being the second byte of
bmHint). The first byte is always zero. The third byte is always 1.
The firmware bug was reported to Elgato on 2020-12-01 and it was
forwarded by the support team to the developers as feature request.
There is no firmware update available since then. The latest firmware
for Elgato Cam Link 4K as of 2021-03-23 has MCU 20.02.19 and FPGA 67.
Therefore correct the malformed data structure for this device. The
change was successfully tested with VLC, OBS, and Chromium using
different pixel formats (YUYV, NV12, YU12), resolutions (3840x2160,
1920x1080), and frame rates (29.970 and 59.940 fps).
[Test Case]
Connect an input device to the Cam Link 4K and try all three pixel formats with VLC:
vlc v4l2:///dev/video0 --v4l2-chroma=NV12
vlc v4l2:///dev/video0 --v4l2-chroma=YU12
[Other Info]
The fix was reviewed and accepted by the subsystem maintainer and will be included upstream: https://git.linuxtv.org/media_stage.git/commit/?id=4c6e0976295add7f0ed94d276c04a3d6f1ea8f83
Attached a backported patch for Ubuntu. I successfully tested it with Linux 5.11 on Ubuntu 21.04 and Linux 5.8 on Ubuntu 20.10. It should work on older kernel versions as well. |
|
| 2021-06-25 08:29:19 |
Stefan Bader |
linux (Ubuntu Bionic): importance |
Undecided |
Medium |
|
| 2021-06-25 08:29:19 |
Stefan Bader |
linux (Ubuntu Bionic): status |
New |
Triaged |
|
| 2021-06-25 08:29:32 |
Stefan Bader |
linux (Ubuntu Focal): importance |
Undecided |
Medium |
|
| 2021-06-25 08:29:32 |
Stefan Bader |
linux (Ubuntu Focal): status |
New |
Triaged |
|
| 2021-06-25 08:29:45 |
Stefan Bader |
linux (Ubuntu Groovy): importance |
Undecided |
Medium |
|
| 2021-06-25 08:29:45 |
Stefan Bader |
linux (Ubuntu Groovy): status |
New |
Triaged |
|
| 2021-06-25 08:29:57 |
Stefan Bader |
linux (Ubuntu Hirsute): importance |
Undecided |
Medium |
|
| 2021-06-25 08:29:57 |
Stefan Bader |
linux (Ubuntu Hirsute): status |
New |
Triaged |
|
| 2021-06-25 08:30:27 |
Stefan Bader |
linux (Ubuntu Impish): importance |
Undecided |
Medium |
|
| 2021-06-25 08:30:27 |
Stefan Bader |
linux (Ubuntu Impish): status |
New |
Triaged |
|
| 2021-06-29 00:16:53 |
Kelsey Steele |
linux (Ubuntu Bionic): status |
Triaged |
Fix Committed |
|
| 2021-06-29 00:16:56 |
Kelsey Steele |
linux (Ubuntu Focal): status |
Triaged |
Fix Committed |
|
| 2021-06-29 00:16:58 |
Kelsey Steele |
linux (Ubuntu Groovy): status |
Triaged |
Fix Committed |
|
| 2021-06-29 00:17:01 |
Kelsey Steele |
linux (Ubuntu Hirsute): status |
Triaged |
Fix Committed |
|
| 2021-07-04 17:42:53 |
Ubuntu Kernel Bot |
tags |
patch |
patch verification-needed-focal |
|
| 2021-07-21 14:57:48 |
Ubuntu Kernel Bot |
tags |
patch verification-needed-focal |
patch verification-needed-focal verification-needed-hirsute |
|
| 2021-07-21 15:03:27 |
Ubuntu Kernel Bot |
tags |
patch verification-needed-focal verification-needed-hirsute |
patch verification-needed-bionic verification-needed-focal verification-needed-hirsute |
|
| 2021-07-23 09:21:00 |
Benjamin Drung |
tags |
patch verification-needed-bionic verification-needed-focal verification-needed-hirsute |
patch verification-done-hirsute verification-needed-bionic verification-needed-focal |
|
| 2021-07-30 17:43:19 |
Benjamin Drung |
tags |
patch verification-done-hirsute verification-needed-bionic verification-needed-focal |
patch verification-done-focal verification-done-hirsute verification-needed-bionic |
|
| 2021-08-12 20:35:44 |
Launchpad Janitor |
linux (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-08-16 16:20:07 |
Launchpad Janitor |
linux (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
| 2021-08-16 19:46:29 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2021-08-16 19:46:29 |
Launchpad Janitor |
cve linked |
|
2019-19036 |
|
| 2021-08-18 23:09:18 |
Launchpad Janitor |
linux (Ubuntu Impish): status |
Triaged |
Fix Released |
|
