Fix Ethernet not working by hotplug - RTL8106E

[koba]

[Impact]
After hot-plug the Ethernet cable, the status of Ethernet is always down.

[Fix]
Because ASPM is enabled on RTL8106E, the link change interrupt can't be fired immediately.
Must wait a long time to get the link change interrupt.
After discuss with maintainer, he give some suggestions
1. use PHY_POLL.
2. he send a workaround(Ref. [1]) to disable ASPM on RTL8106E.

For 2, because don't know the details about operated registers in rtl_hw_aspm_clkreq_enable, it have higher risk on power usage during suspend.

For 1, Use PHY_POLL have a lower risk because don't change any register operations and use polling method to query link change status.
SRU the patches for 1 first.

Currently keep discussing with Realtek but don't figure out yet.
Will re-SRU the official solution once Realtek resolve the issue.

Ref [1], https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=1ee8856de82faec9bc8bd0f2308a7f27e30ba207

[Test]
Verified on machines with Realtek Ethernet device, the Ethernet works well after hotplug 30 times.

[Regression Potential]
Medium, use polling methond may have higher cpu usage.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[koba (kobako)]

Verified on 5.10-oem-1035, try 10 times, phy link can be up.
here's the one dmesg of them.
Tried unplug cable, wait 2 mins and let 8106e go to sleep, then plug cable.
the phy link still could be up.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.10 - 5.10.0-1038.40

---------------
linux-oem-5.10 (5.10.0-1038.40) focal; urgency=medium

  * CVE-2021-33909
    - SAUCE: seq_file: Disallow extremely large seq buffer allocations

linux-oem-5.10 (5.10.0-1037.38) focal; urgency=medium

  * focal/linux-oem-5.10: 5.10.0-1037.38 -proposed tracker (LP: #1935808)

  * Mute/mic LEDs no function on some HP platfroms (LP: #1934878)
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8

linux-oem-5.10 (5.10.0-1036.37) focal; urgency=medium

  * focal/linux-oem-5.10: 5.10.0-1036.37 -proposed tracker (LP: #1934760)

  * Packaging resync (LP: #1786013)
    - [Packaging] resync getabis
    - [Packaging] update helper scripts

  * mute/micmute LEDs no function on HP EliteBook 830 G8 Notebook PC
    (LP: #1934239)
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 830 G8 Notebook PC

  * Add l2tp.sh in net from ubuntu_kernel_selftests back (LP: #1934293)
    - Revert "UBUNTU: SAUCE: selftests/net -- disable l2tp.sh test"

  * devlink_port_split in net from ubuntu_kernel_selftests linux ADT test
    failure with linux/5.11.0-18.19 ( list index out of range) (LP: #1928889)
    - selftests: net: devlink_port_split.py: skip the test if no devlink device

  * icmp_redirect.sh in net from ubuntu_kernel_selftests failed on F-OEM-5.6 /
    F-OEM-5.10 / F-OEM-5.13 / F / G / H (LP: #1880645)
    - selftests: icmp_redirect: support expected failures

linux-oem-5.10 (5.10.0-1035.36) focal; urgency=medium

  * focal/linux-oem-5.10: 5.10.0-1035.36 -proposed tracker (LP: #1932479)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * XPS 9510 (TGL) Screen Brightness could not be changed (LP: #1933566)
    - SAUCE: drm/i915: Force DPCD backlight mode for Dell XPS 9510(TGL)

  * mute/micmute LEDs no function on HP EliteBook x360 830 G8 (LP: #1933508)
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook x360 830 G8

  * Focal update: v5.10.46 upstream stable release (LP: #1933367)
    - dmaengine: idxd: add missing dsa driver unregister
    - dmaengine: fsl-dpaa2-qdma: Fix error return code in two functions
    - dmaengine: xilinx: dpdma: initialize registers before request_irq
    - dmaengine: ALTERA_MSGDMA depends on HAS_IOMEM
    - dmaengine: QCOM_HIDMA_MGMT depends on HAS_IOMEM
    - dmaengine: SF_PDMA depends on HAS_IOMEM
    - dmaengine: stedma40: add missing iounmap() on error in d40_probe()
    - afs: Fix an IS_ERR() vs NULL check
    - mm/memory-failure: make sure wait for page writeback in memory_failure
    - kvm: LAPIC: Restore guard to prevent illegal APIC register access
    - fanotify: fix copy_event_to_user() fid error clean up
    - batman-adv: Avoid WARN_ON timing related checks
    - mac80211: fix skb length check in ieee80211_scan_rx()
    - mlxsw: reg: Spectrum-3: Enforce lowest max-shaper burst size of 11
    - mlxsw: core: Set thermal zone polling delay argument to real value at init
    - libbpf: Fixes incorrect rx_ring_setup_done
    - net: ipv4: fix memory...

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.13 - 5.13.0-1009.10

---------------
linux-oem-5.13 (5.13.0-1009.10) focal; urgency=medium

  * CVE-2021-33909
    - SAUCE: seq_file: Disallow extremely large seq buffer allocations

linux-oem-5.13 (5.13.0-1007.7) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1007.7 -proposed tracker (LP: #1934979)

  * intel_pmc_core driver is not probed on ADL (LP: #1934660)
    - SAUCE: platform/x86: intel_pmc_core: Add Alderlake support to pmc_core
      driver
    - SAUCE: platform/x86: intel_pmc_core: Add Latency Tolerance Reporting (LTR)
      support to Alder Lake
    - SAUCE: platform/x86: intel_pmc_core: Add Alder Lake low power mode support
      for pmc_core
    - SAUCE: platform/x86: intel_pmc_core: Add GBE Package C10 fix for Alder Lake
      PCH

linux-oem-5.13 (5.13.0-1006.6) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1006.6 -proposed tracker (LP: #1934490)

  * Replace AMD nvme workaround from oem-5.10 with upstream version
    (LP: #1930719)
    - ACPI: Check StorageD3Enable _DSD property in ACPI code
    - ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint

  * Add Thunderbolt support for Intel Alder Lake (LP: #1934240)
    - thunderbolt: Add support for Intel Alder Lake

  * Fix Ethernet not working by hotplug - RTL8106E (LP: #1930645)
    - SAUCE: r8169: Use PHY_POLL when RTL8106E enable ASPM

  * Realtek USB hubs in Dell WD19SC/DC/TB fail to work after exiting s2idle
    (LP: #1928242)
    - USB: Verify the port status when timeout happens during port suspend
    - Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

  * USB Type-C hotplug event not handled properly in TGL-H system during s2idle
    (LP: #1931072)
    - drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

  * Miscellaneous Ubuntu changes
    - [Config] Sync annotations and config with master

  [ Ubuntu: 5.13.0-11.11 ]

  * impish/linux: 5.13.0-11.11 -proposed tracker (LP: #1933854)
  * Packaging resync (LP: #1786013)
    - [Packaging] update variants
  * Support builtin revoked certificates (LP: #1932029)
    - [Packaging] build canonical-revoked-certs.pem from branch/arch certs
    - [Packaging] Revoke 2012 UEFI signing certificate as built-in
    - [Config] Configure CONFIG_SYSTEM_REVOCATION_KEYS with revoked keys
  * Miscellaneous Ubuntu changes
    - [Packaging] Change source package name to linux
  * Miscellaneous upstream changes
    - mm/page_alloc: Correct return value of populated elements if bulk array is
      populated

  [ Ubuntu: 5.13.0-10.10 ]

  * impish/linux-unstable: 5.13.0-10.10 -proposed tracker (LP: #1933795)
  * Pixel format change broken for Elgato Cam Link 4K (LP: #1932367)
    - media: uvcvideo: Fix pixel format change for Elgato Cam Link 4K
  * initramfs-tools & kernel: use zstd as the default compression method
    (LP: #1931725)
    - s390/decompressor: correct BOOT_HEAP_SIZE condition
    - s390/boot: add zstd support
    - [Packaging] use ZSTD to compress s390 kernels
  * Miscellaneous Ubuntu changes
    - SAUCE: selftests: tls: fix chacha+bidir tests
    - SAUCE: selftests: icmp_redirect: support expected failures
    - [Config] update ...

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-hirsute' to 'verification-done-hirsute'. If the problem still exists, change the tag 'verification-needed-hirsute' to 'verification-failed-hirsute'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[koba (kobako)]

verified on 5.11.0-33-generic

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.11.0-34.36

---------------
linux (5.11.0-34.36) hirsute; urgency=medium

  * hirsute/linux: 5.11.0-34.36 -proposed tracker (LP: #1941766)

  * Server boot failure after adding checks for ACPI IRQ override (LP: #1941657)
    - Revert "ACPI: resources: Add checks for ACPI IRQ override"

linux (5.11.0-33.35) hirsute; urgency=medium

  * hirsute/linux: 5.11.0-33.35 -proposed tracker (LP: #1940101)

  * libvirtd fails to create VM (LP: #1940107)
    - sched: Stop PF_NO_SETAFFINITY from being inherited by various init system
      threads

linux (5.11.0-32.34) hirsute; urgency=medium

  * hirsute/linux: 5.11.0-32.34 -proposed tracker (LP: #1939769)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2021.08.16)

  * CVE-2021-3656
    - SAUCE: KVM: nSVM: always intercept VMLOAD/VMSAVE when nested

  * CVE-2021-3653
    - SAUCE: KVM: nSVM: avoid picking up unsupported bits from L2 in int_ctl

  * [regression] USB device is not detected during boot (LP: #1939638)
    - SAUCE: Revert "usb: core: reduce power-on-good delay time of root hub"

  * Support builtin revoked certificates (LP: #1932029)
    - [Packaging] build canonical-revoked-certs.pem from branch/arch certs
    - [Packaging] Revoke 2012 UEFI signing certificate as built-in
    - [Config] Configure CONFIG_SYSTEM_REVOCATION_KEYS with revoked keys

  * Support importing mokx keys into revocation list from the mok table
    (LP: #1928679)
    - SAUCE: integrity: add informational messages when revoking certs

  * Support importing mokx keys into revocation list from the mok table
    (LP: #1928679) // CVE-2020-26541 when certificates are revoked via
    MokListXRT.
    - SAUCE: integrity: Load mokx certs from the EFI MOK config table

  * Include product_sku info to modalias (LP: #1938143)
    - firmware/dmi: Include product_sku info to modalias

  * Fix Ethernet not working by hotplug - RTL8106E (LP: #1930645)
    - net: phy: rename PHY_IGNORE_INTERRUPT to PHY_MAC_INTERRUPT
    - SAUCE: r8169: Use PHY_POLL when RTL8106E enable ASPM

  * [SRU][H/OEM-5.10/OEM-5.13/U] Fix system hang after unplug tbt dock
    (LP: #1938689)
    - SAUCE: igc: fix page fault when thunderbolt is unplugged

  * [Regression] Audio card [8086:9d71] not detected after upgrade from linux
    5.4 to 5.8 (LP: #1915117)
    - [Config] set CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC to y

  * Backlight (screen brightness) on Lenovo P14s AMD Gen2 inop (LP: #1934557)
    - drm/amdgpu/display: only enable aux backlight control for OLED panels

  * Touchpad not working with ASUS TUF F15 (LP: #1937056)
    - pinctrl: tigerlake: Fix GPIO mapping for newer version of software

  * dev_forward_skb: do not scrub skb mark within the same name space
    (LP: #1935040)
    - dev_forward_skb: do not scrub skb mark within the same name space

  * Fix display output on HP hybrid GFX laptops (LP: #1936296)
    - drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

  * [SRU][OEM-5.10/H] UBUNTU: SAUCE: Fix backlight control on Samsung 16727
    panel (LP: #1930527)
    - SAUCE: drm/i915: Force DPCD backlight mode for Samsung 16727 pa...

[Timo Aaltonen (tjaalton)]

fixed since 9c40186488145b57f