rustc 1.50 and cargo 0.51 will be required by a future version of firefox

[Olivier Tilloy]

This is not yet a hard requirement, but builders in the Mozilla infrastructure have already been upgraded to rustc 1.50¹, so we should start preparing this update for hirsute and all supported releases (xenial, bionic, focal, and groovy).

This will also benefit other projects that are packaged in Ubuntu and are bumping their build dependency on rustc, see e.g. https://gitlab.gnome.org/GNOME/librsvg/-/commit/513a575a839342f46bca713ac4eac37fbab9a7b7.

¹ https://bugzilla.mozilla.org/show_bug.cgi?id=1692352

[Michael Hudson-Doyle (mwhudson)]

Do you have any idea when this will become a requirement? Just trying to asses priorities.

[Olivier Tilloy (osomon)]

I don't know for sure, but looking at https://hg.mozilla.org/mozilla-central/log/9cf59af57183/taskcluster/ci/toolchain/rust.yml, in the past year there have been as little as 12 days (for rustc 1.39) between the upstream builders were upgraded and the version became a hard requirement. In other instances (1.47), the lag was longer (1.5 months).

I wouldn't bet on it, but I think it's safe to say that we have somewhere between a couple of weeks and a month before this becomes urgent.

[Michael Hudson-Doyle (mwhudson)]

So for a status update, rustc is updated to 1.49 in hirsute and I've just uploaded it to the PPA for older releases. So the update to 1.50 and the cargo update to go: unfortunately, Debian has not updated to the versions we need yet so I'll have to do the upstream update myself, which is a bit tedious (especially cargo). We'll get there!

[Olivier Tilloy (osomon)]

Thanks Michael!

[Launchpad Janitor (janitor)]

This bug was fixed in the package rustc - 1.50.0+dfsg1+llvm-0ubuntu1

---------------
rustc (1.50.0+dfsg1+llvm-0ubuntu1) hirsute; urgency=medium

  * New upstream release. (LP: #1915722)
  * Update patches.
  * Update d/copyright.

 -- Michael Hudson-Doyle <email address hidden> Thu, 04 Mar 2021 10:17:58 +1300

[Rico Tzschichholz (ricotz)]

rustc 1.50 introduces a regression which make `gimli` crate fail to build on s390x

https://launchpadlibrarian.net/526288771/buildlog_ubuntu-hirsute-s390x.firefox_87.0~b6+build1-0ubuntu0.21.04.1_BUILDING.txt.gz

https://launchpadlibrarian.net/526459184/buildlog_ubuntu-hirsute-s390x.firefox-trunk_88.0~a1~hg20210305r569767-0ubuntu0.21.04.1~umd2_BUILDING.txt.gz

Upstream report with a possible fix, https://github.com/rust-lang/rust/issues/80810

[Launchpad Janitor (janitor)]

This bug was fixed in the package cargo - 0.51.0-0ubuntu1

---------------
cargo (0.51.0-0ubuntu1) hirsute; urgency=medium

  * Merge from Debian unstable. Remaining changes:
    - Don't use the bootstrap.py script for bootstrapping as it no longer
      works.
      - remove debian/bootstrap.py
      - update debian/make_orig_multi.sh
  * New upstream release. (LP: #1915722)
  * Dropped changes:
    - Embed libgit2 1.0.0 which is not yet in Debian or Ubuntu. (Hirsute
      has a new enough libgit2)
    - d/patches/0001-relax-deprecated-diagnostic-message-check.patch,
      d/patches/u-8713.patch: included in upstream release.
  * d/patches/skip-filter_platform-non-amd64.patch: skip a test that fails on
    non amd64 platforms, see https://github.com/rust-lang/cargo/issues/9238.

 -- Michael Hudson-Doyle <email address hidden> Mon, 08 Mar 2021 09:10:26 +1300

[Michael Hudson-Doyle (mwhudson)]

So, just to be clear I should add https://src.fedoraproject.org/rpms/rust/blob/8148cbf67890e233c779daeddd4a4dfd5557fdf2/f/0001-Revert-Auto-merge-of-79547.patch to the package and upload?

I'm not sure if it's worth the effort of backporting this to the older releases at this point, but could be talked around on that too.

[Olivier Tilloy (osomon)]

Yes please.
My understanding is that without this patch all firefox builds fail on s390x, so that's a regression we want to avoid (granted, s390x is not an officially supported desktop platform, but since we have builds we might as well want to keep them succeeding).

[Michael Hudson-Doyle (mwhudson)]

Unfortunately it's going to be a little complicated because the rustc in hirsute is too broken to build a fixed one :( We'll sort something out but it's probably going to involve archive admin support...

[Dimitri John Ledkov (xnox)]

you can republish last working on in a ppa, and then have strict build-depends on version guarded one in the next ppa (with build-dep on the first ppa) to rebuild fixed one with last fixed toolchain..... if there is one.

[Dimitri John Ledkov (xnox)]

otherwise cross-compile bootstrap is an option.

[Olivier Tilloy (osomon)]

Michael, now that the situation is sorted out in hirsute, can we get the rustc and cargo updates in other supported releases?

[Dimitri John Ledkov (xnox)]

situation in hirsute is not sorted yet.
we had to revert & remove 1.50 from hirsute, and currently 1.49 is published there once again.

[Olivier Tilloy (osomon)]

Right, I might have jumped the gun. But I see that 1.50 is building in hirsute-proposed, and almost done. Is it expected to proceed?

[Olivier Tilloy (osomon)]

Michael, I see that the rustc update is mostly ready in the rust-updates PPA (except for a bootstrap issue for groovy/s390x), is the cargo update on your radar?

[Michael Hudson-Doyle (mwhudson)]

Oh oops forgot about that. Uploaded now.

How serious do you regard the s390x/groovy situation? I'm sure it's fixable but it would be tedious in the extreme I think...

[Olivier Tilloy (osomon)]

Thanks Michael!

As far as I know the only drivers for rustc/cargo updates in the stable releases are Mozilla products (firefox and thunderbird), s390x is not tested nor officially supported for the desktop components, and groovy will be EOL in three months' time. Given all this, I don't think it's worth investing more time in it.

[Michael Hudson-Doyle (mwhudson)]

That's what I hoped you would say :-)

[Brian Murray (brian-murray)]

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release

[Launchpad Janitor (janitor)]

This bug was fixed in the package cargo - 0.52.0-0ubuntu1~18.04.1

---------------
cargo (0.52.0-0ubuntu1~18.04.1) bionic; urgency=medium

  * Backport to Bionic. (LP: #1932145)
  * Embed libgit2 at the revision which is embedded by the libgit2-sys
    crate, version 0.12.21+1.1.0 (which is not exactly libgit2 1.1.0,
    confusingly)
    - add debian/libgit2
    - add debian/patches/use-system-libhttp-parser.patch
    - update debian/control
    - update debian/copyright
    - update debiab/patches/series
    - update debian/README.source
    - update debian/rules
  * Relax debhelper requirement.

 -- Michael Hudson-Doyle <email address hidden> Thu, 22 Jul 2021 23:56:56 +1200

[Launchpad Janitor (janitor)]

This bug was fixed in the package rustc - 1.51.0+dfsg1+llvm-1~exp3ubuntu1~18.04.1

---------------
rustc (1.51.0+dfsg1+llvm-1~exp3ubuntu1~18.04.1) bionic; urgency=medium

  * Backport to Bionic. (LP: #1932145)
  * Relax debhelper requirement.
  * Reduce parallelism on ppc64el too.

 -- Michael Hudson-Doyle <email address hidden> Thu, 22 Jul 2021 12:31:12 +1200

[Launchpad Janitor (janitor)]

This bug was fixed in the package cargo - 0.52.0-0ubuntu1~20.04.1

---------------
cargo (0.52.0-0ubuntu1~20.04.1) focal; urgency=medium

  * Backport to Focal. (LP: #1932145)
  * Embed libgit2 at the revision which is embedded by the libgit2-sys
    crate, version 0.12.21+1.1.0 (which is not exactly libgit2 1.1.0,
    confusingly)
    - add debian/libgit2
    - add debian/patches/use-system-libhttp-parser.patch
    - update debian/control
    - update debian/copyright
    - update debiab/patches/series
    - update debian/README.source
    - update debian/rules

 -- Michael Hudson-Doyle <email address hidden> Fri, 23 Jul 2021 10:58:32 +1200

[Launchpad Janitor (janitor)]

This bug was fixed in the package rustc - 1.51.0+dfsg1+llvm-1~exp3ubuntu1~20.04.2

---------------
rustc (1.51.0+dfsg1+llvm-1~exp3ubuntu1~20.04.2) focal; urgency=medium

  * Reduce parallelism on ppc64el too.

 -- Michael Hudson-Doyle <email address hidden> Thu, 22 Jul 2021 21:19:16 +1200