net/mlx5e: Add missing capability check for uplink follow
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu on IBM z Systems |
Fix Released
|
High
|
Skipper Bug Screeners | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Frank Heimes | ||
Focal |
Fix Released
|
High
|
Canonical Kernel Team | ||
Groovy |
Fix Released
|
High
|
Canonical Kernel Team | ||
Hirsute |
Fix Released
|
Undecided
|
Frank Heimes |
Bug Description
SRU Justification:
==================
[Impact]
* Since older firmware may not support the uplink state setting, this can lead to problems.
* Now expose firmware indication that it supports setting eswitch uplink state to follow the physical link.
* If a kernel without the backport is used on an adapter which does not have the latest adapter firmware, the adapter silently drops outgoing traffic.
* This is a regression which was introduced with kernel 5.4.0-48.
[Fix]
* upstream fix (as in 5.11):
9c9be85f6b59d
* backport for focal: https:/
* backport for groovy: https:/
[Test Case]
* Two IBM Z or LinuxONE systems, installed with Ubuntu Server 20.04 or 20.10 on LPAR, are needed.
* Each with RoCE Express 2.x adapters (Mellanox ConnectX4/5) attached and firmware 16.29.1006 or earlier.
* Assign an IP address to the adapters on both systems and try to ping one node from the other.
* The ping will just fail with the stock Ubuntu kernels (not having the patch), but will succeed with kernels that incl. the patches (like the test builds from the PPA mentioned below).
* Due to the lack of hardware this needs to be verified by IBM.
[Regression Potential]
* Undesired / erroneous behavior in case the modified if condition is assembled in a wrong way.
* Again wrong behavior in case the modification of the capability bits in mlx5_ifc_
* All modification are limited to the mlx5 driver only.
* The changes are relatively limited with effectively two lines removed and 4 added (three of them adjustments of the capability bits only).
* The modifications were done and tested by IBM and reviewed by Mellanox (see LP comments), based on a PPA test build.
[Other]
* The above patch/commit was upstream accepted with kernel 5.11.
* Hence the patch is not needed for hirsute, just needs to be SRUed for groovy and focal.
* The commit couldn't be cleanly cherry-picked, mainly due to changed context, hence the backport(s).
__________
Expose firmware indication that it supports setting eswitch uplink state
to follow (follow the physical link). Condition setting the eswitch
uplink admin-state with this capability bit. Older FW may not support
the uplink state setting.
Available fix with kernel 5.11.
https:/
Now required for Ubuntu 20.04 via backport patch.
CVE References
tags: | added: architecture-s39064 bugnameltc-192185 severity-high targetmilestone-inin2004 |
Changed in ubuntu: | |
assignee: | nobody → Skipper Bug Screeners (skipper-screen-team) |
affects: | ubuntu → linux (Ubuntu) |
Changed in ubuntu-z-systems: | |
assignee: | nobody → Skipper Bug Screeners (skipper-screen-team) |
Changed in linux (Ubuntu): | |
assignee: | Skipper Bug Screeners (skipper-screen-team) → Frank Heimes (fheimes) |
Changed in ubuntu-z-systems: | |
importance: | Undecided → High |
status: | New → Triaged |
description: | updated |
Changed in linux (Ubuntu Groovy): | |
status: | New → Triaged |
description: | updated |
summary: |
- net/mlx5e: Add missing capability check for uplink follow for Ubuntu - 20.04 + net/mlx5e: Add missing capability check for uplink follow |
Changed in linux (Ubuntu Groovy): | |
status: | Triaged → In Progress |
Changed in linux (Ubuntu Focal): | |
status: | Triaged → In Progress |
Changed in ubuntu-z-systems: | |
status: | Triaged → In Progress |
Changed in linux (Ubuntu Focal): | |
importance: | Undecided → High |
Changed in linux (Ubuntu Groovy): | |
importance: | Undecided → High |
assignee: | nobody → Canonical Kernel Team (canonical-kernel-team) |
Changed in linux (Ubuntu Focal): | |
assignee: | nobody → Canonical Kernel Team (canonical-kernel-team) |
Changed in linux (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Groovy): | |
status: | In Progress → Fix Committed |
tags: | added: sts |
Changed in ubuntu-z-systems: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-z-systems: | |
status: | Fix Committed → Fix Released |
------- Comment From <email address hidden> 2021-03-24 07:23 EDT-------
Expose firmware indication that it supports setting eswitch uplink state
to follow (follow the physical link). Condition setting the eswitch
uplink admin-state with this capability bit. Older FW may not support
the uplink state setting.
Available fix with kernel 5.11. /github. com/torvalds/ linux/commit/ 9c9be85f6b59d80 efe4705109c0396 df18d4e11d
https:/
Now required for Ubuntu 20.04 via backport patch.