[Ubuntu 21.04 FEAT] mpt3sas: Request to include the patch set which supports topology where zoning is enabled in expander

[Sreekanth Reddy]

Request to include patch set "PATCH 00/14] mpt3sas: Add support for multi-port path topology" which will support the topologies where zoning is enabled in the expander as shown below,

        Zone 1 Zone 2
 |-----------------| |----------------|
 | HD1 ..... HD25 | | HD26 ......HD50|
 | |==================================| |
 | | | | | |
 | | Expander | |
 | |==================================| |
 | | | | | |
 |-----------|-----| |----|-----------|
           x8| |x8
      _______|______________|_______
      | HBA |
      |____________________________|

Current driver doesn't support this type of topology and will add only one zoned drives to the OS. So to support these types of topology we need below patch set in the driver.
https://marc.info/?l=linux-scsi&m=160226366707807&w=2

So, requesting you include this patch for next upcoming Ubuntu kernel release.

Currently we have posted this patch set to upstream community and they yet to review this patch set. Meanwhile If I get the base kernel source code for next upcoming Ubuntu kernel then I can prepare the patches over this base kernel source and share it in this BZ.

Thanks,
Sreekanth

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1899802

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Sreekanth Reddy (srreddy)]

This is feature request not a bug, So I haven't attached any logs in BZ.

[Sreekanth Reddy (srreddy)]

Hi,

Any update here?

Thanks,
Sreekanth

[Michael Reed (mreed8855)]

Do you have commit ID's for this patch set?

[Sreekanth Reddy (srreddy)]

Still we don't have commit ID's, waiting for Upstream community to review and accept this patch set.

Just posted a newer version (v1) path set with a fix that fixes the compilation warning reported by the kernel robot for patch 8.

https://marc.info/?l=linux-scsi&m=160380410106370&w=2

Thanks,
Sreekanth

[Jeff Lane  (bladernr)]

Sreekanth, what's the target upstream kernel version for this feature? Just want to get a feel for the timing. As you've already submitted these upstream, getting them into 21.04 should be no problem at all.

Also, do you expect (or desire) us to pull these back into 5.4 at some point, or are you fine with them landing in the current mainline kernel and find their way into Ubuntu 20.04 via the HWE kernel later next year?

[Sreekanth Reddy (srreddy)]

Jeff,

As we have already posted the patch set to upstream, so the target upstream kernel version is the next upcoming kernel which is 5.11.

Yes we want you to back port this patch set into 5.4 kernel.

Thanks,
Sreekanth

[Sreekanth Reddy (srreddy)]

HI Jeff,

Patch set got accepted by the upstream and this patch set is added in below 5.11/stating branch,
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/drivers/scsi/mpt3sas?h=staging

Here are the patch set commit IDs,

2030745877 scsi: mpt3sas: Bump driver version to 35.101.00.00
324c122fc0 scsi: mpt3sas: Add module parameter multipath_on_hba
ffa381d637 scsi: mpt3sas: Handle vSES vphy object during HBA reset
34b0a78532 scsi: mpt3sas: Add bypass_dirty_port_flag parameter
ccc59923ba scsi: mpt3sas: Handling HBA vSES device
9d0348a9d8 scsi: mpt3sas: Set valid PhysicalPort in SMPPassThrough
a5e99fda01 scsi: mpt3sas: Update hba_port objects after host reset
6df6be9168 scsi: mpt3sas: Get sas_device objects using device's rphy
c71ccf93c0 scsi: mpt3sas: Rename transport_del_phy_from_an_existing_port()
7d310f2410 scsi: mpt3sas: Get device objects using sas_address & portID
e2f0cdf752 scsi: mpt3sas: Update hba_port's sas_address & phy_mask
78ca700342 scsi: mpt3sas: Rearrange _scsih_mark_responding_sas_device()
e238e71b6c scsi: mpt3sas: Allocate memory for hba_port objects
b22a0fac8c scsi: mpt3sas: Define hba_port structure

Thanks,
Sreekanth

[Michael Reed (mreed8855)]

I have included a test kernel for both focal and groovy.

Focal
https://people.canonical.com/~mreed/dell/mpt3sas/bug_1899802/focal/

Groovy
https://people.canonical.com/~mreed/dell/mpt3sas/bug_1899802/groovy/

[Sreekanth Reddy (srreddy)]

As I have submitted the BZ, so I am updating test result status received from DELL team for the above test kernels.

Both focal & groovy test kernels got tested on Globemaster platform & power edge platforms and results are positive and no issue is found during the testing.

Below are the main test cases that got executed during the testing and results of these test cases are positive,

1. All drives on Dual topology Enumerated in OS
2. LED Blink/Unblink from Perccli
3. IO stress for 5Hrs
4. Controller reset and drive enumeration
5. Reboot loop
6. IO Stress over the Weekend

@DELL Team - If I have missed any thing then please update the missed info here.

Thanks,
Sreekanth

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-groovy' to 'verification-done-groovy'. If the problem still exists, change the tag 'verification-needed-groovy' to 'verification-failed-groovy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Jerry Clement (jerry-clement)]

Testing completed by DellEMC

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.8.0-34.37

---------------
linux (5.8.0-34.37) groovy; urgency=medium

  * groovy/linux: 5.8.0-34.37 -proposed tracker (LP: #1907576)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * [Ubuntu 21.04 FEAT] mpt3sas: Request to include the patch set which supports
    topology where zoning is enabled in expander (LP: #1899802)
    - scsi: mpt3sas: Define hba_port structure
    - scsi: mpt3sas: Allocate memory for hba_port objects
    - scsi: mpt3sas: Rearrange _scsih_mark_responding_sas_device()
    - scsi: mpt3sas: Update hba_port's sas_address & phy_mask
    - scsi: mpt3sas: Get device objects using sas_address & portID
    - scsi: mpt3sas: Rename transport_del_phy_from_an_existing_port()
    - scsi: mpt3sas: Get sas_device objects using device's rphy
    - scsi: mpt3sas: Update hba_port objects after host reset
    - scsi: mpt3sas: Set valid PhysicalPort in SMPPassThrough
    - scsi: mpt3sas: Handling HBA vSES device
    - scsi: mpt3sas: Add bypass_dirty_port_flag parameter
    - scsi: mpt3sas: Handle vSES vphy object during HBA reset
    - scsi: mpt3sas: Add module parameter multipath_on_hba
    - scsi: mpt3sas: Bump driver version to 35.101.00.00

  * CVE-2020-12912
    - hwmon: (amd_energy) modify the visibility of the counters

  * Intel Tiger Lake IDs supplement (LP: #1904521)
    - mtd: spi-nor: intel-spi: Add support for Intel Tiger Lake-H SPI serial flash
    - pinctrl: tigerlake: Add support for Tiger Lake-H

  * [i915] Noise-like lines of graphics corruption when moving windows in Xorg
    sessions (LP: #1896091)
    - Revert "UBUNTU: SAUCE: drm/i915: Synchronize active and retire callbacks"

  * Fix no headset sound after S3 on Intel HDA (LP: #1904595)
    - ALSA: hda: Refactor codec PM to use direct-complete optimization
    - ALSA: hda: Separate runtime and system suspend
    - ALSA: hda: Reinstate runtime_allow() for all hda controllers

  * Ask 8821C Bluetooth controller to drop old firmware (LP: #1904221)
    - Bluetooth: btrtl: Ask 8821C to drop old firmware
    - Bluetooth: btrtl: fix incorrect skb allocation failure check

  * Use ACPI S5 for reboot (LP: #1904225)
    - PM: ACPI: reboot: Use S5 for reboot

  * Groovy update: v5.8.18 upstream stable release (LP: #1904941)
    - netfilter: nftables_offload: KASAN slab-out-of-bounds Read in
      nft_flow_rule_create
    - io_uring: don't run task work on an exiting task
    - io_uring: allow timeout/poll/files killing to take task into account
    - io_uring: move dropping of files into separate helper
    - io_uring: stash ctx task reference for SQPOLL
    - io_uring: unconditionally grab req->task
    - io_uring: return cancelation status from poll/timeout/files handlers
    - io_uring: enable task/files specific overflow flushing
    - io_uring: don't rely on weak ->files references
    - io_uring: reference ->nsproxy for file table commands
    - io_wq: Make io_wqe::lock a raw_spinlock_t
    - io-wq: fix use-after-free in io_wq_worker_running
    - io_uring: no need to call xa_destroy() on empty xarray
    - io_uring: Fix use of XArray in __io_uring_files_cancel
    - io_uring: Fix XArray usage in io_ur...

[Jerry Clement (jerry-clement)]

We are waiting for the Focal Kernel Proposed, May I ask if someone can help us understand the timing for when the kernel proposed will be posted for focal verification? It can be difficult to organize resources to meet the five day timeline for testing without having better insight into the delivery date.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.8.0-36.40+21.04.1

---------------
linux (5.8.0-36.40+21.04.1) hirsute; urgency=medium

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  [ Ubuntu: 5.8.0-36.40 ]

  * debian/scripts/file-downloader does not handle positive failures correctly
    (LP: #1878897)
    - [Packaging] file-downloader not handling positive failures correctly

  [ Ubuntu: 5.8.0-35.39 ]

  * Packaging resync (LP: #1786013)
    - update dkms package versions
  * CVE-2021-1052 // CVE-2021-1053
    - [Packaging] NVIDIA -- Add the NVIDIA 460 driver

 -- Kleber Sacilotto de Souza <email address hidden> Thu, 07 Jan 2021 11:57:30 +0100

[Jerry Clement (jerry-clement)]

Focal Testing completed by DellEMC

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.4.0-65.73

---------------
linux (5.4.0-65.73) focal; urgency=medium

  * focal/linux: 5.4.0-65.73 -proposed tracker (LP: #1912220)

  * initramfs unpacking failed (LP: #1835660)
    - SAUCE: lib/decompress_unlz4.c: correctly handle zero-padding around initrds.

  * overlay: permission regression in 5.4.0-51.56 due to patches related to
    CVE-2020-16120 (LP: #1900141)
    - ovl: do not fail because of O_NOATIME

  * Focal update: v5.4.79 upstream stable release (LP: #1907151)
    - net/mlx5: Use async EQ setup cleanup helpers for multiple EQs
    - net/mlx5: poll cmd EQ in case of command timeout
    - net/mlx5: Fix a race when moving command interface to events mode
    - net/mlx5: Add retry mechanism to the command entry index allocation

  * Kernel 5.4.0-56 Wi-Fi does not connect (LP: #1906770)
    - mt76: fix fix ampdu locking

  * [Ubuntu 21.04 FEAT] mpt3sas: Request to include the patch set which supports
    topology where zoning is enabled in expander (LP: #1899802)
    - scsi: mpt3sas: Define hba_port structure
    - scsi: mpt3sas: Allocate memory for hba_port objects
    - scsi: mpt3sas: Rearrange _scsih_mark_responding_sas_device()
    - scsi: mpt3sas: Update hba_port's sas_address & phy_mask
    - scsi: mpt3sas: Get device objects using sas_address & portID
    - scsi: mpt3sas: Rename transport_del_phy_from_an_existing_port()
    - scsi: mpt3sas: Get sas_device objects using device's rphy
    - scsi: mpt3sas: Update hba_port objects after host reset
    - scsi: mpt3sas: Set valid PhysicalPort in SMPPassThrough
    - scsi: mpt3sas: Handling HBA vSES device
    - scsi: mpt3sas: Add bypass_dirty_port_flag parameter
    - scsi: mpt3sas: Handle vSES vphy object during HBA reset
    - scsi: mpt3sas: Add module parameter multipath_on_hba
    - scsi: mpt3sas: Bump driver version to 35.101.00.00

 -- Kleber Sacilotto de Souza <email address hidden> Mon, 18 Jan 2021 17:31:23 +0100