Wakeup the system by touching the touchpad
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HWE Next |
Fix Released
|
Undecided
|
Unassigned | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Won't Fix
|
Undecided
|
Unassigned | ||
Groovy |
Fix Released
|
Undecided
|
Unassigned | ||
linux-oem-5.6 (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
koba | ||
Groovy |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Can't wake up by touching the touchpad.
[Fix]
1.gpio: With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/
gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable
callback is implemented then genirq takes unlazy path to disable irq. Underlying irqchip
may not want to implement irq_disable callback to lazy disable irq
when client drivers invokes disable_irq(). By overriding irq_disable callback,
gpiolib ends up always unlazy disabling IRQ.
Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only
if irqchip implemented irq_disable. In cases where irq_disable is not
implemented irq_mask is overridden. Similarly override irq_enable callback
only if irqchip implemented irq_enable otherwise irq_unmask is overridden.
2. hid: Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
also the default behavior on other OSes.
However, if touchpad and touchscreen contact to each other when lid is
closed, wakeup events can be triggered inadventertly.
So let's disable the wakeup by default, but enable the wakeup capability
so users can enable it at their own discretion.
[test]
With the patch and manually enable HID's power/wakeup, the system can wake up by touching the touchpad.
[Regression Potential]
Low. The two patches are already landed in the upstream.
CVE References
affects: | linux (Ubuntu) → linux-oem-5.6 (Ubuntu) |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
assignee: | nobody → koba (kobako) |
status: | New → In Progress |
summary: |
- Touchpad cannot wakeup the system Edit + Touchpad cannot wakeup the system |
summary: |
- Touchpad cannot wakeup the system + Wakeup the system by touching the touchpad |
tags: | added: oem-priority originate-from-1880123 somerville |
description: | updated |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done-focal removed: verification-needed-focal |
Changed in linux (Ubuntu Focal): | |
status: | New → Won't Fix |
Changed in hwe-next: | |
status: | New → Fix Released |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- focal' to 'verification- done-focal' . If the problem still exists, change the tag 'verification- needed- focal' to 'verification- failed- focal'.
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!