Fix reading speed and duplex sysfs on igc device
Bug #1906851 reported by
Kai-Heng Feng
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HWE Next |
Fix Released
|
Undecided
|
Unassigned | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
Unassigned | ||
Groovy |
Fix Released
|
Medium
|
Unassigned | ||
linux-oem-5.10 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
Unassigned | ||
Groovy |
Won't Fix
|
Undecided
|
Unassigned | ||
linux-oem-5.6 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Won't Fix
|
Medium
|
Unassigned | ||
Groovy |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Reading speed and duplex sysfs on igc device when it's runtime suspended
will make it stops working. Even kernel panic sometimes.
[Fix]
If igc device is runtime suspended, it means link isn't up, so we can
just report speed as -1 and duplex as unknown.
[Test]
$ cat /sys/class/
Then we'll see:
[ 123.449883] igc 0000:03:00.0 enp3s0: PCIe link lost, device now detached
[ 123.450052] BUG: kernel NULL pointer dereference, address: 0000000000000008
With the fix applied,
$ cat /sys/class/
-1
[Where problems could occur]
Not at all. Reading register when device is runtime suspended is just
wrong. The fix prevents it from happening.
CVE References
Changed in linux-oem-5.10 (Ubuntu Groovy): | |
status: | New → Won't Fix |
Changed in linux-oem-5.6 (Ubuntu Groovy): | |
status: | New → Won't Fix |
Changed in linux-oem-5.10 (Ubuntu): | |
status: | New → Invalid |
Changed in linux-oem-5.6 (Ubuntu): | |
status: | New → Invalid |
Changed in linux (Ubuntu Focal): | |
status: | New → Confirmed |
Changed in linux (Ubuntu Groovy): | |
status: | New → Confirmed |
Changed in linux-oem-5.10 (Ubuntu Focal): | |
status: | New → Confirmed |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
status: | New → Confirmed |
Changed in linux (Ubuntu Focal): | |
importance: | Undecided → Medium |
Changed in linux-oem-5.10 (Ubuntu Focal): | |
importance: | Undecided → Medium |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Groovy): | |
importance: | Undecided → Medium |
tags: | added: oem-priority originate-from-1904532 somerville |
Changed in linux-oem-5.10 (Ubuntu Focal): | |
status: | Confirmed → Fix Committed |
Changed in linux (Ubuntu Focal): | |
status: | Confirmed → Fix Committed |
Changed in linux (Ubuntu Groovy): | |
status: | Confirmed → Fix Committed |
tags: | added: verification-needed-focal |
tags: |
added: verification-done-focal removed: verification-needed-focal |
Changed in linux-oem-5.10 (Ubuntu Focal): | |
status: | Fix Committed → Fix Released |
tags: |
added: verification-done-groovy removed: verification-needed-groovy |
Changed in hwe-next: | |
status: | New → Fix Released |
Changed in linux-oem-5.6 (Ubuntu Focal): | |
status: | Confirmed → Won't Fix |
To post a comment you must log in.
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1906851
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.