initramfs-tools does not include fsck binaries in the initrd if all mount pass are 0
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
initramfs-tools (Ubuntu) |
Fix Released
|
Critical
|
Unassigned | ||
Bionic |
Fix Released
|
Critical
|
Dan Streetman | ||
Focal |
Fix Released
|
Critical
|
Dan Streetman | ||
Groovy |
Fix Released
|
Critical
|
Dan Streetman |
Bug Description
[Impact]
* initramfs-tools does not include fsck in initrd if MNT_PASS equals zero in the fstab entries.
This has lead to the following situation :
when dropping to initramfs shell during boot due to fs errors, we are not able to run fsck manually
because it is not included in initrd.
fsck should be included regardless of the MNT_PASS value.
[Test Plan]
* change /etc/fstab with PASSNO set to 0 for all entries
* update-initramfs -u
* lsinitramfs that is just generated
* observe that it includes fsck utilities for the filesystems in /etc/fstab. I.e. fsck.ext4 e2fsck must exist
[Where problems could occur]
* The initramfs size will increase slightly upon upgrade, for the same initramfs-tools default options & kernel. However, one can control and remove fsck binaries (or include more of them) by setting FSTYPE variable in the initramfs settings.
[scope]
this is required for b/f/g
this is fixed already in h and i
[other info]
debian MR is open:
https:/
Changed in initramfs-tools (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: rls-hh-incoming |
tags: | removed: rls-hh-incoming |
description: | updated |
Changed in initramfs-tools (Ubuntu): | |
status: | In Progress → Fix Committed |
assignee: | Ioanna Alifieraki (joalif) → nobody |
description: | updated |
Changed in initramfs-tools (Ubuntu Bionic): | |
status: | New → In Progress |
Changed in initramfs-tools (Ubuntu Groovy): | |
status: | New → In Progress |
Changed in initramfs-tools (Ubuntu Focal): | |
status: | New → In Progress |
Changed in initramfs-tools (Ubuntu Groovy): | |
importance: | Undecided → Critical |
Changed in initramfs-tools (Ubuntu Focal): | |
importance: | Undecided → Critical |
Changed in initramfs-tools (Ubuntu Bionic): | |
importance: | Undecided → Critical |
Changed in initramfs-tools (Ubuntu Bionic): | |
assignee: | nobody → Dan Streetman (ddstreet) |
Changed in initramfs-tools (Ubuntu Focal): | |
assignee: | nobody → Dan Streetman (ddstreet) |
Changed in initramfs-tools (Ubuntu Groovy): | |
assignee: | nobody → Dan Streetman (ddstreet) |
We must honor MNT_PASS.
The actual bug is that many things do not set it to 1 by default as they should have.
I.e. bits in curtin, maas, subiquity, cloud-images.
It is correctly set to 1 on ubiquity desktop images and d-i based installs.
So this bug is a duplicate of https:/ /bugs.launchpad .net/ubuntu/ +source/ livecd- rootfs/ +bug/1902103