use builtin dump_acpi_tables.py in hookutils

[Yuan-Chen Cheng]

1. add apcidump to hookutils.py:attach_hardware and use the builtin dump_acpi_tables.py.
2. remove explicit acpidump from oem-getlogs to use the builtin one.
3. refine usage string in oem-getlogs.

To SRU to focal:

[Impact]

 * for OEM project, lts is been used. And collect log is important.
   With built-in tool to get acpidump, we don't need to install
   extra tool in the end-customer's machine. That make it much
   easier for the oem process.

 * By call built-in utility, we no lounger need to install extra
   tools to collect data that's both complete and convenient for
   HWE people to work on.

[Test Case]

 * before this applied, run oem-getlog without install acpidump.
   we can't get the dump data. After this applied, we can just dump
   the data HWE need.

 * test step: install the new package, run

   sudo -E oem-getlogs [-c case_id] to get the

   use apport-unpack to unpack the apport file.

   check the acpidump file. HWE people know much better on check
   the acpidump file. Give the dump_acpi_tables.py just updated and SRUed
   by HWE/ACPI/UEFI expert, it's pretty safe to do so.

[Regression Potential]

 * Given the modification change the way to collect log, even it
   failed, it won't break apport itself. Just the collected log
   might contain data not so valid.

 * Given acpidump mostly used by HWE/ACIP/UEFI expert, and they
   just reviewed and updated the dump_acpi_tables.py script, I
   believe it will have good quality.

[Yuan-Chen Cheng (ycheng-twn)]

debdiff to apport in groovy.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "apport_42to43.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Yuan-Chen Cheng (ycheng-twn)]

please kindly also SRU it to focal, since oem project use lts mostly.
I'll take responsibility to verify sru or other thing I can do.

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.11-0ubuntu45

---------------
apport (2.20.11-0ubuntu45) groovy; urgency=medium

  [ YC Cheng ]
  * apport/hookutils.py: add acpidump using built-in dump_acpi_tables.py.
    (LP: #1888352)
  * bin/oem-getlogs: add "-E" in the usage, since we'd like to talk to
    pulseaudio session and that need environment infomation. Also remove
    acpidump since we will use the one from hook.

  [ Brian Murray ]
  * data/general-hooks/ubuntu.py: Check for /var/run/reboot-required.pkgs and
    add it to the report as RebootRequiredPkgs.

 -- Brian Murray <email address hidden> Wed, 26 Aug 2020 15:57:02 -0700

[Brian Murray (brian-murray)]

Could you please add some SRU information to the bug description to facilitate the SRU process?

[Brian Murray (brian-murray)]

I've uploaded this to the focal SRU queue for review by an SRU team member.

[Timo Aaltonen (tjaalton)]

Hello Yuan-Chen, or anyone else affected,

Accepted apport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.11-0ubuntu27.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Yuan-Chen Cheng (ycheng-twn)]

the oem-getlogs file using the apport 2.20.11-0ubuntu27.9 from the proposed channel.
I am going to find uefi expert to double check

[Alex Hung (alexhung)]

@ycheng-twn,

1. Is it normal that everything is in a plain text file?
2. There is an extra space for acpidump. This causes acpixtract to fail to extract ACPI tables.
3. The content looks "reasonable", but /sys/firmware/acpi/tables/* are required to byte-to-byte compare after 1 & 2 are fixed.

[Yuan-Chen Cheng (ycheng-twn)]

this is output of acpidump-acpica on that machine

[Yuan-Chen Cheng (ycheng-twn)]

this is output of dump_acpi_tables.py on that machine.

[Yuan-Chen Cheng (ycheng-twn)]

for the apport.gz, per what I know, it's all plain text after we un-gzip it.

[Alex Hung (alexhung)]

@ycheng-twn,

#10 and #11 are basically the same except orders of some tables; however this is as expected.

the gz file of #8 contains a "single" plain text file. Shouldn't it be one file for each log file?

[Alex Hung (alexhung)]

After using apport-unpack for #8, acpidump looks good

[Yuan-Chen Cheng (ycheng-twn)]

given #14, verified done

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.11-0ubuntu27.9

---------------
apport (2.20.11-0ubuntu27.9) focal; urgency=medium

  [ YC Cheng ]
  * apport/apport/hookutils.py: add acpidump using built-in
    dump_acpi_tables.py. (LP: #1888352)
  * bin/oem-getlogs: add "-E" in the usage, since we'd like to talk to
    pulseaudio session and that need environment infomation. Also remove
    acpidump since we will use the one from hook.

 -- Brian Murray <email address hidden> Wed, 02 Sep 2020 09:48:39 -0700

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for apport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.