xfwm4 crashed with signal 5 in _XReply()

[Yousuf 'Jay' Philips]

[Impact]

 * Some client applications crash when closing a dialog with the Xfwm4 compositor off.

[Test Plan]

 * Disable the Xfwm4 compositor. Settings Manager > Window Manager Tweaks > Compositor > Toggle off "Enable Display Compositing".

 * Open Catfish.

 * Open the About dialog.

 * Close the About dialog.

 * Catfish crashes.

 * Once fixes, Catfish will no longer crash.

[Where problems could occur]

 * Regression potential should be relatively low, as the release between 4.14.1 and 4.14.5 are bug releases.

 * With window managers, some changes could lead to different behavior and other broken displays. Non-AMD graphics users should also test for regressions.

[Other Info]

 * Please see the Xfwm4 release notes for changes between 4.14.1 and 4.14.5: https://gitlab.xfce.org/xfce/xfwm4/-/blob/xfce-4.14/NEWS#L7-44

[Original Report]

Crash in Catfish when closing the about dialog when running with compositing off.

ProblemType: Crash
DistroRelease: Ubuntu 20.04
Package: xfwm4 4.14.0-2ubuntu1
ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
Uname: Linux 5.4.0-21-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu25
Architecture: amd64
CasperVersion: 1.443
CurrentDesktop: XFCE
Date: Mon Apr 13 08:16:42 2020
ExecutablePath: /usr/bin/xfwm4
LiveMediaBuild: Xubuntu 20.04 LTS "Focal Fossa" - Beta amd64 (20200409)
ProcCmdline: xfwm4 --replace --display :0.0 --sm-client-id 2c1491795-ed9c-412d-9ef8-3a11bd50a364
ProcEnviron:
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
Signal: 5
SourcePackage: xfwm4
StacktraceTop:
 ?? () from /lib/x86_64-linux-gnu/libX11.so.6
 ?? () from /lib/x86_64-linux-gnu/libX11.so.6
 _XReply () from /lib/x86_64-linux-gnu/libX11.so.6
 XSync () from /lib/x86_64-linux-gnu/libX11.so.6
 ?? () from /lib/x86_64-linux-gnu/libgdk-3.so.0
Title: xfwm4 crashed with signal 5 in _XReply()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin lxd plugdev sambashare sudo
separator:

[Yousuf 'Jay' Philips (philipz85)]

Filed at xfce
https://bugzilla.xfce.org/show_bug.cgi?id=16383

[Apport retracing service (apport)]

StacktraceTop:
 XSync (dpy=0x55ff73c7edc0, discard=0) at ../../src/Sync.c:44
 gdk_x11_display_error_trap_pop_internal () from /tmp/apport_sandbox_8q90ktvs/usr/lib/x86_64-linux-gnu/libgdk-3.so.0.2404.10
 clientSetFocus (screen_info=screen_info@entry=0x55ff73df6e00, c=c@entry=0x55ff7403b100, timestamp=335265, flags=flags@entry=14) at focus.c:594
 clientPassFocus (screen_info=0x55ff73df6e00, c=<optimized out>, exclude_list=0x55ff73e18ce0) at focus.c:382
 handleUnmapNotify (ev=<optimized out>, display_info=<optimized out>) at events.c:1306

[Sean Davis (bluesabre)]

Fix included in Xfwm4 4.14.2

https://gitlab.xfce.org/xfce/xfwm4/-/commit/bb38fd909ad59b03aa3446799380a897a7ac481f

[Sean Davis (bluesabre)]

Attaching debdiff for xfwm4_4.14.5-1ubuntu0.20.04.1, also uploaded to the Xubuntu SRU Staging PPA:

https://launchpad.net/~xubuntu-dev/+archive/ubuntu/sru-staging

[Brian Murray (brian-murray)]

An upload of xfwm4 to focal-proposed has been rejected from the upload queue for the following reason: "This is a mircorelease update of xfwm4 that doesn't follow the policy.".