unable to reconize Asgard NVME with short serial

[isgenius]

check this:
https://discourse.maas.io/t/unable-to-deploy-valueerror-failed-to-find-storage-volume-id-nvme0n1/4442/4

Maybe the line os.listdir should be changed with os.walk to discover all child directories?
Or maybe this is just a BUG of MAAS?

[Michael Hudson-Doyle (mwhudson)]

Ah what the heck, I really don't think the fact that the disk has a / in the model name leads to nested directories in /dev/disk/by-id is expected. _something_ should probably be escaping that, but I'm not sure what or how.

[weizehua (weizehua)]

Amazing, I never thought about that, a '/' is in model name!
So might it be a bug of something else?

[Balint Reczey (rbalint)]

@mwhudson also reported this issue upstream https://github.com/systemd/systemd/issues/19309 (thanks!)

[Michael Hudson-Doyle (mwhudson)]

The upstream bug request has a PR that seems to fix the issue already. I guess if it gets accepted upstream we can think about backporting the fix to stable releases in the fullness of time.

[Michael Hudson-Doyle (mwhudson)]

That said, we could fix this issue in curtin by searching for a device with specified serial by just looking through the udev db directly rather than by globbing in /dev/disk/by-id. In fact I thought we already did that! But apparently not.

[weizehua (weizehua)]

Happy to see it being fixed so quickly.

[Brian Murray (brian-murray)]

The Hirsute Hippo has reached End of Life, so this bug will not be fixed for that release.