sysdig 0.26.4-1 fails to build on Focal with linux-hwe-5.8

[Kleber Sacilotto de Souza]

[Impact]
The sysdig DKMS package FTBFS with the new linux-hwe-5.8 kernel on Focal.

[Test Case]
Compile the dkms package, load the sysdig module and run sysdig (or csysdig) user space utility.

[Regression potential]
The largest patch applied to fix the compilation with kernels newer than 5.6 had to be backported to be applied to sysdig 0.26.4-1. While the changes had been smoke-tested on both 5.4 and 5.8 kernels, there's a chance that either the original changes or the backport have issues when dealing with time keeping using the internal structures instead of the deprecated 'struct timespec' which could impact some of the functionalities.

---
dkms package failed to build on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/s/sysdig/20201016_102509_3a72f@/log.gz
    armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/armhf/s/sysdig/20201016_110849_6a300@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/s/sysdig/20201016_104955_33928@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/s/sysdig/20201016_081603_465a9@/log.gz

Build errors:

In file included from /var/lib/dkms/sysdig/0.26.4/build/fillers_table.c:12:
/var/lib/dkms/sysdig/0.26.4/build/ppm.h:53:18: error: field ‘last_print_time’ has incomplete type
   53 | struct timespec last_print_time;
      | ^~~~~~~~~~~~~~~
make[1]: *** [scripts/Makefile.build:290: /var/lib/dkms/sysdig/0.26.4/build/fillers_table.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /var/lib/dkms/sysdig/0.26.4/build/main.c:55:
/var/lib/dkms/sysdig/0.26.4/build/ppm.h:53:18: error: field ‘last_print_time’ has incomplete type
   53 | struct timespec last_print_time;
      | ^~~~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.26.4/build/main.c: In function ‘ppm_ioctl’:
/var/lib/dkms/sysdig/0.26.4/build/main.c:826:19: error: storage size of ‘ts’ isn’t known
  826 | struct timespec ts;
      | ^~
/var/lib/dkms/sysdig/0.26.4/build/main.c:838:3: error: implicit declaration of function ‘getnstimeofd
ay’ [-Werror=implicit-function-declaration]
  838 | getnstimeofday(&ts);
      | ^~~~~~~~~~~~~~
[...]

[Kleber Sacilotto de Souza (kleber-souza)]

The changes on the attached debdiff fix the compilation issues with linux-hwe-5.8 while still working with linux 5.4.

The source package has been build-tested on all supported architectures and the built modules were loaded and smoke-tested with linux 5.4 and linux-hwe-5.8 on Focal.

[Kleber Sacilotto de Souza (kleber-souza)]

The proposed fix has two patches:
0001-Linux-5.6-timespec-changes.patch
0001-Linux-5.8-replace-probe_kernel_read-with-copy_from_k.patch

The first patch is a backport from commit 938986890291c126f9b8f3a050bc3edc95fb6f5a from the sysdig upstream repo (https://github.com/draios/sysdig.git). This patch was applied to upstream 0.26.7 and needed some small changes backport it to 0.26.4.

The second patch was cherry-picked from sysdig 0.26.7-2ubuntu1 on groovy.

[Brian Murray (brian-murray)]

Hello Kleber, or anyone else affected,

Accepted sysdig into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sysdig/0.26.4-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted sysdig (0.26.4-1ubuntu0.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

sysdig/0.26.4-1ubuntu0.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#sysdig

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Kleber Sacilotto de Souza (kleber-souza)]

The armhf build is indeed failing with the following error:

ERROR: "__aeabi_uldivmod" [/var/lib/dkms/sysdig/0.26.4/build/sysdig-probe.ko] undefined!

There's a SAUCE patch on the groovy package, I will backport it and prepare a new upload to fix this issue.

[Łukasz Zemczak (sil2100)]

The version of sysdig in the proposed pocket of Focal that was purported to fix this bug report has been removed because one or more bugs that were to be fixed by the upload have failed verification and been in this state for more than 10 days.

[Łukasz Zemczak (sil2100)]

Hello Kleber, or anyone else affected,

Accepted sysdig into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sysdig/0.26.4-1ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

Hi,

I confirm that sysdig-dkms 0.26.4-1ubuntu0.2 kernel modules can be built and loaded on focal with both linux 5.4 and linux-hwe 5.8 kernels.

$ dkms status
sysdig, 0.26.4, 5.4.0-51-generic, x86_64: installed
sysdig, 0.26.4, 5.8.0-33-generic, x86_64: installed

I have also triggered ADT tests with linux-hwe-5.8 and they completed successfully:

amd64 - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/s/sysdig/20201216_110643_e483d@/log.gz
armhf - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/armhf/s/sysdig/20201216_105019_e483d@/log.gz
ppc64el - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/s/sysdig/20201216_104936_6e30d@/log.gz
s390x - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/s/sysdig/20201216_103835_66bde@/log.gz

Thanks,
Kleber

[Po-Hsu Lin (cypressyew)]

Note that the module build works, the ubuntu_sysdig_smoke_test will now fail with bug 1844493

[Andy Whitcroft (apw)]

The verification of the Stable Release Update for sysdig has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package sysdig - 0.26.4-1ubuntu0.2

---------------
sysdig (0.26.4-1ubuntu0.2) focal; urgency=medium

  * Fix dkms build on armhf (LP: #1901734)
    - 0001-UBUNTU-SAUCE-armhf-fix-64bit-mod-by-using-div64_u64_.patch

 -- Kleber Sacilotto de Souza <email address hidden> Fri, 13 Nov 2020 10:30:30 +0100