php-symfony-dependency-injection not working with php 8

[Massimiliano Arione]

[ Impact ]

The user is unable to use phpMyAdmin or the related symfony library

[ Test Plan ]

# Reproduced using the 20.04.6 ISO

Run the following commands:

    apt update
    apt upgrade -y
# Install the "add-apt-repository" command
    apt install software-properties-common -y
    add-apt-repository ppa:phpmyadmin/ppa

# Install the deb sury repo
    apt-get -y install lsb-release ca-certificates curl

    curl -sSLo /usr/share/keyrings/deb.sury.org-php.gpg https://packages.sury.org/php/apt.gpg
    sh -c 'echo "deb [signed-by=/usr/share/keyrings/deb.sury.org-php.gpg] https://packages.sury.org/php/ bullseye main" > /etc/apt/sources.list.d/php.list'
    apt update
    apt install php8.2
    apt install mysql-server -y
    service mysql start
# Choose apache2 to auto configure and accept dbcommon setup
    apt install phpmyadmin
    service apache2 start

# Change the root password
    mysql -e "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password by 'public';"

# Browse: http://localhost/phpmyadmin/
# Login: root/public
# See the error "Unknown parameter $$dbi"

Apply the change in the merge request and login another time, now phpMyAdmin works !

[ Where problems could occur ]

 This exact fix was applied by users for years, there is nothing more to be afraid about.

[ Other Info ]

This has been fixed since jammy.

Recent report at phpMyAdmin: https://github.com/phpmyadmin/phpmyadmin/issues/18498
And the oldest on 20.04.2 LTS: https://github.com/phpmyadmin/phpmyadmin/issues/16968

Fixed by https://code.launchpad.net/~williamdes/ubuntu/+source/symfony/+git/symfony/+merge/442971

[ Original message ]

Package should be updated to symfony/dependency-injection:4.4.9 at least, since it's the first release of v4 that is supporting both php7 and php8. I think that, anyway, using current last available point release (that is 4.4.25) would be better.
See https://github.com/phpmyadmin/phpmyadmin/issues/16968 for a related bug.

[Utkarsh Gupta (utkarsh)]

Hello,

Impish (-propose) has 5.2.6+dfsg-1ubuntu7, which is hopefully what you want. And also works with PHP 8.0. We're currently in midst of the transition so that should happen soon. And that mean, it should soon migrate to Impish (-release).

Please enable the -propose pocket in case you want to use that *now*. But make sure you know what you're doing! :)

[Utkarsh Gupta (utkarsh)]

FWIW, 4.4.19+dfsg-1 is already available in Hirsute & Impish (-release). And 4.4.14+dfsg-1 in Groovy. So we've had > 4.4.9 for a while now. :)

[Massimiliano Arione (garakkio)]

Well, phpmyadmin is typically a package used in a server environment.
As you know, usual servers are kept on LTS releases.
Do you think an update for focal could be feasible?

[Massimiliano Arione (garakkio)]

Well, the weird thing is that you didn't have 4.4 in focal, being Symfony support release planned with a long advance.
Now 4.3 is out of support (even for security fixes) and I guess that this not nice for an LTS

[Utkarsh Gupta (utkarsh)]

Hello,

Unfortunately, this didn't work with the cycle & timeline we had. We can't do much about it now. But I guess I can try to add the patch for fixing this in Focal.

[Utkarsh Gupta (utkarsh)]

Just to be clear, the fix for the problem is https://github.com/symfony/symfony/commit/8e34978e4e2c4bf7dac97e44e904368c4cfb54f8, correct?

[William Desportes (williamdes)]

Correct, this is the needed fix

[Łukasz (kanlukasz)]

Hello

I would like to ask about any progress in fix this package in Focal?
Is there a chance that this fix will appear?

Many of us have problems with phpmyadmin apt because of this problem
- https://github.com/phpmyadmin/phpmyadmin/issues/17187
- https://github.com/phpmyadmin/phpmyadmin/issues/16968
- https://github.com/symfony/symfony/issues/38089
- https://github.com/phpmyadmin/phpmyadmin/issues/17197

PS. I'm not sure, but there is probably one more thing that is related to this issue
```
PHP Deprecated: Required parameter $arguments follows optional parameter $callable in /usr/share/php/Twig/Node/Expression/CallExpression.php on line 116
```
but I'm not sure where to report it

[Utkarsh Gupta (utkarsh)]

Hello,

This is in my list of things to do but I have other important things to do as well. Can someone help prepare this bug as an SRU bug with all the templating, et al?
cf: the first three points mentioned here: https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

TIA! \o/

[Łukasz (kanlukasz)]

I don't know how this is possible, but I unassigned you. I'm sorry my mistake

[Utkarsh Gupta (utkarsh)]

No problem, re-assigned. I intend to get to this bug this month.

[Sergio Durigan Junior (sergiodj)]

Utkarsh mentioned in #ubuntu-server that he is still planning to work on this bug.

[William Desportes (williamdes)]

I made an SRU for some phpMyAdmin stuff kind of related (https://bugs.launchpad.net/ubuntu/+source/phpmyadmin/+bug/2013402), I may work on this one if it's still on a LTS version that can have updates.

What versions should I make an SRU for ?

[Christian Ehrhardt  (paelzer)]

Utkarsh didn't work on this for a while and is busy elsewhere.
Removing the assignment to reflect that.

Since William offered to help let us embrace that \o/
@William - as the bug tasks show having a look at Focal is the LTS release that would still benefit from an SRU.

[William Desportes (williamdes)]

Hi Christian,

I made a merge proposal: https://code.launchpad.net/~williamdes/ubuntu/+source/symfony/+git/symfony/+merge/442971

[Athos Ribeiro (athos-ribeiro)]

Hi William,

would you mind also filling in the SRU paperwork for this bug (as you did with the phpmyadmin ones)?

[William Desportes (williamdes)]

Here is the SRU https://bugs.launchpad.net/ubuntu/+source/symfony/+bug/2024615
And the merge: https://code.launchpad.net/~williamdes/ubuntu/+source/symfony/+git/symfony/+merge/442971

[Athos Ribeiro (athos-ribeiro)]

Hi WIlliam,

As we agreed, I am moving the SRU template here and will mark LP: #2024615 as a duplicate.