Change sudo compile options from --with-all-insults to --with-pc-insults

[dh]

Tame as they might be, I'd like to continue using "Defaults insults" without any risk of upsetting anyone (and without having to maintain our own package version.)
Would the safe insults version at compile time "--with-pc-insults" be a sensible default for all?

Current as of Jammy, but looks like it's still the default compile option across the board
Version: 1.9.9-1ubuntu2

Current behaviour : Enabling includes the "not PC" insults
Expected behaviour : Insults would default to "PC"

[Marc Deslauriers (mdeslaur)]

I'm not sure I understand this bug, the --with-pc-insults option is deprecated since 2017-09-18 as it is the default option.

The noble package doesn't use --enable-offensive-insults.

[dh (dcharvey)]

I may have put 2+2 together and made 5 here then. Pulling strings from the
library i could see one of the insults that i thought was only included
inside the elseif statement for PC being set. I'll double check as i may
have been looking at an old git revision, or perhaps there was a config
option i overlooked for offensive vs tame insults which left it included in
the library

On Fri, 15 Mar 2024, 18:00 Marc Deslauriers, <email address hidden>
wrote:

> I'm not sure I understand this bug, the --with-pc-insults option is
> deprecated since 2017-09-18 as it is the default option.
>
> The noble package doesn't use --enable-offensive-insults.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/2058053
>
> Title:
> Change sudo compile options from --with-all-insults to --with-pc-
> insults
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/sudo/+bug/2058053/+subscriptions
>
>

[Marc Deslauriers (mdeslaur)]

Great, I'll leave this bug open for now. Please let us know if there is anything that is enabled that shouldn't be. Thanks!

[dh (dcharvey)]

Yep, we can close this, my mistake.
I was thrown off but he fact that the brains one was previously gated by PC insults, but is included despite default to PC since https://www.sudo.ws/repos/sudo/rev/eb264d342601 .
Nothing to see here, move along :)

[Marc Deslauriers (mdeslaur)]

Actually, I think you're right, the brains one does seem to be included because while that upstream patch does do the following to plugins/sudoers/ins_classic.h, it didn't apply the same change to plugins/sudoers/ins_csops.h:

-#ifdef PC_INSULTS
+#ifndef OFFENSIVE_INSULTS

[Marc Deslauriers (mdeslaur)]

Could you please file a bug upstream about the missing change, and let us know the bug number?

https://bugzilla.sudo.ws/index.cgi

[Marc Deslauriers (mdeslaur)]

I'll fix this issue in noble.

[Marc Deslauriers (mdeslaur)]

I've filed the upstream bug and have linked it here, please ignore my comment #6.

[Launchpad Janitor (janitor)]

This bug was fixed in the package sudo - 1.9.15p5-3ubuntu3

---------------
sudo (1.9.15p5-3ubuntu3) noble; urgency=medium

  * Disable an offensive insult (LP: #2058053)
    - d/p/disable_offensive_insult.patch: properly disable an offensive
      insult that was fogotten when the configure options were refactored
      in plugins/sudoers/ins_csops.h.

 -- Marc Deslauriers <email address hidden> Mon, 18 Mar 2024 07:53:26 -0400