Comment 23 for bug 1872476

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote : Re: [Bug 1872476] Re: Shared files are shown as folders

On Friday, May 01 2020, Max-Ulrich Farber wrote:

> Hi Sergio Durigan jr.,

Hi Max-Ulrich,

> could you please tell us what has been changed in the samba 4.11.7
> package in your PPA. It would be fine if I could know that before
> installing your samba version in my system. I am surprised that you
> could find the bug in samba and not in GIO/gvfs, for smbclient and
> mount.cifs both work fine without any problems in the original samba
> 4.11.7, and files are not shown as folders there.

The PPA still contains samba 4.11.6, not 4.11.7. We don't want to bump
the package version right now, so I just backported a few fixes needed
to fix this problem.

The fixes are:

  https://gitlab.com/samba-team/devel/samba/-/commit/a33656c9df2cde3ff1cfc6b0427c7dfb2b140cae
  https://gitlab.com/samba-team/devel/samba/-/commit/a95a8c7eaa46d5c8c485de714f0a97e307e49f7e
  https://gitlab.com/samba-team/devel/samba/-/commit/39c910fd9cba3caf7414274b678b9eee33d7e20b

The first two are included in samba 4.11.7; the third one hasn't been
released yet, AFAIK.

It's interesting to notice that the bug manifests only on GIO/gvfs, and
not on mount.cifs/smbclient, not even when using samba 4.11.6. I
haven't investigated much to find the reason for this discrepancy; maybe
GIO/gvfs's implementation of the SMB protocol are able to trigger a
corner case on samba when using SMB1. You can look at the bugs from
Fedora and/or Samba to see that the problem was with the way
libsmbclient dealt with stat(2) on UNIX:

  https://bugzilla.samba.org/show_bug.cgi?id=14101
  https://bugzilla.redhat.com/show_bug.cgi?id=1801442#c28

As I explained to Pier, there will be an SRU for samba on focal which
will include this fix.

Cheers,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14