| 2021-11-24 10:18:54 |
Jesse Sung |
bug |
|
|
added bug |
| 2021-11-24 10:19:15 |
Jesse Sung |
nominated for series |
|
Ubuntu Focal |
|
| 2021-11-24 10:19:15 |
Jesse Sung |
bug task added |
|
linux (Ubuntu Focal) |
|
| 2021-11-24 10:19:28 |
Jesse Sung |
linux (Ubuntu Focal): status |
New |
In Progress |
|
| 2021-11-24 10:19:31 |
Jesse Sung |
linux (Ubuntu Focal): assignee |
|
Jesse Sung (wenchien) |
|
| 2021-11-24 10:30:06 |
Ubuntu Kernel Bot |
linux (Ubuntu): status |
New |
Incomplete |
|
| 2021-11-24 10:36:24 |
Jesse Sung |
linux (Ubuntu): status |
Incomplete |
In Progress |
|
| 2021-11-24 10:36:28 |
Jesse Sung |
linux (Ubuntu): assignee |
|
Jesse Sung (wenchien) |
|
| 2021-11-24 10:47:20 |
hugh chao |
bug |
|
|
added subscriber hugh chao |
| 2021-11-24 10:50:09 |
Robert Liu |
bug |
|
|
added subscriber Robert Liu |
| 2021-11-24 10:54:46 |
Jesse Sung |
description |
== Impact ==
Although we have CONFIG_RTC_HCTOSYS enabled and set CONFIG_RTC_HCTOSYS_DEVICE to "rtc0", system time would only be set if the RTC driver is built-in. This may not be an issue on most amd64 systems because CONFIG_RTC_DRV_CMOS is y for amd64, however it is an issue for other architectures since there may not be a proper RTC driver enabled as built-in. Also make every RTC driver that may be used as built-in is not a good option.
== Fix ==
The commit is in mainline since v5.7:
commit f9b2a4d6a5f18e0aaf715206a056565c56889d9f
Author: Steve Muckle <smuckle@google.com>
Date: Wed Nov 6 11:46:25 2019 -0800
rtc: class: support hctosys from modular RTC drivers
Due to distribution constraints it may not be possible to statically
compile the required RTC driver into the kernel.
Expand RTC_HCTOSYS support to cover all RTC devices (statically compiled
or not) by checking at the end of RTC device registration whether the
time should be synced.
Signed-off-by: Steve Muckle <smuckle@google.com>
Link: https://lore.kernel.org/r/20191106194625.116692-1-smuckle@google.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
== Risk of Regression ==
It's a clean cherry-pick for v5.4 and looks straight forward so risk should be low. |
== Impact ==
Although we have CONFIG_RTC_HCTOSYS enabled and set CONFIG_RTC_HCTOSYS_DEVICE to "rtc0", system time would only be set if the RTC driver is built-in. This may not be an issue on most amd64 systems because CONFIG_RTC_DRV_CMOS is y for amd64, however it is an issue for other architectures since there may not be a proper RTC driver enabled as built-in. Also making every RTC driver that may be used as built-in is not a good option.
== Fix ==
The commit is in mainline since v5.7:
commit f9b2a4d6a5f18e0aaf715206a056565c56889d9f
Author: Steve Muckle <smuckle@google.com>
Date: Wed Nov 6 11:46:25 2019 -0800
rtc: class: support hctosys from modular RTC drivers
Due to distribution constraints it may not be possible to statically
compile the required RTC driver into the kernel.
Expand RTC_HCTOSYS support to cover all RTC devices (statically compiled
or not) by checking at the end of RTC device registration whether the
time should be synced.
Signed-off-by: Steve Muckle <smuckle@google.com>
Link: https://lore.kernel.org/r/20191106194625.116692-1-smuckle@google.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
== Risk of Regression ==
It's a clean cherry-pick for v5.4 and looks straight forward so risk should be low. |
|
| 2021-12-02 05:24:45 |
Jesse Sung |
linux (Ubuntu): status |
In Progress |
Confirmed |
|
| 2021-12-02 05:24:48 |
Jesse Sung |
linux (Ubuntu Focal): status |
In Progress |
Confirmed |
|
| 2021-12-02 05:29:19 |
Anthony Wong |
linux (Ubuntu Focal): assignee |
Jesse Sung (wenchien) |
Dimitri John Ledkov (xnox) |
|
| 2021-12-02 05:29:24 |
Anthony Wong |
linux (Ubuntu): assignee |
Jesse Sung (wenchien) |
Dimitri John Ledkov (xnox) |
|
