gnome-terminal wrapper doesn't wait for the process to exit

[Marco Trevisan (Treviño)]

[ Impact ]

Gnome terminal has a wrapper to make it compatible with the x-terminal-emulator (i.e. generic xterm implementation), however, while the arguments mapping is correct, when launching `x-terminal-emulator` the control will return to the caller once the terminal has been dbus-activated.

This is not expected by x-terminal-emulator, and so breaks the usage of the terminal as fallback when the X11 session failed on startup.

[ Test case ]

When gnome-terminal is set as x-terminal-emulator (ensure this with update-alternatives --query x-terminal-emulator), launch (from a terminal):

  x-terminal-emulator -geometry 80x24+0+0

A terminal emulator should open in the top-left corner, and it should stay open until you don't hit Ctrl+C from the launching terminal.

[ Regression potential ]

None known, possibly a failing launched X session could stay in black screen instead of returning back to gdm promptly.

[Bagas Sanjaya (bagasme)]

I can't reproduce the issue.

On my system, x-terminal-emulator is set to /usr/bin/gnome-terminal.wrapper. Is it the wrapper you mentioned?

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-terminal - 3.38.0-1ubuntu1

---------------
gnome-terminal (3.38.0-1ubuntu1) groovy; urgency=medium

  * Merge with debian, remaining changes:
    - gnome-terminal.wrap, debian/rules:
      - Add a wrapper script to restore command line compatibility.
    + debian/control.in:
      - gnome-terminal depends on python3, python3-gi and gir1.2-glib-2.0 for
        the wrapper script.
      - add a build dependency on gettext to match the configure requirement
    + Add 0001-Restore-transparency.patch:
      - Restore transparency support
    + Add 0001-Add-style-classes-and-CSS-names-to-some-of-our-widge.patch:
      - Add CSS names and style classes so we can theme things more easily.
    + Add 0001-screen-window-Extra-padding-around-transparent-termi.patch:
      - Fix transparency on Wayland. Patch by Owen Taylor, via Debarshi Ray @
        Fedora
    + Add 52_support_apturl.patch:
      - Support apt: urls.
    + Add 60_add_lp_handler.patch:
      - Add a handler for launchpad bug URLs.
    + Add scrollbar-background-theming.patch:
      - Draw background under the scrollbar that matches the actual terminal
        background color. This allows proper theming.

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 22 Sep 2020 21:03:04 +0200