| 2024-02-20 06:20:43 |
Chengen Du |
bug |
|
|
added bug |
| 2024-02-20 06:45:52 |
Chengen Du |
description |
[Impact]
When LDAP automount maps generate a substantial number of entries in /proc/mounts, it has the potential to induce a timeout issue, particularly during the process of iterating through the entries twice in the cryptroot hook.
[Fix]
Utilizing awk to initially filter out pertinent mount points results in a notable reduction in the execution time of the hook.
[Test Plan]
The patch maintains the existing logic within the hook.
Our primary objective is to ensure that the output remains consistent when obtaining devnos through iteration.
1. Execute the "sh /usr/share/initramfs-tools/hooks/cryptroot" command
2. Confirm that the output does not include the following warning message:
cryptsetup: WARNING: Couldn't determine root device
[Where problems could occur]
The patch exclusively modifies the method of extracting information without altering the underlying hook logic.
It's crucial to note that the successful generation of the crypttab is contingent upon the accuracy of the information provided by the patch.
Any inaccuracies may impede the crypttab generation process. |
[Impact]
When LDAP automount maps generate a substantial number of entries in /proc/mounts, it has the potential to induce a timeout issue, particularly during the process of iterating through the entries twice in the cryptroot hook.
[Fix]
Utilizing awk to initially filter out pertinent mount points results in a notable reduction in the execution time of the hook.
[Test Plan]
The patch maintains the existing logic within the hook.
Our primary objective is to ensure that the output remains consistent when obtaining devnos through iteration.
1. Execute the /usr/share/initramfs-tools/hooks/cryptroot binary
2. Confirm that the output does not include the following warning message:
cryptsetup: WARNING: Couldn't determine root device
[Where problems could occur]
The patch exclusively modifies the method of extracting information without altering the underlying hook logic.
It's crucial to note that the successful generation of the crypttab is contingent upon the accuracy of the information provided by the patch.
Any inaccuracies may impede the crypttab generation process. |
|
| 2024-02-20 08:01:41 |
Chengen Du |
nominated for series |
|
Ubuntu Mantic |
|
| 2024-02-20 08:01:41 |
Chengen Du |
bug task added |
|
cryptsetup (Ubuntu Mantic) |
|
| 2024-02-20 08:01:41 |
Chengen Du |
nominated for series |
|
Ubuntu Jammy |
|
| 2024-02-20 08:01:41 |
Chengen Du |
bug task added |
|
cryptsetup (Ubuntu Jammy) |
|
| 2024-02-20 08:01:41 |
Chengen Du |
nominated for series |
|
Ubuntu Noble |
|
| 2024-02-20 08:01:41 |
Chengen Du |
bug task added |
|
cryptsetup (Ubuntu Noble) |
|
| 2024-02-20 08:01:41 |
Chengen Du |
nominated for series |
|
Ubuntu Focal |
|
| 2024-02-20 08:01:41 |
Chengen Du |
bug task added |
|
cryptsetup (Ubuntu Focal) |
|
| 2024-02-20 08:04:42 |
Chengen Du |
attachment added |
|
lp2054390_focal_refine_proc_mounts_entries_traversal.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5747548/+files/lp2054390_focal_refine_proc_mounts_entries_traversal.debdiff |
|
| 2024-02-20 08:06:51 |
Chengen Du |
attachment added |
|
lp2054390_jammy_refine_proc_mounts_entries_traversal.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5747549/+files/lp2054390_jammy_refine_proc_mounts_entries_traversal.debdiff |
|
| 2024-02-20 08:08:46 |
Chengen Du |
attachment added |
|
lp2054390_mantic_refine_proc_mounts_entries_traversal.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5747550/+files/lp2054390_mantic_refine_proc_mounts_entries_traversal.debdiff |
|
| 2024-02-20 08:09:49 |
Chengen Du |
attachment added |
|
lp2054390_noble_refine_proc_mounts_entries_traversal.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5747551/+files/lp2054390_noble_refine_proc_mounts_entries_traversal.debdiff |
|
| 2024-02-20 08:10:24 |
Chengen Du |
cryptsetup (Ubuntu Focal): assignee |
|
Chengen Du (chengendu) |
|
| 2024-02-20 08:10:34 |
Chengen Du |
cryptsetup (Ubuntu Jammy): assignee |
|
Chengen Du (chengendu) |
|
| 2024-02-20 08:10:40 |
Chengen Du |
cryptsetup (Ubuntu Mantic): assignee |
|
Chengen Du (chengendu) |
|
| 2024-02-20 08:10:42 |
Chengen Du |
cryptsetup (Ubuntu Noble): assignee |
|
Chengen Du (chengendu) |
|
| 2024-02-20 08:10:46 |
Chengen Du |
cryptsetup (Ubuntu Focal): status |
New |
In Progress |
|
| 2024-02-20 08:10:49 |
Chengen Du |
cryptsetup (Ubuntu Jammy): status |
New |
In Progress |
|
| 2024-02-20 08:10:52 |
Chengen Du |
cryptsetup (Ubuntu Mantic): status |
New |
In Progress |
|
| 2024-02-20 08:10:56 |
Chengen Du |
cryptsetup (Ubuntu Noble): status |
New |
In Progress |
|
| 2024-02-20 08:16:57 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2024-02-20 08:17:00 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors |
| 2024-02-20 08:27:17 |
Chengen Du |
bug |
|
|
added subscriber Support Engineering Sponsors |
| 2024-03-04 18:15:55 |
Steve Langasek |
cryptsetup (Ubuntu Noble): status |
In Progress |
Incomplete |
|
| 2024-03-14 13:15:08 |
Benjamin Drung |
removed subscriber Ubuntu Sponsors |
|
|
|
| 2024-04-03 06:49:46 |
Chengen Du |
attachment added |
|
lp2054390-focal-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761407/+files/lp2054390-focal-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff |
|
| 2024-04-03 06:51:29 |
Chengen Du |
attachment added |
|
lp2054390-jammy-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761409/+files/lp2054390-jammy-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff |
|
| 2024-04-03 06:56:21 |
Chengen Du |
attachment added |
|
lp2054390-mantic-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761410/+files/lp2054390-mantic-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff |
|
| 2024-04-03 07:01:39 |
Chengen Du |
attachment added |
|
lp2054390-noble-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bug/2054390/+attachment/5761411/+files/lp2054390-noble-d-functions-get_mnt_devno-Speed-up-execution-time-on.debdiff |
|
| 2024-04-03 07:02:14 |
Chengen Du |
cryptsetup (Ubuntu Noble): status |
Incomplete |
In Progress |
|
| 2024-04-03 07:06:45 |
Chengen Du |
bug |
|
|
added subscriber Ubuntu Sponsors |
| 2024-04-03 07:29:42 |
Chengen Du |
description |
[Impact]
When LDAP automount maps generate a substantial number of entries in /proc/mounts, it has the potential to induce a timeout issue, particularly during the process of iterating through the entries twice in the cryptroot hook.
[Fix]
Utilizing awk to initially filter out pertinent mount points results in a notable reduction in the execution time of the hook.
[Test Plan]
The patch maintains the existing logic within the hook.
Our primary objective is to ensure that the output remains consistent when obtaining devnos through iteration.
1. Execute the /usr/share/initramfs-tools/hooks/cryptroot binary
2. Confirm that the output does not include the following warning message:
cryptsetup: WARNING: Couldn't determine root device
[Where problems could occur]
The patch exclusively modifies the method of extracting information without altering the underlying hook logic.
It's crucial to note that the successful generation of the crypttab is contingent upon the accuracy of the information provided by the patch.
Any inaccuracies may impede the crypttab generation process. |
[Impact]
The shell's read builtin iterates through /proc/mounts one byte at a time. This becomes problematic when LDAP automount maps generate a large number of entries in /proc/mounts. It can lead to timeout issues, especially when iterating through the entries twice in the cryptroot hook.
[Fix]
Applying the following upstream commit can resolve this issue.
95fd4be9b4c6 d/functions: get_mnt_devno(): Speed up execution time on large /proc/mounts.
Use awk rather than a `while read; do done` loop here as the /proc/mounts
pseudo-file can be many thousands lines long and the shell's `read` builtin
traverses it one read(2) at the time which cruelly slows down execution time.
See https://salsa.debian.org/cryptsetup-team/cryptsetup/-/merge_requests/36 .
[Test Plan]
Our primary objective is to ensure that the output remains consistent when obtaining devnos through iteration.
1. Execute the /usr/share/initramfs-tools/hooks/cryptroot binary
2. Confirm that the output does not include the following warning message:
cryptsetup: WARNING: Couldn't determine root device
[Where problems could occur]
The patch exclusively modifies the method of extracting information without altering the underlying hook logic.
It's crucial to note that the successful generation of the crypttab is contingent upon the accuracy of the information provided by the patch.
Any inaccuracies may impede the crypttab generation process. |
|
| 2024-05-21 11:20:33 |
Mauricio Faria de Oliveira |
bug |
|
|
added subscriber Mauricio Faria de Oliveira |
| 2024-06-05 13:17:49 |
Mauricio Faria de Oliveira |
removed subscriber Ubuntu Sponsors |
|
|
|
| 2024-06-05 13:17:55 |
Mauricio Faria de Oliveira |
cryptsetup (Ubuntu Noble): status |
In Progress |
Incomplete |
|
| 2024-06-05 13:17:57 |
Mauricio Faria de Oliveira |
cryptsetup (Ubuntu Mantic): status |
In Progress |
Incomplete |
|
| 2024-06-05 13:17:59 |
Mauricio Faria de Oliveira |
cryptsetup (Ubuntu Jammy): status |
In Progress |
Incomplete |
|
| 2024-06-05 13:18:01 |
Mauricio Faria de Oliveira |
cryptsetup (Ubuntu Focal): status |
In Progress |
Incomplete |
|
| 2024-06-05 13:18:04 |
Mauricio Faria de Oliveira |
cryptsetup (Ubuntu): status |
In Progress |
Incomplete |
|
