Resync wireguard/wireguard-linux-compat with development

[Andy Whitcroft]

[Impact]

wireguard contains an uninitialised netlink member which could lead to unreliable operation. wireguard-linux-compat is maintained to match the upstream version which is under security review and cleanup keeping in sync with the maintainers backport provides the highest reliability and security for wireguard users.

Separately, the previous update was not built for -security but includes kernel compatibility which requires it be promoted to -security. This update has been built in the kernel security PPA and is valid for -security.

[Test Case]

Do a sanity test run using the -proposed packages and see if everything still works as expected.

[Regression Potential]

Low. This is the version in continuous and active use in the development release, it is also the version applied upstream.

[Other Info]

The upstream maintainer of this feature is only committed to support of the upstream version of the compatibility code that is contained in Ubuntu.

===

Resync our backports of wireguard and wireguard-linux-compat in eoan. wireguard userspace passes an uninitialised netlink field to the kernel which could lead to unpredictable behaviour. wireguard-linux-compat update fixes source nat handling amongst other fixes.

Note these will also want to go via the security PPA so they can be released to eoan-security. This is to ensure the previous update is available to -security only users.

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard-linux-compat into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard-linux-compat/1.0.20200401-1ubuntu1~19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard/1.0.20200319-1ubuntu1~19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

The dkms package still fails to build with the latest Eoan kernel in -proposed.

DKMS make.log for wireguard-1.0.20200401 for kernel 5.3.0-53-generic (x86_64)
Wed May 13 10:25:09 CEST 2020
make: Entering directory '/usr/src/linux-headers-5.3.0-53-generic'
  CC [M] /var/lib/dkms/wireguard/1.0.20200401/build/main.o
In file included from <command-line>:
/var/lib/dkms/wireguard/1.0.20200401/build/compat/compat.h:1029:20: error: redefinition of ‘skb_reset_redirect’
 1029 | static inline void skb_reset_redirect(struct sk_buff *skb)
      | ^~~~~~~~~~~~~~~~~~
In file included from /var/lib/dkms/wireguard/1.0.20200401/build/compat/compat.h:878,
                 from <command-line>:
./include/linux/skbuff.h:4476:20: note: previous definition of ‘skb_reset_redirect’ was here
 4476 | static inline void skb_reset_redirect(struct sk_buff *skb)
      | ^~~~~~~~~~~~~~~~~~
In file included from <command-line>:
/var/lib/dkms/wireguard/1.0.20200401/build/compat/compat.h: In function ‘skb_reset_redirect’:
/var/lib/dkms/wireguard/1.0.20200401/build/compat/compat.h:1032:2: error: implicit declaration of function ‘skb_reset_tc’; did you mean ‘skb_reserve’? [-Werror=implicit-function-declaration]
 1032 | skb_reset_tc(skb);
      | ^~~~~~~~~~~~
      | skb_reserve
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:290: /var/lib/dkms/wireguard/1.0.20200401/build/main.o] Error 1
make: *** [Makefile:1656: _module_/var/lib/dkms/wireguard/1.0.20200401/build] Error 2
make: Leaving directory '/usr/src/linux-headers-5.3.0-53-generic'

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard/1.0.20200513-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard-linux-compat into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard-linux-compat/1.0.20200506-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard/1.0.20200513-1~19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard-linux-compat into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard-linux-compat/1.0.20200506-1~19.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted wireguard-linux-compat (1.0.20200506-1~19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

wireguard-linux-compat/1.0.20200506-1~19.10.1 (s390x, ppc64el, i386, arm64, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#wireguard-linux-compat

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted wireguard (1.0.20200513-1~19.10.1) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

wireguard-linux-compat/1.0.20200506-1~19.10.1 (s390x, ppc64el, i386, arm64, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#wireguard

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Łukasz Zemczak (sil2100)]

Hello Andy, or anyone else affected,

Accepted wireguard-linux-compat into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/wireguard-linux-compat/1.0.20200506-1~19.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andy Whitcroft (apw)]

Confirmed the updated version now builds with -51 and -53 kernels (either side of the kernel ABI breakage). Confirmed the module can load and will transfer data correctly to a real VPN server.

[Launchpad Janitor (janitor)]

This bug was fixed in the package wireguard - 1.0.20200513-1~19.10.1

---------------
wireguard (1.0.20200513-1~19.10.1) eoan; urgency=medium

  * Backport latest upstream packages to eoan. (LP: #1870293)

 -- Andy Whitcroft <email address hidden> Mon, 18 May 2020 06:28:18 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package wireguard-linux-compat - 1.0.20200506-1~19.10.2

---------------
wireguard-linux-compat (1.0.20200506-1~19.10.2) eoan; urgency=medium

  * Bodge round undetectable incompatibility between -51 and -53 ABI
    in Ubuntu. (Patch by Jason A. Donenfeld <email address hidden>).

wireguard-linux-compat (1.0.20200506-1~19.10.1) eoan; urgency=medium

  * Backport latest upstream packages to eoan. (LP: #1870293)

 -- Andy Whitcroft <email address hidden> Tue, 19 May 2020 00:38:56 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for wireguard has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Andy Whitcroft (apw)]

Tested successfully on focal against a live server.

[Launchpad Janitor (janitor)]

This bug was fixed in the package wireguard - 1.0.20200513-1~20.04.1

---------------
wireguard (1.0.20200513-1~20.04.1) focal; urgency=medium

  * Backport latest upstream packages to focal. (LP: #1870293)

 -- Andy Whitcroft <email address hidden> Sun, 17 May 2020 17:38:24 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package wireguard-linux-compat - 1.0.20200506-1~20.04.1

---------------
wireguard-linux-compat (1.0.20200506-1~20.04.1) focal; urgency=medium

  * Backport latest upstream packages to focal. (LP: #1870293)

 -- Andy Whitcroft <email address hidden> Sun, 17 May 2020 17:42:36 +0100