Activity log for bug #1783597

Date Who What changed Old value New value Message
2018-07-25 15:25:25 Sebastien Bacher bug added bug
2018-07-25 15:29:42 Sebastien Bacher tags rls-bb-incoming
2018-07-25 21:07:56 Will Cooke bug added subscriber Will Cooke
2018-08-01 12:35:55 Francis Ginther tags rls-bb-incoming id-5b5b80eb89d784de8e6deacd rls-bb-incoming
2018-08-01 22:49:26 Brian Murray ubuntu-release-upgrader (Ubuntu): status New Triaged
2018-08-01 22:49:29 Brian Murray ubuntu-release-upgrader (Ubuntu): importance Undecided Medium
2018-08-01 22:49:40 Brian Murray tags id-5b5b80eb89d784de8e6deacd rls-bb-incoming id-5b5b80eb89d784de8e6deacd rls-cc-incoming
2019-05-17 20:46:10 Brian Murray tags id-5b5b80eb89d784de8e6deacd rls-cc-incoming id-5b5b80eb89d784de8e6deacd rls-ee-incoming
2019-06-20 15:56:57 Brian Murray tags id-5b5b80eb89d784de8e6deacd rls-ee-incoming rls-ee-incoming
2019-06-20 15:57:05 Brian Murray nominated for series Ubuntu Eoan
2019-06-20 15:57:05 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Eoan)
2019-06-21 12:25:48 Francis Ginther tags rls-ee-incoming id-5d0baca7c9fcc35d33039355 rls-ee-incoming
2019-06-24 06:17:04 Steve Langasek description Looking at the code change recently made to install snaps on upgade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders
2019-07-31 15:21:17 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Eoan): status Triaged In Progress
2019-07-31 15:21:19 Łukasz Zemczak ubuntu-release-upgrader (Ubuntu Eoan): assignee Łukasz Zemczak (sil2100)
2019-08-09 13:19:34 Łukasz Zemczak branch linked lp:~sil2100/ubuntu-release-upgrader/snap-size-estimation
2019-08-13 20:42:23 Brian Murray tags id-5d0baca7c9fcc35d33039355 rls-ee-incoming id-5d0baca7c9fcc35d33039355
2019-08-28 17:12:05 Brian Murray nominated for series Ubuntu Disco
2019-08-28 17:12:05 Brian Murray bug task added ubuntu-release-upgrader (Ubuntu Disco)
2019-08-28 17:12:13 Brian Murray ubuntu-release-upgrader (Ubuntu Disco): status New Triaged
2019-08-28 17:12:17 Brian Murray ubuntu-release-upgrader (Ubuntu Disco): importance Undecided Medium
2019-09-04 14:58:26 Łukasz Zemczak description Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders [Impact] Since there have been reports that users might fail to boot to a working gdm in the case of a full disk, we need to make sure users upgrading from and older release to disco/eoan have enough space for the upgrade to succeed. Currently we are installing snaps to replace certain debs on the system (+ refreshing existing snaps to newer channels/branches). The additional size required for the snap replacements was not taken into consideration when performing the upgrade, which might lead to edge-cases of users not having enough space for the upgrade to succeed. [Test Case] TODO [Regression Potential] As with any change touching the upgrade code-path, this change also carries a risk and should be well tested before going forward. That being said, the fix has been specifically basically limited to DistUpgradeQuirks to make regressions less likely. Additionally, unit tests have been added for every modified code-path. If any regressions should be found, the most likely place for those would be in size estimation, causing users to get notified of lack of space when they shouldn't. Another possible location would be all the things regarding replacing the debs with snaps - so either failures in snap replacement installation or refreshing. [Original Description] Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders
2019-09-04 16:22:53 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Eoan): status In Progress Fix Released
2019-09-05 09:45:57 Łukasz Zemczak description [Impact] Since there have been reports that users might fail to boot to a working gdm in the case of a full disk, we need to make sure users upgrading from and older release to disco/eoan have enough space for the upgrade to succeed. Currently we are installing snaps to replace certain debs on the system (+ refreshing existing snaps to newer channels/branches). The additional size required for the snap replacements was not taken into consideration when performing the upgrade, which might lead to edge-cases of users not having enough space for the upgrade to succeed. [Test Case] TODO [Regression Potential] As with any change touching the upgrade code-path, this change also carries a risk and should be well tested before going forward. That being said, the fix has been specifically basically limited to DistUpgradeQuirks to make regressions less likely. Additionally, unit tests have been added for every modified code-path. If any regressions should be found, the most likely place for those would be in size estimation, causing users to get notified of lack of space when they shouldn't. Another possible location would be all the things regarding replacing the debs with snaps - so either failures in snap replacement installation or refreshing. [Original Description] Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders [Impact] Since there have been reports that users might fail to boot to a working gdm in the case of a full disk, we need to make sure users upgrading from and older release to disco/eoan have enough space for the upgrade to succeed. Currently we are installing snaps to replace certain debs on the system (+ refreshing existing snaps to newer channels/branches). The additional size required for the snap replacements was not taken into consideration when performing the upgrade, which might lead to edge-cases of users not having enough space for the upgrade to succeed. [Test Case] * Prepare a bionic machine * Make sure ubuntu-desktop and snapd are installed on it * Install core18 from stable and, for instance, gnome-characters from the stable/ubuntu-18.04 branch * Do snap list and snap refresh other gnome-related snaps to stable/ubuntu-18.04 * Perform an upgrade to disco (with the --proposed option, to use disco-proposed) * Reboot * Make sure the update succeeded and all the installed gnome snaps now track stable/ubuntu-19.04 instead * Check /var/log/dist-upgrade/main.log and see if '/var' is listed in the calculated required space print-out [Regression Potential] As with any change touching the upgrade code-path, this change also carries a risk and should be well tested before going forward. That being said, the fix has been specifically basically limited to DistUpgradeQuirks to make regressions less likely. Additionally, unit tests have been added for every modified code-path. If any regressions should be found, the most likely place for those would be in size estimation, causing users to get notified of lack of space when they shouldn't. Another possible location would be all the things regarding replacing the debs with snaps - so either failures in snap replacement installation or refreshing. [Original Description] Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders
2019-09-09 12:12:12 Kiwinote bug added subscriber Kiwinote
2019-09-11 12:45:01 Łukasz Zemczak description [Impact] Since there have been reports that users might fail to boot to a working gdm in the case of a full disk, we need to make sure users upgrading from and older release to disco/eoan have enough space for the upgrade to succeed. Currently we are installing snaps to replace certain debs on the system (+ refreshing existing snaps to newer channels/branches). The additional size required for the snap replacements was not taken into consideration when performing the upgrade, which might lead to edge-cases of users not having enough space for the upgrade to succeed. [Test Case] * Prepare a bionic machine * Make sure ubuntu-desktop and snapd are installed on it * Install core18 from stable and, for instance, gnome-characters from the stable/ubuntu-18.04 branch * Do snap list and snap refresh other gnome-related snaps to stable/ubuntu-18.04 * Perform an upgrade to disco (with the --proposed option, to use disco-proposed) * Reboot * Make sure the update succeeded and all the installed gnome snaps now track stable/ubuntu-19.04 instead * Check /var/log/dist-upgrade/main.log and see if '/var' is listed in the calculated required space print-out [Regression Potential] As with any change touching the upgrade code-path, this change also carries a risk and should be well tested before going forward. That being said, the fix has been specifically basically limited to DistUpgradeQuirks to make regressions less likely. Additionally, unit tests have been added for every modified code-path. If any regressions should be found, the most likely place for those would be in size estimation, causing users to get notified of lack of space when they shouldn't. Another possible location would be all the things regarding replacing the debs with snaps - so either failures in snap replacement installation or refreshing. [Original Description] Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders [Impact] Since there have been reports that users might fail to boot to a working gdm in the case of a full disk, we need to make sure users upgrading from and older release to disco/eoan have enough space for the upgrade to succeed. Currently we are installing snaps to replace certain debs on the system (+ refreshing existing snaps to newer channels/branches). The additional size required for the snap replacements was not taken into consideration when performing the upgrade, which might lead to edge-cases of users not having enough space for the upgrade to succeed. [Test Case] * Prepare a bionic machine * Make sure ubuntu-desktop and snapd are installed on it * Install core18 from stable and, for instance, gnome-characters from the stable/ubuntu-18.04 branch * Do snap list and snap refresh other gnome-related snaps to stable/ubuntu-18.04 * Perform an upgrade to disco (with the --proposed option, to use disco-proposed) * Reboot * Make sure the update succeeded and all the installed gnome snaps now track stable/ubuntu-19.04 instead * Check /var/log/dist-upgrade/main.log and see if '/var' is listed in the calculated required space print-out Additional test case to make sure update-manager did not regress due to the changes: * On the newly upgraded system (or a new disco instance with ubuntu-release-upgrader upgraded to the version in disco-proposed), downgrade any of the installed packages * On the terminal, run `update-manager` and wait for the window to appear * Once the list of available upgrades appears, press the 'install now' button * Upgrades should install and no python traceback should be printed on the terminal [Regression Potential] As with any change touching the upgrade code-path, this change also carries a risk and should be well tested before going forward. That being said, the fix has been specifically basically limited to DistUpgradeQuirks to make regressions less likely. Additionally, unit tests have been added for every modified code-path. If any regressions should be found, the most likely place for those would be in size estimation, causing users to get notified of lack of space when they shouldn't. Another possible location would be all the things regarding replacing the debs with snaps - so either failures in snap replacement installation or refreshing. [Original Description] Looking at the code change recently made to install snaps on upgrade, it seems like there was no change made to the disk-space-estimate code. We had some reports recently that bionic might fail to boot to a working gdm on full disk so that could potentially be an important issue for upgraders
2019-09-30 17:00:38 Brian Murray ubuntu-release-upgrader (Ubuntu Disco): status Triaged Fix Committed
2019-09-30 17:00:41 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2019-09-30 17:00:45 Brian Murray bug added subscriber SRU Verification
2019-09-30 17:00:50 Brian Murray tags id-5d0baca7c9fcc35d33039355 id-5d0baca7c9fcc35d33039355 verification-needed verification-needed-disco
2019-10-08 19:32:53 Brian Murray bug added subscriber Brian Murray
2019-10-08 19:32:57 Brian Murray tags id-5d0baca7c9fcc35d33039355 verification-needed verification-needed-disco id-5d0baca7c9fcc35d33039355 verification-failed-disco verification-needed verification-needed-disco
2019-10-09 14:10:51 Łukasz Zemczak tags id-5d0baca7c9fcc35d33039355 verification-failed-disco verification-needed verification-needed-disco id-5d0baca7c9fcc35d33039355 verification-done verification-done-disco verification-failed-disco
2019-10-09 17:18:14 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Disco): status Fix Committed Fix Released
2019-10-09 17:18:26 Brian Murray removed subscriber Ubuntu Stable Release Updates Team