python-pysaml2 ftbfs in 18.04 LTS

[Matthias Klose]

according to
http://people.canonical.com/~doko/ftbfs-report/test-rebuild-20181222-bionic.html

python-pysaml2 ftbfs.

=================================== FAILURES ===================================
_________________________ TestResponse.test_false_sign _________________________

self = <test_41_response.TestResponse instance at 0x7f6a28a4cea8>

    def test_false_sign(self):
        xml_response = open(FALSE_ASSERT_SIGNED).read()
        resp = response_factory(
            xml_response, self.conf,
            return_addrs=["http://lingon.catalogix.se:8087/"],
            outstanding_queries={
                "bahigehogffohiphlfmplepdpcohkhhmheppcdie":
                    "http://localhost:8088/sso"},
            timeslack=TIMESLACK, decode=False)

        assert isinstance(resp, StatusResponse)
        assert isinstance(resp, AuthnResponse)
        try:
> resp.verify()

tests/test_41_response.py:109:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/saml2/response.py:993: in verify
    res = self._verify()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <saml2.response.AuthnResponse object at 0x7f6a256ce110>

    def _verify(self):
        if self.request_id and self.in_response_to and \
                        self.in_response_to != self.request_id:
            logger.error("Not the id I expected: %s != %s",
                         self.in_response_to, self.request_id)
            return None

        try:
            assert self.response.version == "2.0"
        except AssertionError:
            _ver = float(self.response.version)
            if _ver < 2.0:
                raise RequestVersionTooLow()
            else:
                raise RequestVersionTooHigh()

        if self.asynchop:
            if self.response.destination and \
                            self.response.destination not in self.return_addrs:
                logger.error("%s not in %s", self.response.destination,
                             self.return_addrs)
                return None

> assert self.issue_instant_ok()
E AssertionError

src/saml2/response.py:405: AssertionError
----------------------------- Captured stderr call -----------------------------
response.py 995 ERROR Verification error on the response:
------------------------------ Captured log call -------------------------------
response.py 995 ERROR Verification error on the response:
=============================== warnings summary ===============================
None
  [pytest] section in setup.cfg files is deprecated, use [tool:pytest] instead.

tests
  pytest_funcarg__AVA: declaring fixtures using "pytest_funcarg__" prefix is deprecated and scheduled to be removed in pytest 4.0. Please remove the prefix and use the @pytest.fixture decorator instead.
  pytest_funcarg__xmlsec: declaring fixtures using "pytest_funcarg__" prefix is deprecated and scheduled to be removed in pytest 4.0. Please remove the prefix and use the @pytest.fixture decorator instead.

-- Docs: http://doc.pytest.org/en/latest/warnings.html
======== 1 failed, 561 passed, 5 skipped, 3 warnings in 167.69 seconds =========
debian/rules:35: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:13: recipe for target 'build' failed
make: *** [build] Error 2

[Matthias Klose (doko)]

also ftbfs in disco:
https://launchpadlibrarian.net/417924498/buildlog_ubuntu-disco-amd64.python-pysaml2_4.5.0+dfsg1-0ubuntu2_BUILDING.txt.gz

[Matthias Klose (doko)]

also ftbfs in cosmic:
https://launchpadlibrarian.net/418305080/buildlog_ubuntu-cosmic-amd64.python-pysaml2_4.5.0+dfsg1-0ubuntu2_BUILDING.txt.gz

[Matthias Klose (doko)]

same in eoan

[James Page (james-page)]

Resolved by security team as part of a set of security updates.