Kernel Oops - general protection fault: 0000 [#1] SMP PTI after disconnecting thunderbolt docking station
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Medium
|
Andrea Righi | ||
Eoan |
Fix Released
|
Medium
|
Andrea Righi | ||
Focal |
Fix Released
|
Medium
|
Andrea Righi | ||
linux-signed-hwe (Ubuntu) |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Disconnecting a thunderbolt docking station on a Dell Inc. XPS 13 9360/0D4J15 can cause a general protection fault (with kernel 5.3.0-40 and above).
The bug has been introduced by this upstream commit:
ffe3bcaf02c4 ptp: fix the race between the release of ptp_clock and cdev
Reverting the commit is not a viable option, because we would re-introduce another bug.
The proper fix is to do something similar to this:
75718584cb3c6
and call pps_unregister_
[Test case]
Bug reported provided the test case by physically disconnecting the docking station. The problems can be easily reproduced and it doesn't seem to happen anymore with the fix applied.
[Fix]
Call call pps_unregister_
[Regression potential]
Minimal regression potential, the change is limited to the ptp clock unregistering code path.
[Original report]
happens each time on kernel 5.3.0-40 when I disconnect thunderbolt docking station.
Does *not* happen on 5.3.0-28.
After it happens almost everything still works ok: the only malfunction I've noticed is that after reconnecting the dock, USB devices (mouse, keyboard) connected via the dock don't work at all. However monitor connected via the dock still works fine.
Hardware essentials:
Dell Inc. XPS 13 9360/0D4J15, BIOS 2.13.0
Plugable TBT3-UDV Docking Station
Does not happen when disconnecting "simpler" devices like apple's usb-c to hdmi/usb/usb-c adapter.
ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: linux-image-
ProcVersionSign
Uname: Linux 5.3.0-40-generic x86_64
ApportVersion: 2.20.9-0ubuntu7.11
Architecture: amd64
Date: Wed Feb 26 05:23:00 2020
InstallationDate: Installed on 2020-01-01 (55 days ago)
InstallationMedia: Ubuntu-MATE 18.04.3 LTS "Bionic Beaver" - Release amd64 (20190805)
ProcEnviron:
LANGUAGE=en_IE:en
TERM=xterm
PATH=(custom, no user)
LANG=en_IE.UTF-8
SHELL=/bin/bash
SourcePackage: linux-signed-hwe
UpgradeStatus: No upgrade log present (probably fresh install)
CVE References
description: | updated |
Changed in linux-signed-hwe (Ubuntu Bionic): | |
importance: | Undecided → High |
assignee: | nobody → Andrea Righi (arighi) |
Changed in linux-signed-hwe (Ubuntu Focal): | |
importance: | Medium → High |
description: | updated |
Changed in linux-signed-hwe (Ubuntu Focal): | |
status: | New → Fix Committed |
Changed in linux (Ubuntu Focal): | |
status: | New → Fix Committed |
no longer affects: | linux-signed-hwe (Ubuntu) |
Changed in linux (Ubuntu Eoan): | |
status: | New → Fix Committed |
no longer affects: | linux (Ubuntu Bionic) |
no longer affects: | linux-signed-hwe (Ubuntu Bionic) |
no longer affects: | linux-signed-hwe (Ubuntu Eoan) |
no longer affects: | linux-signed-hwe (Ubuntu Focal) |
Changed in linux (Ubuntu Eoan): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Focal): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Eoan): | |
assignee: | nobody → Andrea Righi (arighi) |
Changed in linux (Ubuntu Focal): | |
assignee: | nobody → Andrea Righi (arighi) |
Changed in linux-signed-hwe (Ubuntu): | |
status: | New → Fix Committed |
I'm wondering if this commit introduced this issue:
ffe3bcaf02c4 ptp: fix the race between the release of ptp_clock and cdev
Can you do a test with the following kernel and check if it fixes the problem?
https:/ /kernel. ubuntu. com/~arighi/ lp1864754/
Thanks!