Activity log for bug #1833935

Date Who What changed Old value New value Message
2019-06-24 07:26:53 Po-Hsu Lin bug added bug
2019-06-24 07:27:10 Po-Hsu Lin bug task added ubuntu-kernel-tests
2019-06-24 07:27:23 Po-Hsu Lin tags amd64 apport-bug cosmic package-from-proposed uec-images amd64 apport-bug cosmic package-from-proposed sru-20190603 ubuntu-ltp uec-images
2019-06-24 09:21:38 Po-Hsu Lin tags amd64 apport-bug cosmic package-from-proposed sru-20190603 ubuntu-ltp uec-images amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images
2019-06-25 09:09:12 Po-Hsu Lin bug task added linux (Ubuntu)
2019-06-25 09:09:20 Po-Hsu Lin summary sysctl02_sh from ubuntu_ltp failed on KVM kernels because AppArmor enabled sysctl02_sh from ubuntu_ltp failed
2019-06-25 09:12:03 Po-Hsu Lin summary sysctl02_sh from ubuntu_ltp failed sysctl02_sh from ubuntu_ltp failed with Cosmic kernel
2019-06-25 09:12:14 Po-Hsu Lin nominated for series Ubuntu Cosmic
2019-06-25 09:12:14 Po-Hsu Lin bug task added linux (Ubuntu Cosmic)
2019-06-25 09:12:14 Po-Hsu Lin bug task added linux-kvm (Ubuntu Cosmic)
2019-06-25 09:30:08 Ubuntu Kernel Bot linux (Ubuntu): status New Incomplete
2019-06-25 09:30:10 Ubuntu Kernel Bot linux (Ubuntu Cosmic): status New Incomplete
2019-06-26 10:10:53 Po-Hsu Lin ubuntu-kernel-tests: assignee Po-Hsu Lin (cypressyew)
2019-06-26 10:10:55 Po-Hsu Lin ubuntu-kernel-tests: status New In Progress
2019-06-27 11:31:34 Po-Hsu Lin summary sysctl02_sh from ubuntu_ltp failed with Cosmic kernel Handle overflow in proc_get_long of sysctl
2019-06-28 07:36:52 Po-Hsu Lin description Test complains about apparmor enabled. As it's enabled by default, I think we might need to disable this test. Furthermore, this test will need kallsyms to be enabled, which is not for KVM kernels. <<<test_start>>> tag=sysctl02_sh stime=1561360893 cmdline="sysctl02.sh" contacts="" analysis=exit <<<test_output>>> incrementing stop sysctl02 1 TINFO: timeout per run is 0h 5m 0s sysctl02 1 TFAIL: /proc/sys/fs/file-max overflows and set to 0 sysctl02 2 TFAIL: /proc/sys/fs/file-max overflows and set to 18446744073709551615 sysctl02 3 TFAIL: /proc/sys/fs/file-max overflows and set to 9223372036854775808 sysctl02 4 TCONF: /proc/kallsyms not enabled sysctl02 4 TINFO: AppArmor enabled, this may affect test results sysctl02 4 TINFO: You can try to disable it with TST_DISABLE_APPARMOR=1 (requires super/root) sysctl02 4 TINFO: loaded AppArmor profiles: none Summary: passed 0 failed 3 skipped 1 warnings 0 <<<execution_status>>> initiation_status="ok" duration=0 termination_type=exited termination_id=33 corefile=no cutime=2 cstime=1 <<<test_end>>> ProblemType: Bug DistroRelease: Ubuntu 18.10 Package: linux-image-4.18.0-1015-kvm 4.18.0-1015.15 ProcVersionSignature: User Name 4.18.0-1015.15-kvm 4.18.20 Uname: Linux 4.18.0-1015-kvm x86_64 ApportVersion: 2.20.10-0ubuntu13.3 Architecture: amd64 Date: Mon Jun 24 07:21:41 2019 SourcePackage: linux-kvm UpgradeStatus: No upgrade log present (probably fresh install) == SRU Justification == With the upper / lower boundary confined in bug 1834310, the file-max is still suffering with overflow issue. This is because the simple_strtoul() used in proc_get_long() to parse user input explicitly ignores overflows. So when you tried to put 2^64 into file-max, it will: # echo 18446744073709551616 > /proc/sys/fs/file-max # cat /proc/sys/fs/file-max 0 Which will cause your system to silently die behind your back. This issue was reported by the case 1 of the sysctl02 test in LTP: sysctl02 1 TFAIL: /proc/sys/fs/file-max overflows and set to 0 == Fix == * 7f2923c4 (sysctl: handle overflow in proc_get_long) A new strtoul_lenient() was introduced here to solve this issue, with extra check to notify userspace with -EINVAL. This patch can be cherry-picked into B/C/D/E, it needs some content adjustment for X. == Test == Test kernels could be found here: https://people.canonical.com/~phlin/kernel/lp-1833935-proc_get_long/ The attempt to set file-max to 2^64 will be rejected: $ sudo sysctl -w -q fs.file-max=18446744073709551616 sysctl: setting key "fs.file-max": Invalid argument Tested and passed with these kernels on AMD64 KVM nodes. == Regression Potential == Low, the newly introduced function strtoul_lenient() is just for proc_get_long here. == Original bug report == Test complains about apparmor enabled. As it's enabled by default, I think we might need to disable this test. Furthermore, this test will need kallsyms to be enabled, which is not for KVM kernels. <<<test_start>>> tag=sysctl02_sh stime=1561360893 cmdline="sysctl02.sh" contacts="" analysis=exit <<<test_output>>> incrementing stop sysctl02 1 TINFO: timeout per run is 0h 5m 0s sysctl02 1 TFAIL: /proc/sys/fs/file-max overflows and set to 0 sysctl02 2 TFAIL: /proc/sys/fs/file-max overflows and set to 18446744073709551615 sysctl02 3 TFAIL: /proc/sys/fs/file-max overflows and set to 9223372036854775808 sysctl02 4 TCONF: /proc/kallsyms not enabled sysctl02 4 TINFO: AppArmor enabled, this may affect test results sysctl02 4 TINFO: You can try to disable it with TST_DISABLE_APPARMOR=1 (requires super/root) sysctl02 4 TINFO: loaded AppArmor profiles: none Summary: passed 0 failed 3 skipped 1 warnings 0 <<<execution_status>>> initiation_status="ok" duration=0 termination_type=exited termination_id=33 corefile=no cutime=2 cstime=1 <<<test_end>>> ProblemType: Bug DistroRelease: Ubuntu 18.10 Package: linux-image-4.18.0-1015-kvm 4.18.0-1015.15 ProcVersionSignature: User Name 4.18.0-1015.15-kvm 4.18.20 Uname: Linux 4.18.0-1015-kvm x86_64 ApportVersion: 2.20.10-0ubuntu13.3 Architecture: amd64 Date: Mon Jun 24 07:21:41 2019 SourcePackage: linux-kvm UpgradeStatus: No upgrade log present (probably fresh install)
2019-06-28 07:44:08 Po-Hsu Lin nominated for series Ubuntu Xenial
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux (Ubuntu Xenial)
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux-kvm (Ubuntu Xenial)
2019-06-28 07:44:08 Po-Hsu Lin nominated for series Ubuntu Eoan
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux (Ubuntu Eoan)
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux-kvm (Ubuntu Eoan)
2019-06-28 07:44:08 Po-Hsu Lin nominated for series Ubuntu Disco
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux (Ubuntu Disco)
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux-kvm (Ubuntu Disco)
2019-06-28 07:44:08 Po-Hsu Lin nominated for series Ubuntu Bionic
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux (Ubuntu Bionic)
2019-06-28 07:44:08 Po-Hsu Lin bug task added linux-kvm (Ubuntu Bionic)
2019-06-28 07:44:15 Po-Hsu Lin bug task deleted linux-kvm (Ubuntu)
2019-06-28 07:44:22 Po-Hsu Lin bug task deleted linux-kvm (Ubuntu Xenial)
2019-06-28 07:44:30 Po-Hsu Lin bug task deleted linux-kvm (Ubuntu Cosmic)
2019-06-28 07:44:45 Po-Hsu Lin linux (Ubuntu Xenial): status New In Progress
2019-06-28 07:44:45 Po-Hsu Lin linux (Ubuntu Xenial): assignee Po-Hsu Lin (cypressyew)
2019-06-28 07:44:58 Po-Hsu Lin linux (Ubuntu Bionic): status New In Progress
2019-06-28 07:44:58 Po-Hsu Lin linux (Ubuntu Bionic): assignee Po-Hsu Lin (cypressyew)
2019-06-28 07:45:09 Po-Hsu Lin bug task deleted linux-kvm (Ubuntu Bionic)
2019-06-28 07:45:20 Po-Hsu Lin bug task deleted linux-kvm (Ubuntu Disco)
2019-06-28 07:45:22 Po-Hsu Lin bug task deleted linux-kvm (Ubuntu Eoan)
2019-06-28 07:45:35 Po-Hsu Lin linux (Ubuntu Cosmic): status Incomplete In Progress
2019-06-28 07:45:38 Po-Hsu Lin linux (Ubuntu Cosmic): assignee Po-Hsu Lin (cypressyew)
2019-06-28 07:45:40 Po-Hsu Lin linux (Ubuntu Disco): assignee Po-Hsu Lin (cypressyew)
2019-06-28 07:45:43 Po-Hsu Lin linux (Ubuntu Disco): status New In Progress
2019-06-28 07:45:45 Po-Hsu Lin linux (Ubuntu Eoan): assignee Po-Hsu Lin (cypressyew)
2019-06-28 07:45:50 Po-Hsu Lin linux (Ubuntu Eoan): status Incomplete In Progress
2019-07-01 13:06:30 Kleber Sacilotto de Souza linux (Ubuntu Cosmic): status In Progress Fix Committed
2019-07-01 13:06:40 Kleber Sacilotto de Souza linux (Ubuntu Disco): status In Progress Fix Committed
2019-07-01 13:06:45 Kleber Sacilotto de Souza linux (Ubuntu Xenial): status In Progress Fix Committed
2019-07-01 13:07:21 Kleber Sacilotto de Souza linux (Ubuntu Bionic): status In Progress Fix Committed
2019-07-03 11:01:55 Ubuntu Kernel Bot tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-disco
2019-07-03 11:05:34 Ubuntu Kernel Bot tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-disco amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-disco verification-needed-xenial
2019-07-03 13:03:33 Ubuntu Kernel Bot tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-disco verification-needed-xenial amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-cosmic verification-needed-disco verification-needed-xenial
2019-07-03 13:07:03 Ubuntu Kernel Bot tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-cosmic verification-needed-disco verification-needed-xenial amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-bionic verification-needed-cosmic verification-needed-disco verification-needed-xenial
2019-07-22 07:47:14 Po-Hsu Lin tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-needed-bionic verification-needed-cosmic verification-needed-disco verification-needed-xenial amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-disco verification-needed-bionic verification-needed-cosmic verification-needed-xenial
2019-07-22 07:49:20 Po-Hsu Lin tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-disco verification-needed-bionic verification-needed-cosmic verification-needed-xenial amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-bionic verification-done-disco verification-needed-cosmic verification-needed-xenial
2019-07-22 09:07:39 Po-Hsu Lin tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-bionic verification-done-disco verification-needed-cosmic verification-needed-xenial amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-bionic verification-done-disco verification-done-xenial verification-needed-cosmic
2019-07-22 09:08:16 Po-Hsu Lin linux (Ubuntu Eoan): status In Progress Fix Released
2019-07-22 09:08:21 Po-Hsu Lin ubuntu-kernel-tests: status In Progress Fix Released
2019-07-22 09:09:34 Po-Hsu Lin tags amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-bionic verification-done-disco verification-done-xenial verification-needed-cosmic amd64 apport-bug cosmic linux-kvm package-from-proposed sru-20190603 ubuntu-ltp uec-images verification-done-bionic verification-done-cosmic verification-done-disco verification-done-xenial
2019-07-22 10:53:34 Launchpad Janitor linux (Ubuntu Bionic): status Fix Committed Fix Released
2019-07-22 10:53:34 Launchpad Janitor cve linked 2018-12126
2019-07-22 10:53:34 Launchpad Janitor cve linked 2018-12127
2019-07-22 10:53:34 Launchpad Janitor cve linked 2018-12130
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11085
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11091
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11815
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11833
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11884
2019-07-23 05:25:24 Launchpad Janitor linux (Ubuntu Disco): status Fix Committed Fix Released
2019-07-24 20:29:02 Launchpad Janitor linux (Ubuntu Xenial): status Fix Committed Fix Released
2019-07-24 20:29:02 Launchpad Janitor cve linked 2019-2054
2021-03-12 09:19:54 Po-Hsu Lin linux (Ubuntu Cosmic): status Fix Committed Won't Fix