Comment 21 for bug 1824981

Hi Christoph, thank you very much for your work in this LP! Both the debug part and finally your patch. I was looking the same set of issues in parallel, with another user that reported the same crashes.

So, regarding your question in comment #15 ("are those gonna be backportet to 4.x-generic?"), I've just nominated this LP for all series with kernels 4.15+, given we had no reports for previous series. That said, we're going to backport your patch as soon some more validation tests are finished. I'm planning to use this LP only for the strcat issue.

There's another LP for the smb2_push_mandatory_locks() crash: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1795659

I suggest you to add yourself in that bug, so we can follow-up the discussion there regarding this 2nd crash. There's a candidate patch for the smb2_push_mandatory_locks() issue, you already mentioned it here: b98749cac4a ("CIFS: keep FileInfo handle live during oplock break").

It's unfortunate that you said testing v5.1-rc7 didn't fix that crash - I've discussed this smb2_push_mandatory_locks() crash with Steve and Pavel (from Microsoft) in a private thread and they suggested me exactly this patch in order to fix the issue.

Could you test the kernel https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.2-rc1/ (which includes your strcat patch) and see if it still reproduces the smb2_push_mandatory_locks() crash?
Would be really helpful for us. You can comment the testing in the other LP (# 1795659), if possible.

Cheers,

Guilherme