USB ports not working on the Pi 4 rev 1.4 board

[Dave Jones]

[Impact]

USB on the Pi 4B rev 1.4 running the raspi 5.3 kernel is non-functional.

[Test Case]

See original description below.

[Regression Potential]

Low. The changes are isolated to the PCIe driver used for the Raspberry Pi. The commit is a clean cherry-pick from the raspi 5.4 kernel.

[Original Description]

On the Pi 4 board revision 1.4 (of which the 8Gb model is currently the main example), the VL805 USB controller doesn't appear to be recognized by the 5.3 kernel. To reproduce:

* Flash a current bionic image (e.g. http://cdimage.ubuntu.com/releases/bionic/release/ubuntu-18.04.4-preinstalled-server-arm64+raspi4.img.xz)
* Boot the card on an older Pi model (3, 4 rev 1.2, etc.)
* sudo add-apt-repository ppa:waveform/firmware
* sudo apt install linux-firmware-raspi2 (the rev 1.4 requires a newer firmware package to boot; this PPA contains a test package with a back-ported firmware)
* Boot the card on a Pi 4 rev 1.4
* Observe USB2 and USB3 ports do not work
* Boot the card on an older Pi 4 rev 1.2
* Observe USB2 and USB3 ports do work

[Hui Wang (hui.wang)]

Looks like we need to backport patches from branch rpi-5.4.x to ubuntu rpi eoan kernel.

[Juerg Haefliger (juergh)]

The Bionic 5.3 kernel is the backport of the Eoan kernel so this needs fixing in Eoan and then the fix trickles down to Bionic. However, the point release kernel for classic will be the 5.4 backport from Focal. Core stays on 5.3 for now due to DTB/kernel upgrade issues.

[Kleber Sacilotto de Souza (kleber-souza)]

As Eoan has EOL'ed, I am applying the fix directly to bionic/linux-raspi2-5.3 and will re-spin it.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-raspi2-5.3 - 5.3.0-1030.32~18.04.2

---------------
linux-raspi2-5.3 (5.3.0-1030.32~18.04.2) bionic; urgency=medium

  * bionic/linux-raspi2-5.3: 5.3.0-1030.32~18.04.2 -proposed tracker
    (LP: #1888809)

  * USB ports not working on the Pi 4 rev 1.4 board (LP: #1887156)
    - usb: xhci: Raspberry Pi FW loader for VIA VL805

linux-raspi2-5.3 (5.3.0-1030.32~18.04.1) bionic; urgency=medium

  * bionic/linux-raspi2-5.3: 5.3.0-1030.32~18.04.1 -proposed tracker
    (LP: #1887071)

  [ Ubuntu: 5.3.0-1030.32 ]

  * eoan/linux-raspi2: 5.3.0-1030.32 -proposed tracker (LP: #1887072)
  * eoan/linux: 5.3.0-64.58 -proposed tracker (LP: #1887088)
  * linux 4.15.0-109-generic network DoS regression vs -108 (LP: #1886668)
    - SAUCE: Revert "netprio_cgroup: Fix unlimited memory leak of v2 cgroups"

linux-raspi2-5.3 (5.3.0-1029.31~18.04.1) bionic; urgency=medium

  * bionic/linux-raspi2-5.3: 5.3.0-1029.31~18.04.1 -proposed tracker
    (LP: #1885477)

  [ Ubuntu: 5.3.0-1029.31 ]

  * eoan/linux-raspi2: 5.3.0-1029.31 -proposed tracker (LP: #1885478)
  * CONFIG_DRＭ_V3D is disabled for linux-raspi2 of eoan (LP: #1850876)
    - media: bcm2835-unicam: Add support for raw14 formats
    - media: bcm2835-unicam: Rework to not cache the list of active fmts
    - media: bcm2835-unicam: Support unpacking CSI format to 16bpp
    - media: bcm2835-unicam: Add support for luma/greyscale formats
    - drm/vc4: Add support for YUV color encodings and ranges
    - drm/vc4: Add support for H & V flips
    - drm/vc4: Correct handling of rotation parameter in fkms
    - configs: Add CONFIG_WIZNET_W5100=m and _SPI=m
    - overlays: Add w5500 overlay
    - bcm2711: Retain support for old dtbs
    - media: bcm2835-unicam: Replace hard coded loop limit with a define
    - media: bcm2835-unicam: Fix one-to-many mapping for YUYV formats
    - dt-bindings: Add binding for the Infineon IRS1125 sensor
    - media: i2c: Add a driver for the Infineon IRS1125 depth sensor
    - configs: Add CONFIG_VIDEO_IRS1125 to the defconfigs
    - dtoverlays: Add an overlay for the Infineon IRS1125
    - rpi-wm8804-soundcard: Fixed MCLKDIV for Allo Digione
    - dts: bcm2838: Disable DWC OTG block by default
    - staging:bcm2835-codec: Add support for ENUM_FRAMESIZES
    - staging: bcm2835-codec: Correct buffer type check on G_PARM
    - staging: bcm2835-codec: Set default and error check timeperframe
    - staging: bcm2835-codec: Fix imbalance in dma_buf_get/dma_buf_put
    - drm:vc4 Added calls for firmware display blank/unblank
    - configs: Add CGROUP_BPF and BPF_SYSCALL
    - drm/v3d: Don't clear MMU control bits on exception
    - v3d_drv: Handle missing clock more gracefully
    - v3d_drv: Allow clock retrieval by name
    - v3d_gem: Kick the clock so firmware knows we are using firmware clock
      interface
    - clk-raspberrypi: Allow cpufreq driver to also adjust gpu clocks
    - clk-raspberrypi: Also support v3d clock
    - clk-bcm2835: Disable v3d clock
    - config: Switch to upstream cpufreq driver
    - raspberrypi-cpufreq: Only report integer pll divisor frequencies
    - drm/v3d: drop use of drmP.h
    - drm/v3d: Suppress all but the first MMU ...

[Brian Murray (brian-murray)]

The Eoan Ermine has reached end of life, so this bug will not be fixed for that release

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.