/etc/grub.d/10_linux_zfs gives up if any checked /etc/fstab entry is invalid
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
grub2 (Ubuntu) |
Fix Released
|
High
|
Jean-Baptiste Lallement | ||
Eoan |
Won't Fix
|
High
|
Jean-Baptiste Lallement | ||
Focal |
Fix Released
|
High
|
Jean-Baptiste Lallement | ||
grubzfs-testsuite (Ubuntu) |
Fix Released
|
High
|
Jean-Baptiste Lallement | ||
Eoan |
Won't Fix
|
High
|
Jean-Baptiste Lallement | ||
Focal |
Fix Released
|
High
|
Jean-Baptiste Lallement |
Bug Description
[Impact]
Ubuntu's ZFS boot support (`/etc/
[Test Case]
1. On a system that has a ZFS root (e.g. one installed with zsys), run `sudo update-grub`.
2. Verify that there are GRUB boot entries for ZFS:
sed -n '/^### BEGIN \/etc\/
3. To reproduce the problem, create or edit a `/boot` entry that will fail mounting. (Back up the existing line if you have one and are working on a real system.) Example:
echo 'UUID=deaddead-
4. (Optional) Take a ZFS snapshot of the dataset that provides `/etc`:
sudo zfs snap "$(df /etc -t zfs | sed '/^Filesystem/d' | awk '{print $1}')"@repro
5. If you performed step 4, restore the `/etc/fstab` back to its original working condition:
sudo sed -i '/^UUID=
6. Run `sudo update-grub` again.
7. See that the GRUB boot entries for ZFS roots have been wiped out:
sed -n '/^### BEGIN \/etc\/
[Regression Potential]
The patch adds a sanity check for a mount that could fail. The sanity check prevents the entire `/etc/grub.
The new behavior causes the `get_system_
Changed in grub2 (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Jean-Baptiste Lallement (jibel) |
Changed in grub2 (Ubuntu Focal): | |
status: | Triaged → In Progress |
Changed in grub2 (Ubuntu Eoan): | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Jean-Baptiste Lallement (jibel) |
Changed in grubzfs-testsuite (Ubuntu Eoan): | |
assignee: | nobody → Jean-Baptiste Lallement (jibel) |
Changed in grubzfs-testsuite (Ubuntu Focal): | |
assignee: | nobody → Jean-Baptiste Lallement (jibel) |
Changed in grubzfs-testsuite (Ubuntu Eoan): | |
importance: | Undecided → High |
Changed in grubzfs-testsuite (Ubuntu Focal): | |
importance: | Undecided → High |
Changed in grubzfs-testsuite (Ubuntu Eoan): | |
status: | New → Triaged |
Changed in grubzfs-testsuite (Ubuntu Focal): | |
status: | New → Triaged |
The attachment "/etc/grub. d/10_linux_ zfs: Ignore failed /etc/fstab mount in the get_system_ directory( ) function" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]