deb to snap transition uses an ubuntu release channel for the core18 snap
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-release-upgrader (Ubuntu) |
Fix Released
|
High
|
Łukasz Zemczak | ||
Disco |
Fix Released
|
Medium
|
Unassigned | ||
Eoan |
Fix Released
|
High
|
Łukasz Zemczak |
Bug Description
[Impact]
During distro upgrades, additional logic exists that replaces existing debs with snaps and refreshes existing, installed snaps to the branch of the series we're upgrading to (e.g. from stable/ubuntu-18.04 to stable/ubuntu-19.04 etc.). However, the upgrader tries to apply the logic for all the snaps it 'supports' in migration, even though snaps like core18 do not have per-series branches (and will never have). This causes non-fatal failures during installation/
[Test Case]
* Prepare a bionic machine
* Make sure ubuntu-desktop and snapd are installed on it
* Make sure core18 is *not* installed on the system - if there are any snaps installed, remove them
* Perform an upgrade to disco (with the --proposed option, to use disco-proposed)
* Reboot
* Make sure that the upgrade succeeded
* Check if core18 is installed, open /var/log/
[Regression Potential]
The changes have been constrained to the DistUpgradeQuirks place, only to the snap handling pieces. So any possible regressions should be visible in the snap replacement/refresh areas. Most probable ones would be for the snaps not being installed/refreshed properly, or using the wrong channels/branches.
[Original Description]
The release upgrader (DistUpgradeQui
snap install --channel stable/ubuntu-19.10 core18
This channel does not exist and the release upgrade will fail e.g.:
2019-08-23 03:24:45,533 DEBUG quirks: running eoanPostUpgrade
2019-08-23 03:24:45,533 DEBUG running Quirks.
2019-08-23 03:24:51,547 DEBUG install of snap core18 failed
2019-08-23 03:25:51,348 DEBUG install of snap gnome-3-28-1804 succeeded
The quirk should be updated so that an ubuntu release channel is not used when installing the core18 snap.
Related branches
- Brian Murray: Approve
-
Diff: 195 lines (+78/-34)2 files modifiedDistUpgrade/DistUpgradeQuirks.py (+15/-8)
tests/test_quirks.py (+63/-26)
tags: | added: eoan |
Changed in ubuntu-release-upgrader (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: id-5d601a1e1cecf13f82a7067a |
Changed in ubuntu-release-upgrader (Ubuntu Eoan): | |
assignee: | nobody → Łukasz Zemczak (sil2100) |
Changed in ubuntu-release-upgrader (Ubuntu Eoan): | |
status: | Triaged → In Progress |
description: | updated |
Changed in ubuntu-release-upgrader (Ubuntu Disco): | |
importance: | Undecided → Medium |
status: | New → In Progress |
This bug was fixed in the package ubuntu- release- upgrader - 1:19.10.11
--------------- release- upgrader (1:19.10.11) eoan; urgency=medium
ubuntu-
* DistUpgrade/ DistUpgradeQuir ks.py, DistUpgrade/ DistUpgradeCach e.py: DistUpgradeQuir ks.py: Make sure snaps like core18 are not installed from the stable/ ubuntu- VERSION branch but instead use
Modify DistUpgradeQuirks to calculate extra space needed for snaps that
need to be installed during upgrade (replacing old debs) and add that to
estimates done in checkFreeSpace(). (LP: #1783597)
* DistUpgrade/
refreshed/
stable on upgrades. (LP: #1841225)
-- Łukasz 'sil2100' Zemczak <email address hidden> Tue, 03 Sep 2019 15:58:38 +0200