Activity log for bug #1800681

Date Who What changed Old value New value Message
2018-10-30 16:16:00 Dimitri John Ledkov bug added bug
2018-10-30 16:16:16 Dimitri John Ledkov nominated for series Ubuntu Disco
2018-10-30 16:16:16 Dimitri John Ledkov bug task added open-iscsi (Ubuntu Disco)
2018-10-30 16:16:16 Dimitri John Ledkov nominated for series Ubuntu Bionic
2018-10-30 16:16:16 Dimitri John Ledkov bug task added open-iscsi (Ubuntu Bionic)
2018-10-30 16:16:16 Dimitri John Ledkov nominated for series Ubuntu Cosmic
2018-10-30 16:16:16 Dimitri John Ledkov bug task added open-iscsi (Ubuntu Cosmic)
2018-10-31 12:35:33 Francis Ginther tags id-5bbe5cb1a3a04d69ef6d9037
2018-12-10 09:11:37 Launchpad Janitor open-iscsi (Ubuntu Disco): status New Fix Released
2019-10-25 13:26:42 Balint Reczey open-iscsi (Ubuntu Cosmic): status New Won't Fix
2019-10-28 15:09:32 Balint Reczey description open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@ done fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi + exit 0 [Impact] * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case] * TODO [Regression Potential] * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0
2019-10-28 16:06:45 Balint Reczey description [Impact] * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case] * TODO [Regression Potential] * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0 [Impact]  * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case]  * Start a PV (non-iscsi) instance in Oracle Cloud (https://www.oracle.com/cloud/) * Monitor the instance's console. * Shut down the instance * Observe the shutdown proceeding in a timely manner without the following printouts: [ 851.308389] sd-umoun[2880]: Failed to unmount /oldroot: Device or resource busy [ 851.311743] sd-umoun[2881]: Failed to unmount /oldroot/dev: Device or resource busy iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. Unexpected iSCSI Connection State, forcing iSCSI logout. iscsiadm: No matching sessions found [ 881.434458] sd-execu[2882]: /usr/lib/systemd/system-shutdown/open-iscsi.finalrd failed with exit status 21. [ 881.438313] shutdown[1]: Failed to finalize file systems, ignoring [Regression Potential]  * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0
2019-10-28 17:04:36 Łukasz Zemczak open-iscsi (Ubuntu Bionic): status New Fix Committed
2019-10-28 17:04:38 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-10-28 17:04:40 Łukasz Zemczak bug added subscriber SRU Verification
2019-10-28 17:04:44 Łukasz Zemczak tags id-5bbe5cb1a3a04d69ef6d9037 id-5bbe5cb1a3a04d69ef6d9037 verification-needed verification-needed-bionic
2019-10-28 17:07:57 Balint Reczey description [Impact]  * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case]  * Start a PV (non-iscsi) instance in Oracle Cloud (https://www.oracle.com/cloud/) * Monitor the instance's console. * Shut down the instance * Observe the shutdown proceeding in a timely manner without the following printouts: [ 851.308389] sd-umoun[2880]: Failed to unmount /oldroot: Device or resource busy [ 851.311743] sd-umoun[2881]: Failed to unmount /oldroot/dev: Device or resource busy iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. Unexpected iSCSI Connection State, forcing iSCSI logout. iscsiadm: No matching sessions found [ 881.434458] sd-execu[2882]: /usr/lib/systemd/system-shutdown/open-iscsi.finalrd failed with exit status 21. [ 881.438313] shutdown[1]: Failed to finalize file systems, ignoring [Regression Potential]  * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0 [Impact]  * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case] (1) * Start a PV (non-iscsi) instance in Oracle Cloud (https://www.oracle.com/cloud/)  * Monitor the instance's console.  * Shut down the instance  * Observe the shutdown proceeding in a timely manner without the following printouts: [ 851.308389] sd-umoun[2880]: Failed to unmount /oldroot: Device or resource busy [ 851.311743] sd-umoun[2881]: Failed to unmount /oldroot/dev: Device or resource busy iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. Unexpected iSCSI Connection State, forcing iSCSI logout. iscsiadm: No matching sessions found [ 881.434458] sd-execu[2882]: /usr/lib/systemd/system-shutdown/open-iscsi.finalrd failed with exit status 21. [ 881.438313] shutdown[1]: Failed to finalize file systems, ignoring (2) * Start an iSCSI instance in Oracle Cloud (https://www.oracle.com/cloud/) * Monitor the instance's console. * Restart the instance * Observe the instance rebooting properly [Regression Potential]  * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0
2019-11-05 08:38:58 Janåke Rönnblom bug added subscriber Janåke Rönnblom
2019-11-26 15:01:10 Dimitri John Ledkov description [Impact]  * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case] (1) * Start a PV (non-iscsi) instance in Oracle Cloud (https://www.oracle.com/cloud/)  * Monitor the instance's console.  * Shut down the instance  * Observe the shutdown proceeding in a timely manner without the following printouts: [ 851.308389] sd-umoun[2880]: Failed to unmount /oldroot: Device or resource busy [ 851.311743] sd-umoun[2881]: Failed to unmount /oldroot/dev: Device or resource busy iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. Unexpected iSCSI Connection State, forcing iSCSI logout. iscsiadm: No matching sessions found [ 881.434458] sd-execu[2882]: /usr/lib/systemd/system-shutdown/open-iscsi.finalrd failed with exit status 21. [ 881.438313] shutdown[1]: Failed to finalize file systems, ignoring (2) * Start an iSCSI instance in Oracle Cloud (https://www.oracle.com/cloud/) * Monitor the instance's console. * Restart the instance * Observe the instance rebooting properly [Regression Potential]  * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0 Separately, ship finalrd hook which cloud images can switch to using. By default, it is inert, as finalrd itself is not pulled in. --- [Impact]  * Shutdown is delayed by 30s when open-iscsi is configured to auto mode but no iscsi devices were found. [Test Case] (1) * Start a PV (non-iscsi) instance in Oracle Cloud (https://www.oracle.com/cloud/)  * Monitor the instance's console.  * Shut down the instance  * Observe the shutdown proceeding in a timely manner without the following printouts: [ 851.308389] sd-umoun[2880]: Failed to unmount /oldroot: Device or resource busy [ 851.311743] sd-umoun[2881]: Failed to unmount /oldroot/dev: Device or resource busy iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. iscsiadm: No active sessions. Unexpected iSCSI Connection State, forcing iSCSI logout. iscsiadm: No matching sessions found [ 881.434458] sd-execu[2882]: /usr/lib/systemd/system-shutdown/open-iscsi.finalrd failed with exit status 21. [ 881.438313] shutdown[1]: Failed to finalize file systems, ignoring (2) * Start an iSCSI instance in Oracle Cloud (https://www.oracle.com/cloud/)  * Monitor the instance's console.  * Restart the instance  * Observe the instance rebooting properly [Regression Potential]  * The fix is removing /run/initramfs/open-iscsi.interface during running initramfs scripts if not iscsi disks were found. In case not detecting an iscsi device but removing the .interface file the system may reconfigure the network interface later losing connection to the iscsi device. [Original Bug Text] open-iscsi should not leave around the stamp file if no connections were made open-iscsi finalrd hook is sensitive to /run/initramfs/open-iscsi.interface as an indicator that rootfs might have been an iscsi mount, and thus logout needs to happen inside finalrd. However, in auto-mode, and without any iscsi hard-drives found, that stamp file is still left around. It should be cleaned up, such that such boots do not result in 30s shutdown delay. Proposed patch is this: /usr/share/initramfs-tools/scripts/local-top$ diff -u iscsi.orig iscsi --- iscsi.orig 2018-10-30 15:53:36.314256545 +0000 +++ iscsi 2018-10-30 15:53:02.883686328 +0000 @@ -360,4 +360,19 @@   done  fi +# Remove the interface file if no disks are present +if [ -f /run/initramfs/open-iscsi.interface ] ; then + found=0 + for disk in /dev/disk/by-path/*-iscsi-*; do + if ! "$(readlink -f "$disk")" ; then + continue + fi + found=1 + break; + done + if [ $found = 0 ] ; then + rm /run/initramfs/open-iscsi.interface + fi +fi +  exit 0
2019-11-26 15:16:37 Balint Reczey bug added subscriber Balint Reczey
2020-04-27 16:47:27 Brian Murray tags id-5bbe5cb1a3a04d69ef6d9037 verification-needed verification-needed-bionic id-5bbe5cb1a3a04d69ef6d9037 removal-candidate verification-needed verification-needed-bionic
2020-05-11 14:17:23 David Krauser tags id-5bbe5cb1a3a04d69ef6d9037 removal-candidate verification-needed verification-needed-bionic id-5bbe5cb1a3a04d69ef6d9037 removal-candidate verification-done
2020-05-11 15:41:52 Balint Reczey tags id-5bbe5cb1a3a04d69ef6d9037 removal-candidate verification-done id-5bbe5cb1a3a04d69ef6d9037 removal-candidate verification-done verification-done-bionic
2020-05-12 17:03:03 Launchpad Janitor open-iscsi (Ubuntu Bionic): status Fix Committed Fix Released
2020-05-12 17:03:13 Brian Murray removed subscriber Ubuntu Stable Release Updates Team