seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test

Bug #1849281 reported by Christian Brauner on 2019-10-22
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
High
Unassigned
linux (Ubuntu)
High
Christian Brauner
Disco
High
Unassigned
Eoan
High
Unassigned

Bug Description

SRU Justification

Impact:
We recently backported SECCOMP_USER_NOTIF_FLAG_CONTINUE in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1847744. On a kernel that supports SECCOMP_FILTER_FLAG_NEW_LISTENER but not SECCOMP_USER_NOTIF_FLAG_CONTINUE the selftests currently fail to compile. The reason is that the ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE is placed under the ifndef for SECCOMP_FILTER_FLAG_NEW_LISTENER.

Fix:
The ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE was placed under the
ifndef for the SECCOMP_FILTER_FLAG_NEW_LISTENER feature. This will not
work on systems that do support SECCOMP_FILTER_FLAG_NEW_LISTENER but do not
support SECCOMP_USER_NOTIF_FLAG_CONTINUE. So move the latter ifndef out of
the former ifndef's scope.

Regression Potential:
Limited to seccomp selftests.

Test Case:
Compile the selftests on a kernel that supports SECCOMP_FILTER_FLAG_NEW_LISTENER but does not support SECCOMP_USER_NOTIF_FLAG_CONTINUE and see that compilations succeeds.

Target Kernels: All current LTS kernels with access to a 5.0 kernel.

Patches:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=for-next/seccomp&id=2aa8d8d04ca29c3269154e1d48855e498be8882f

Changed in linux (Ubuntu):
status: New → In Progress
assignee: nobody → Christian Brauner (cbrauner)
Seth Forshee (sforshee) on 2019-10-22
Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Po-Hsu Lin (cypressyew) on 2019-10-28
tags: added: 5.3 bionic sru-20190930 ubuntu-kernel-selftests
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in linux (Ubuntu Disco):
status: New → Confirmed
Changed in linux (Ubuntu Eoan):
status: New → Confirmed
Changed in linux (Ubuntu Disco):
status: Confirmed → Fix Committed
Changed in linux (Ubuntu Eoan):
status: Confirmed → Fix Committed
Changed in linux (Ubuntu Disco):
status: Fix Committed → Confirmed
Changed in linux (Ubuntu Eoan):
status: Fix Committed → Confirmed
Manoj Iyer (manjo) on 2019-11-07
Changed in linux (Ubuntu Eoan):
status: Confirmed → In Progress
Changed in ubuntu-kernel-tests:
importance: Undecided → High
Changed in linux (Ubuntu):
importance: Undecided → High
Changed in linux (Ubuntu Disco):
importance: Undecided → High
Changed in linux (Ubuntu Eoan):
importance: Undecided → High
Manoj Iyer (manjo) on 2019-11-08
Changed in linux (Ubuntu Disco):
status: Confirmed → In Progress
Changed in linux (Ubuntu Eoan):
status: In Progress → Fix Committed
Stefan Bader (smb) on 2019-11-13
Changed in linux (Ubuntu Disco):
status: In Progress → Fix Committed

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-eoan' to 'verification-done-eoan'. If the problem still exists, change the tag 'verification-needed-eoan' to 'verification-failed-eoan'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-eoan

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-disco' to 'verification-done-disco'. If the problem still exists, change the tag 'verification-needed-disco' to 'verification-failed-disco'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-disco
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers