Activity log for bug #1823037

Date Who What changed Old value New value Message
2019-04-03 15:20:15 Jeff Lane  bug added bug
2019-04-03 15:20:36 Jeff Lane  nominated for series Ubuntu Bionic
2019-04-03 15:20:36 Jeff Lane  bug task added linux (Ubuntu Bionic)
2019-04-03 15:20:36 Jeff Lane  nominated for series Ubuntu Cosmic
2019-04-03 15:20:36 Jeff Lane  bug task added linux (Ubuntu Cosmic)
2019-04-03 15:20:36 Jeff Lane  nominated for series Ubuntu Xenial
2019-04-03 15:20:36 Jeff Lane  bug task added linux (Ubuntu Xenial)
2019-04-03 15:21:00 Jeff Lane  bug task deleted linux (Ubuntu Xenial)
2019-04-03 15:22:36 Jeff Lane  nominated for series Ubuntu Disco
2019-04-03 15:22:36 Jeff Lane  bug task added linux (Ubuntu Disco)
2019-04-03 15:22:48 Jeff Lane  linux (Ubuntu Cosmic): assignee Jeff Lane (bladernr)
2019-04-03 15:22:50 Jeff Lane  linux (Ubuntu Bionic): assignee Jeff Lane (bladernr)
2019-04-04 06:53:44 Andrew Cloke bug added subscriber Andrew Cloke
2019-04-04 15:53:17 Jerry Clement bug added subscriber Jerry Clement
2019-04-05 07:33:40 Launchpad Janitor linux (Ubuntu Bionic): status New Confirmed
2019-04-05 07:33:40 Launchpad Janitor linux (Ubuntu Cosmic): status New Confirmed
2019-04-08 12:38:31 Jeff Lane  linux (Ubuntu Cosmic): status Confirmed In Progress
2019-04-08 12:38:33 Jeff Lane  linux (Ubuntu Bionic): status Confirmed In Progress
2019-04-08 12:41:33 Jeff Lane  bug added subscriber Michael Reed
2019-05-20 16:47:26 Jerry Clement tags verification-done-bionic
2019-05-20 16:49:32 Jerry Clement tags verification-done-bionic verification-done-cosmic
2019-05-21 20:15:05 Jerry Clement tags verification-done-cosmic verification-done-bionic verification-done-cosmic verification-done-disco
2019-05-24 17:14:44 Jeff Lane  description [Impact] If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. This is a clean cherry pick from mainline of 8aafaaf2212192012f5bae305bb31cdf7681d777 [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain [Regression Risk] Only affects the amd_iommu driver: drivers/iommu/amd_iommu* [Impact] If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. This is a clean cherry pick from mainline of 8aafaaf2212192012f5bae305bb31cdf7681d777 3c677d206210f53a4be972211066c0f1cd47fe12 [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly [Regression Risk] Only affects the amd_iommu driver:     drivers/iommu/amd_iommu*
2019-05-28 16:05:58 Jeff Lane  description [Impact] If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. This is a clean cherry pick from mainline of 8aafaaf2212192012f5bae305bb31cdf7681d777 3c677d206210f53a4be972211066c0f1cd47fe12 [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly [Regression Risk] Only affects the amd_iommu driver:     drivers/iommu/amd_iommu* [Impact] If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. This is a clean cherry pick from mainline of 8aafaaf2212192012f5bae305bb31cdf7681d777 3c677d206210f53a4be972211066c0f1cd47fe12 [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco I do not believe these are necessary for Eoan, 5.1 should already include them but it's worth verifying that as I started work on this prior to Eoan's cycle. [Regression Risk] Only affects the amd_iommu driver:     drivers/iommu/amd_iommu*
2019-05-28 16:06:10 Jeff Lane  linux (Ubuntu Bionic): importance Undecided Medium
2019-05-28 16:06:12 Jeff Lane  linux (Ubuntu Cosmic): importance Undecided Medium
2019-06-06 14:36:28 Jeff Lane  description [Impact] If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. This is a clean cherry pick from mainline of 8aafaaf2212192012f5bae305bb31cdf7681d777 3c677d206210f53a4be972211066c0f1cd47fe12 [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco I do not believe these are necessary for Eoan, 5.1 should already include them but it's worth verifying that as I started work on this prior to Eoan's cycle. [Regression Risk] Only affects the amd_iommu driver:     drivers/iommu/amd_iommu* [Impact] iommu/amd: Reserve exclusion range in iova-domain If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. iommu/amd: Set exclusion range correctly The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan, they're in 5.2-rc1. [Regression Risk] Low, Only affects the amd_iommu driver:     drivers/iommu/amd_iommu*
2019-06-06 14:39:47 Jeff Lane  description [Impact] iommu/amd: Reserve exclusion range in iova-domain If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. iommu/amd: Set exclusion range correctly The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan, they're in 5.2-rc1. [Regression Risk] Low, Only affects the amd_iommu driver:     drivers/iommu/amd_iommu* [Impact] iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan, they're in 5.2-rc1. [Regression Risk] Low, Only affects the amd_iommu driver:     drivers/iommu/amd_iommu*
2019-06-06 15:22:46 Jeff Lane  description [Impact] iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan, they're in 5.2-rc1. [Regression Risk] Low, Only affects the amd_iommu driver:     drivers/iommu/amd_iommu* [Impact] iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low, Only affects the amd_iommu driver:     drivers/iommu/amd_iommu*
2019-06-06 21:12:51 Jeff Lane  description [Impact] iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Test Case] [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low, Only affects the amd_iommu driver:     drivers/iommu/amd_iommu* [Impact] iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory range protection to the driver and has already been acked upstream.
2019-06-06 21:18:05 Jeff Lane  description [Impact] iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory range protection to the driver and has already been acked upstream. [Impact] iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory protection to the driver and has already been acked upstream and tested by Dell for 24 hours with no failures noted.
2019-06-06 21:18:55 Jeff Lane  description [Impact] iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory protection to the driver and has already been acked upstream and tested by Dell for 24 hours with no failures noted. [Impact] iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 iommu/amd: Set exclusion range correctly Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory protection to the driver and has already been acked upstream and tested by Dell for 24 hours with no failures noted.
2019-06-06 22:23:54 Jeff Lane  description [Impact] iommu/amd: Reserve exclusion range in iova-domain BugLink: https://bugs.launchpad.net/bugs/1823037 If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. Treat exclusion ranges as reserved regions in the iommu-core to fix the problem. Fixes: be2a022c0dd0 ('x86, AMD IOMMU: add functions to parse IOMMU memory mapping requirements for devices') Signed-off-by: Joerg Roedel <jroedel@suse.de> Reviewed-by: Gary R Hook <gary.hook@amd.com> (cherry picked from commit 8aafaaf2212192012f5bae305bb31cdf7681d777) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> iommu/amd: Set exclusion range correctly BugLink: https://bugs.launchpad.net/bugs/1823037 The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel <jroedel@suse.de> (cherry picked from commit 3c677d206210f53a4be972211066c0f1cd47fe12) Signed-off-by: Jeffrey Lane <jeffrey.lane@canonical.com> [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 iommu/amd: Set exclusion range correctly Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory protection to the driver and has already been acked upstream and tested by Dell for 24 hours with no failures noted. [Impact] If a device has an exclusion range specified in the IVRS table, this region needs to be reserved in the iova-domain of that device. This hasn't happened until now and can cause data corruption on data transfered with these devices. The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. [Fixes] Cherry pick the following from Mainline fd3b3448cf5adc2a2f09b70eaad03c27fe79e7a6 iommu/amd: Reserve exclusion range in iova-domain 3c677d206210f53a4be972211066c0f1cd47fe12 iommu/amd: Set exclusion range correctly These can be picked from my branches here: Bionic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/bionic 1823037-amd_iommu-cherrypick b7abdb585d0ae4193add1f7038476cd8d6dd7f41 iommu/amd: Reserve exclusion range in iova-domain ee4a87e6b7fe7e039c1f02c50c53da63e4270732 iommu/amd: Set exclusion range correctly Cosmic: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/cosmic 1823037-amd_iommu-cherrypick 0acc8c0e862b46b12c233abd76593420f4a20e0c iommu/amd: Reserve exclusion range in iova-domain fbead5d71bfc2a49ffca8d181e2708fd616e9a7f iommu/amd: Set exclusion range correctly Disco: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/disco 1823037-amd_iommu-cherrypick 6ddc207ca0d442b413ea7f059937ba90e5139753 iommu/amd: Set exclusion range correctly Note Disco only required f1cd47fe12 as the first patch was already picked in LP: #1830934 Not necessary for Eoan as these are already upstream in 5.2-rc1 [Regression Risk] Low,this adds memory protection to the driver and has already been applied upstream and tested by Dell for 24 hours with no failures noted.
2019-06-28 04:29:24 Khaled El Mously linux (Ubuntu Bionic): status In Progress Fix Committed
2019-06-28 04:29:28 Khaled El Mously linux (Ubuntu Cosmic): status In Progress Fix Committed
2019-06-28 04:29:29 Khaled El Mously linux (Ubuntu Disco): status In Progress Fix Committed
2019-07-22 10:53:34 Launchpad Janitor linux (Ubuntu Bionic): status Fix Committed Fix Released
2019-07-22 10:53:34 Launchpad Janitor cve linked 2018-12126
2019-07-22 10:53:34 Launchpad Janitor cve linked 2018-12127
2019-07-22 10:53:34 Launchpad Janitor cve linked 2018-12130
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11085
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11091
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11815
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11833
2019-07-22 10:53:34 Launchpad Janitor cve linked 2019-11884
2019-07-23 05:25:24 Launchpad Janitor linux (Ubuntu Disco): status Fix Committed Fix Released
2019-07-24 21:18:32 Brad Figg tags verification-done-bionic verification-done-cosmic verification-done-disco cscc verification-done-bionic verification-done-cosmic verification-done-disco
2019-08-06 23:42:22 Terry Rudd linux (Ubuntu Cosmic): status Fix Committed Invalid
2019-08-22 16:16:32 Ubuntu Kernel Bot tags cscc verification-done-bionic verification-done-cosmic verification-done-disco cscc verification-done-bionic verification-done-cosmic verification-done-disco verification-needed-xenial
2020-04-21 20:35:49 Jeff Lane  linux (Ubuntu): status In Progress Fix Released