| 2018-12-04 21:33:23 |
dann frazier |
bug |
|
|
added bug |
| 2018-12-04 21:34:16 |
dann frazier |
nominated for series |
|
Ubuntu Cosmic |
|
| 2018-12-04 21:34:16 |
dann frazier |
bug task added |
|
linux (Ubuntu Cosmic) |
|
| 2018-12-04 21:34:23 |
dann frazier |
nominated for series |
|
Ubuntu Disco |
|
| 2018-12-04 21:34:23 |
dann frazier |
bug task added |
|
linux (Ubuntu Disco) |
|
| 2018-12-04 22:00:04 |
Ubuntu Kernel Bot |
linux (Ubuntu): status |
New |
Incomplete |
|
| 2018-12-04 22:00:05 |
Ubuntu Kernel Bot |
linux (Ubuntu Cosmic): status |
New |
Incomplete |
|
| 2018-12-05 00:01:27 |
dann frazier |
description |
[Impact]
kdump support isn't usable on HiSilicon D05 systems. This previously worked in bionic.
[Test Case]
sudo apt install linux-crashdump
echo 'GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT crashkernel=512M"' | \
sudo tee /etc/default/grub.d/kdump-tools.cfg
sudo update-grub
sudo reboot
echo 1 | sudo tee /proc/sys/kernel/sysrq
echo c | sudo tee /proc/sysrq-trigger
[Fix]
2 upstream patch series are required to fix this:
https://www.mail-archive.com/linux-efi@vger.kernel.org/msg10328.html
Which provides an EFI facility consumed by:
https://lkml.org/lkml/2018/9/21/1066
There were also some follow-on fixes to deal with ARM-specific problems associated with this usage:
https://www.spinics.net/lists/arm-kernel/msg685751.html
[Regression Risk]
The EFI changes are in architecture independent code where they add a new table and an API for adding regions to that table. However, this API is only used by the gic-v3-its driver, which is ARM-specific. On other architectures, this will be an empty table. It's possible that there is a bug bug in the table creation code that could cause regressions on other architectures, which would likely be seen in the form of a boot time error message (Failed to install memreserve config table). |
[Impact]
kdump support isn't usable on HiSilicon D05 systems. This previously worked in bionic.
[Test Case]
sudo apt install linux-crashdump
echo 'GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT crashkernel=512M"' | \
sudo tee /etc/default/grub.d/kdump-tools.cfg
sudo update-grub
sudo reboot
echo 1 | sudo tee /proc/sys/kernel/sysrq
echo c | sudo tee /proc/sysrq-trigger
On failure:
[ 2.362261] ------------[ cut here ]------------
[ 2.362263] [CRTC:29:crtc-0] vblank wait timed out
[ 2.362294] WARNING: CPU: 0 PID: 143 at drivers/gpu/drm/drm_atomic_helper.c:1386 drm_atomic_helper_wait_for_vblanks.part.9+0x280/0x290 [drm_kms_helper]
[ 2.362295] Modules linked in: hibmc_drm(+) ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm hisi_sas_v2_hw(+) hisi_sas_main ehci_platform libsas scsi_transport_sas
[ 2.362309] CPU: 0 PID: 143 Comm: systemd-udevd Tainted: G C 4.19.0-7-generic #8-Ubuntu
[ 2.362310] Hardware name: Huawei TaiShan 2280 /BC11SPCD, BIOS 1.50 06/01/2018
[ 2.362312] pstate: 60400005 (nZCv daif +PAN -UAO)
[ 2.362324] pc : drm_atomic_helper_wait_for_vblanks.part.9+0x280/0x290 [drm_kms_helper]
[ 2.362335] lr : drm_atomic_helper_wait_for_vblanks.part.9+0x280/0x290 [drm_kms_helper]
[ 2.362336] sp : ffff00000a2fb1f0
[ 2.362337] x29: ffff00000a2fb1f0 x28: 0000000000000001
[ 2.362339] x27: 0000000000000000 x26: 0000000000000001
[ 2.362342] x25: 0000000000000038 x24: ffff8000208c5800
[ 2.362344] x23: 0000000000000000 x22: 0000000000000001
[ 2.362346] x21: ffff80001eebb818 x20: ffff800025b18600
[ 2.362349] x19: 0000000000000000 x18: 0000000000000001
[ 2.362351] x17: 0000000000000000 x16: 0000000000000000
[ 2.362353] x15: ffffffffffffffff x14: ffff000009848708
[ 2.362355] x13: 0000000000000074 x12: ffff000009a12000
[ 2.362357] x11: ffff00000986d000 x10: ffff000009a122f8
[ 2.362359] x9 : 0000000000000001 x8 : ffff000009a15104
[ 2.362361] x7 : 0000000000000000 x6 : 0000004ce5700bb7
[ 2.362363] x5 : 00ffffffffffffff x4 : 0000000000000000
[ 2.362365] x3 : 0000000000000000 x2 : ffffffffffffffff
[ 2.362367] x1 : 0b15ae454042e100 x0 : 0000000000000000
[ 2.362370] Call trace:
[ 2.362381] drm_atomic_helper_wait_for_vblanks.part.9+0x280/0x290 [drm_kms_helper]
[ 2.362392] drm_atomic_helper_commit_tail+0x68/0x80 [drm_kms_helper]
[ 2.362402] commit_tail+0x7c/0x80 [drm_kms_helper]
[ 2.362413] drm_atomic_helper_commit+0xd8/0x150 [drm_kms_helper]
[ 2.362440] drm_atomic_commit+0x54/0x60 [drm]
[ 2.362451] restore_fbdev_mode_atomic+0x184/0x1f8 [drm_kms_helper]
[ 2.362461] restore_fbdev_mode+0x48/0x190 [drm_kms_helper]
[ 2.362472] drm_fb_helper_restore_fbdev_mode_unlocked+0x78/0xd8 [drm_kms_helper]
[ 2.362482] drm_fb_helper_set_par+0x34/0x60 [drm_kms_helper]
[ 2.362488] fbcon_init+0x3ac/0x4f0
[ 2.362491] visual_init+0xb8/0x110
[ 2.362492] do_bind_con_driver+0x1ec/0x3a8
[ 2.362494] do_take_over_console+0x148/0x208
[ 2.362495] do_fbcon_takeover+0x70/0xd8
[ 2.362497] fbcon_event_notify+0x838/0x8a8
[ 2.362501] notifier_call_chain+0x5c/0x98
[ 2.362502] blocking_notifier_call_chain+0x64/0x88
[ 2.362504] fb_notifier_call_chain+0x30/0x40
[ 2.362506] register_framebuffer+0x22c/0x328
[ 2.362516] __drm_fb_helper_initial_config_and_unlock+0x210/0x408 [drm_kms_helper]
[ 2.362526] drm_fb_helper_initial_config+0x4c/0x58 [drm_kms_helper]
[ 2.362530] hibmc_fbdev_init+0x88/0x190 [hibmc_drm]
[ 2.362534] hibmc_pci_probe+0x228/0x3c8 [hibmc_drm]
[ 2.362537] local_pci_probe+0x44/0xa8
[ 2.362539] pci_device_probe+0x194/0x1a8
[ 2.362541] really_probe+0x21c/0x3b8
[ 2.362543] driver_probe_device+0xe4/0x138
[ 2.362544] __driver_attach+0xe4/0x150
[ 2.362545] bus_for_each_dev+0x84/0xd8
[ 2.362547] driver_attach+0x30/0x40
[ 2.362548] bus_add_driver+0x1a8/0x288
[ 2.362550] driver_register+0x64/0x110
[ 2.362551] __pci_register_driver+0x58/0x68
[ 2.362555] hibmc_init+0x30/0x1000 [hibmc_drm]
[ 2.362557] do_one_initcall+0x54/0x1d8
[ 2.362560] do_init_module+0x60/0x1f0
[ 2.362561] load_module+0x15d0/0x18b8
[ 2.362563] __se_sys_finit_module+0xa0/0xf8
[ 2.362565] __arm64_sys_finit_module+0x24/0x30
[ 2.362567] el0_svc_common+0x94/0xe8
[ 2.362568] el0_svc_handler+0x38/0x78
[ 2.362570] el0_svc+0x8/0xc
[ 2.362571] ---[ end trace 8031150f999972d9 ]---
[Fix]
2 upstream patch series are required to fix this:
https://www.mail-archive.com/linux-efi@vger.kernel.org/msg10328.html
Which provides an EFI facility consumed by:
https://lkml.org/lkml/2018/9/21/1066
There were also some follow-on fixes to deal with ARM-specific problems associated with this usage:
https://www.spinics.net/lists/arm-kernel/msg685751.html
[Regression Risk]
The EFI changes are in architecture independent code where they add a new table and an API for adding regions to that table. However, this API is only used by the gic-v3-its driver, which is ARM-specific. On other architectures, this will be an empty table. It's possible that there is a bug in the table creation code that could cause regressions on other architectures, which would likely be seen in the form of a boot time error message ("Failed to install memreserve config table").
Risk mitigated by testing on both x86 ARM and EFI systems. |
|
| 2018-12-05 00:01:30 |
dann frazier |
linux (Ubuntu Disco): status |
Incomplete |
In Progress |
|
| 2018-12-05 00:01:33 |
dann frazier |
linux (Ubuntu Cosmic): status |
Incomplete |
In Progress |
|
| 2018-12-05 00:01:35 |
dann frazier |
linux (Ubuntu Cosmic): assignee |
|
dann frazier (dannf) |
|
| 2018-12-05 00:01:37 |
dann frazier |
linux (Ubuntu Disco): assignee |
|
dann frazier (dannf) |
|
| 2018-12-10 21:37:43 |
Seth Forshee |
linux (Ubuntu Disco): status |
In Progress |
Fix Committed |
|
| 2019-01-11 10:20:52 |
Kleber Sacilotto de Souza |
linux (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2019-01-15 10:33:15 |
Brad Figg |
tags |
|
verification-needed-cosmic |
|
| 2019-01-23 16:29:13 |
dann frazier |
tags |
verification-needed-cosmic |
verification-done-cosmic |
|
| 2019-02-04 08:48:45 |
Launchpad Janitor |
linux (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2019-02-04 08:48:45 |
Launchpad Janitor |
cve linked |
|
2018-14625 |
|
| 2019-02-04 08:48:45 |
Launchpad Janitor |
cve linked |
|
2018-16882 |
|
| 2019-02-04 08:48:45 |
Launchpad Janitor |
cve linked |
|
2018-19407 |
|
| 2019-02-04 14:46:37 |
Launchpad Janitor |
linux (Ubuntu Disco): status |
Fix Committed |
Fix Released |
|
| 2019-02-14 11:34:00 |
Brad Figg |
tags |
verification-done-cosmic |
verification-done-cosmic verification-needed-bionic |
|
| 2019-02-14 15:52:55 |
Andy Whitcroft |
tags |
verification-done-cosmic verification-needed-bionic |
kernel-fixup-verification-needed-bionic verification-done-cosmic |
|
| 2019-02-14 16:18:34 |
Andy Whitcroft |
tags |
kernel-fixup-verification-needed-bionic verification-done-cosmic |
kernel-fixup-verification-needed-bionic verification-done-bionic verification-done-cosmic |
|
| 2019-07-24 21:32:24 |
Brad Figg |
tags |
kernel-fixup-verification-needed-bionic verification-done-bionic verification-done-cosmic |
cscc kernel-fixup-verification-needed-bionic verification-done-bionic verification-done-cosmic |
|
