Indicators Scroll events are not emitted in 19.04

Bug #1825447 reported by Ed Bruck
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-shell-extension-appindicator (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Disco
Fix Released
Medium
Marco Trevisan (Treviño)

Bug Description

[ Impact ]

Scroll events aren't delivered to app-indicators

[ Test case ]
 - Run an indicator that supports scroll events (i.e. radiotray-ng or run
   https://github.com/ubuntu/gnome-shell-extension-appindicator/blob/master/indicator-test-tool/testTool.js with gjs
 - Scroll events should be delivered

[ Regression potential ]

Scroll events over other shell actors aren't working (i.e. changing volume with scroll)

---

It appears the code used in the 19.04 packaging of the appindicator is from master and not the tagged ubuntu-19.04 commit from the ubuntu branch. The master branch is not delivering scroll events, which stops my application (radiotray-ng) from being able to adjust its volume levels.

I've swapped out the code under /<email address hidden>/ with the ubuntu branch and scrolling on an indicator icon works again.

I've filed an issue on github as well.

https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/169

Ed Bruck (ed-bruck1)
summary: - 19.04 packaging is from master and not the ubuntu branch
+ 19.04 packaging is from master and not ubuntu branch (breaks scroll
+ events)
Ed Bruck (ed-bruck1)
summary: - 19.04 packaging is from master and not ubuntu branch (breaks scroll
- events)
+ 19.04 packaging is from master (or wrong commit) and not ubuntu branch
+ (breaks scroll events)
Changed in gnome-shell-extension-appindicator (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Re: 19.04 packaging is from master (or wrong commit) and not ubuntu branch (breaks scroll events)

Upstream ubuntu branch wasn't updated since we synced from debian, so the branch isn't wrong.

The issue has to be fixed upstream as well, so I'll do that.

Changed in gnome-shell-extension-appindicator (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
description: updated
summary: - 19.04 packaging is from master (or wrong commit) and not ubuntu branch
- (breaks scroll events)
+ Indicators Scroll events are not emitted in 19.04
Changed in gnome-shell-extension-appindicator (Ubuntu Disco):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Iain Lane (laney) wrote :

synced, SRU uploaded as a backport of the eoan version

SRU team: there's a delta in testTool.js too, but this is not in the binary package

Changed in gnome-shell-extension-appindicator (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Lonnie Lee Best (launchpad-startport) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Ed, or anyone else affected,

Accepted gnome-shell-extension-appindicator into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-appindicator/29-1~ubuntu19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-shell-extension-appindicator (Ubuntu Disco):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-disco
Revision history for this message
Ed Bruck (ed-bruck1) wrote :

The extension is working fine with scroll events being delivered.
Thanks for the quick turnaround.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ed, just to confirm.

Have you installed version 29-1~ubuntu19.04.1 of the gnome-shell-extension-appindicator package?

Revision history for this message
Ed Bruck (ed-bruck1) wrote :

That is the version I installed.

tags: added: verification-done verification-done-disco
removed: verification-needed verification-needed-disco
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-appindicator - 29-1~ubuntu19.04.1

---------------
gnome-shell-extension-appindicator (29-1~ubuntu19.04.1) disco; urgency=medium

  * Backport from eoan to fix LP: #1825447

gnome-shell-extension-appindicator (29-1) experimental; urgency=medium

  [ Matteo F. Vescovi ]
  * New upstream release

  [ Marco Trevisan (Treviño) ]
  * dbusMenu: Fix indentation
  * testTool: Remove trailing spaces
  * testTool: Add item to toggle attention
  * testTool: Log signals to terminal
  * appIndicator: Connect to scroll-event signal.
    Fixes #169

 -- Iain Lane <email address hidden> Tue, 30 Apr 2019 11:11:16 +0100

Changed in gnome-shell-extension-appindicator (Ubuntu Disco):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-shell-extension-appindicator has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Lonnie Lee Best (launchpad-startport) wrote :

Thank you for fixing this. The app-level volume control is working great now by scrolling on top of the RadioTray icon.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.