chzdev export/prepare-for-import/import bombs out on import in python3.6
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
curtin |
Fix Released
|
High
|
Ryan Harper | ||
curtin (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Disco |
Won't Fix
|
High
|
Unassigned |
Bug Description
chzdev export/
like so:
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:49 ubuntu-server curtin_
Apr 16 14:05:50 ubuntu-server curtin_
Related branches
- Dimitri John Ledkov (community): Approve
- Server Team CI bot: Approve (continuous-integration)
- curtin developers: Pending requested
-
Diff: 63 lines (+9/-5)2 files modifiedcurtin/commands/curthooks.py (+3/-0)
tests/unittests/test_curthooks.py (+6/-5)
description: | updated |
Changed in curtin (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in curtin (Ubuntu Disco): | |
status: | Confirmed → Won't Fix |
Thanks, looks like python3.7 subprocess. Popen.communica te helpfully converts str to bytes, however that hid the bug when I tested this path on s390x disco.
The fix will be to encode the string data we passed to util.subp().