Activity log for bug #1732962

Date Who What changed Old value New value Message
2017-11-17 18:27:06 Brian Murray bug added bug
2018-02-09 09:35:27 Julian Andres Klode apport: importance Undecided Low
2018-02-09 09:35:30 Julian Andres Klode apport: status New In Progress
2018-02-09 09:35:36 Julian Andres Klode apport: assignee Julian Andres Klode (juliank)
2018-02-15 19:50:52 Francis Ginther tags id-5a0f2a3d5a9357e93d7f6816
2018-05-14 14:42:22 Launchpad Janitor branch linked lp:~juliank/apport/named-arguments
2019-03-04 16:48:50 Launchpad Janitor branch linked lp:~ubuntu-core-dev/ubuntu/disco/apport/ubuntu
2019-03-04 16:51:49 Julian Andres Klode bug task added apport (Ubuntu)
2019-03-04 16:51:55 Julian Andres Klode apport (Ubuntu): status New Fix Committed
2019-03-04 16:51:57 Julian Andres Klode apport: status In Progress Fix Committed
2019-03-04 16:52:06 Julian Andres Klode nominated for series Ubuntu Bionic
2019-03-04 16:52:06 Julian Andres Klode bug task added apport (Ubuntu Bionic)
2019-03-04 16:52:06 Julian Andres Klode nominated for series Ubuntu Xenial
2019-03-04 16:52:06 Julian Andres Klode bug task added apport (Ubuntu Xenial)
2019-03-04 16:52:06 Julian Andres Klode nominated for series Ubuntu Disco
2019-03-04 16:52:06 Julian Andres Klode bug task added apport (Ubuntu Disco)
2019-03-04 16:52:06 Julian Andres Klode nominated for series Ubuntu Trusty
2019-03-04 16:52:06 Julian Andres Klode bug task added apport (Ubuntu Trusty)
2019-03-04 16:52:06 Julian Andres Klode nominated for series Ubuntu Cosmic
2019-03-04 16:52:06 Julian Andres Klode bug task added apport (Ubuntu Cosmic)
2019-03-05 23:09:13 Launchpad Janitor apport (Ubuntu Disco): status Fix Committed Fix Released
2019-12-18 10:49:54 Julian Andres Klode apport (Ubuntu Cosmic): status New Won't Fix
2020-02-12 15:17:19 Julian Andres Klode apport (Ubuntu Trusty): status New Fix Committed
2020-02-12 15:17:23 Julian Andres Klode apport (Ubuntu Trusty): status Fix Committed Won't Fix
2020-08-27 20:45:56 Matthieu Clemenceau apport (Ubuntu Xenial): status New In Progress
2020-08-27 20:46:00 Matthieu Clemenceau apport (Ubuntu Bionic): status New In Progress
2020-08-27 20:49:27 Matthieu Clemenceau attachment added diff for xenial to support named param. (backport from cosmic) https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405275/+files/apport_2.20.1-0ubuntu2.25.debdiff
2020-08-27 20:50:09 Matthieu Clemenceau attachment added diff for bionic to support named param. (backport from cosmic) https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405276/+files/apport_2.20.9-0ubuntu7.18.debdiff
2020-08-27 20:50:57 Matthieu Clemenceau bug added subscriber Ubuntu Sponsors Team
2020-08-31 18:33:10 Matthieu Clemenceau description data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. Here's something of an example: 347 # Normal startup 348 if len(sys.argv) not in (5, 6): 349 try: 350 print('Usage: %s <pid> <signal number> <core file ulimit> <dump mode> [global pid]' % sys.argv[0]) 351 print('The core dump is read from stdin.') We could not maintain backwards compatibility because "global pid" is an optional argument and "dump mode" was a new argument. So if there were five arguments its possible the last one was "dump mode" (no global pid) or "global pid" (no support for dump mode). Its possible to use strings in /proc/sys/kernel/core_pattern so we could use those and have apport accept named arguments e.g: $ cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d --global-pid=%P ['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870', '--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870'] Tyler said "that's probably a nice cleanup to make no matter what because the magic arg ordering is dangerous". SRU Description [Impact] data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. This SRU for xenial and bionic based on the work made in cosmic enabled proper handling of named argument. Note that this is disabled for now on ALL series [Test Case] No real test here since apport general behavior should be unchanged Just to check that the feature is disable, /proc/sys/kernel/core_pattern content should remain unchanged : $> cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport %p %s %c %d %P %E [Regression Potential] The new feature is not enabled so the regression risk is fairly low. this will take place in a future coordinated SRU across all LTS but in the meanwhile we can make sure that there's no regression by running apport with various End SRU Description data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. Here's something of an example: 347 # Normal startup 348 if len(sys.argv) not in (5, 6): 349 try: 350 print('Usage: %s <pid> <signal number> <core file ulimit> <dump mode> [global pid]' % sys.argv[0]) 351 print('The core dump is read from stdin.') We could not maintain backwards compatibility because "global pid" is an optional argument and "dump mode" was a new argument. So if there were five arguments its possible the last one was "dump mode" (no global pid) or "global pid" (no support for dump mode). Its possible to use strings in /proc/sys/kernel/core_pattern so we could use those and have apport accept named arguments e.g: $ cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d --global-pid=%P ['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870', '--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870'] Tyler said "that's probably a nice cleanup to make no matter what because the magic arg ordering is dangerous".
2020-09-22 22:00:38 Matthieu Clemenceau attachment removed diff for xenial to support named param. (backport from cosmic) https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405275/+files/apport_2.20.1-0ubuntu2.25.debdiff
2020-09-22 22:01:00 Matthieu Clemenceau attachment removed diff for bionic to support named param. (backport from cosmic) https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405276/+files/apport_2.20.9-0ubuntu7.18.debdiff
2020-09-22 22:01:46 Matthieu Clemenceau attachment added diff for xenial to support named param. (backport from cosmic) https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5413348/+files/apport_2.20.1-0ubuntu2.25.debdiff
2020-09-22 22:02:30 Matthieu Clemenceau attachment added diff for bionic to support named param. (backport from cosmic) https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5413349/+files/apport_2.20.9-0ubuntu7.18.debdiff
2020-09-24 21:09:24 Brian Murray removed subscriber Ubuntu Sponsors Team
2020-09-25 15:15:58 Matthieu Clemenceau description SRU Description [Impact] data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. This SRU for xenial and bionic based on the work made in cosmic enabled proper handling of named argument. Note that this is disabled for now on ALL series [Test Case] No real test here since apport general behavior should be unchanged Just to check that the feature is disable, /proc/sys/kernel/core_pattern content should remain unchanged : $> cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport %p %s %c %d %P %E [Regression Potential] The new feature is not enabled so the regression risk is fairly low. this will take place in a future coordinated SRU across all LTS but in the meanwhile we can make sure that there's no regression by running apport with various End SRU Description data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. Here's something of an example: 347 # Normal startup 348 if len(sys.argv) not in (5, 6): 349 try: 350 print('Usage: %s <pid> <signal number> <core file ulimit> <dump mode> [global pid]' % sys.argv[0]) 351 print('The core dump is read from stdin.') We could not maintain backwards compatibility because "global pid" is an optional argument and "dump mode" was a new argument. So if there were five arguments its possible the last one was "dump mode" (no global pid) or "global pid" (no support for dump mode). Its possible to use strings in /proc/sys/kernel/core_pattern so we could use those and have apport accept named arguments e.g: $ cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d --global-pid=%P ['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870', '--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870'] Tyler said "that's probably a nice cleanup to make no matter what because the magic arg ordering is dangerous". SRU Description [Impact] data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. This SRU for xenial and bionic based on the work made in cosmic enabled proper handling of named argument. Note that this is disabled for now on ALL series [Test Case] No real test here since apport general behavior should be unchanged Just to check that the feature is disable, /proc/sys/kernel/core_pattern content should remain unchanged : $> cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport %p %s %c %d %P %E [Regression Potential] The new feature is not enabled so the regression risk is fairly low. this will take place in a future coordinated SRU across all LTS but in the meanwhile we can make sure that there's no regression by making sure apport still behave properly. starting and killing xeyes should trigger apport normal operation $> xeyes & $> kill -SEGV $! End SRU Description data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. Here's something of an example: 347 # Normal startup 348 if len(sys.argv) not in (5, 6): 349 try: 350 print('Usage: %s <pid> <signal number> <core file ulimit> <dump mode> [global pid]' % sys.argv[0]) 351 print('The core dump is read from stdin.') We could not maintain backwards compatibility because "global pid" is an optional argument and "dump mode" was a new argument. So if there were five arguments its possible the last one was "dump mode" (no global pid) or "global pid" (no support for dump mode). Its possible to use strings in /proc/sys/kernel/core_pattern so we could use those and have apport accept named arguments e.g: $ cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d --global-pid=%P ['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870', '--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870'] Tyler said "that's probably a nice cleanup to make no matter what because the magic arg ordering is dangerous".
2020-09-25 15:18:32 Matthieu Clemenceau description SRU Description [Impact] data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. This SRU for xenial and bionic based on the work made in cosmic enabled proper handling of named argument. Note that this is disabled for now on ALL series [Test Case] No real test here since apport general behavior should be unchanged Just to check that the feature is disable, /proc/sys/kernel/core_pattern content should remain unchanged : $> cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport %p %s %c %d %P %E [Regression Potential] The new feature is not enabled so the regression risk is fairly low. this will take place in a future coordinated SRU across all LTS but in the meanwhile we can make sure that there's no regression by making sure apport still behave properly. starting and killing xeyes should trigger apport normal operation $> xeyes & $> kill -SEGV $! End SRU Description data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. Here's something of an example: 347 # Normal startup 348 if len(sys.argv) not in (5, 6): 349 try: 350 print('Usage: %s <pid> <signal number> <core file ulimit> <dump mode> [global pid]' % sys.argv[0]) 351 print('The core dump is read from stdin.') We could not maintain backwards compatibility because "global pid" is an optional argument and "dump mode" was a new argument. So if there were five arguments its possible the last one was "dump mode" (no global pid) or "global pid" (no support for dump mode). Its possible to use strings in /proc/sys/kernel/core_pattern so we could use those and have apport accept named arguments e.g: $ cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d --global-pid=%P ['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870', '--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870'] Tyler said "that's probably a nice cleanup to make no matter what because the magic arg ordering is dangerous". SRU Description [Impact] data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. This SRU for xenial and bionic based on the work made in cosmic enabled proper handling of named argument. Note that this is disabled for now on ALL series [Test Case] No real test here since apport general behavior should be unchanged Just to check that the feature is disable, /proc/sys/kernel/core_pattern content should remain unchanged : $> cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport %p %s %c %d %P %E [Regression Potential] The new feature is not enabled so the regression risk is fairly low. this will take place in a future coordinated SRU across all LTS but in the meanwhile we can make sure that there's no regression by making sure apport still behave properly. starting and killing xeyes should trigger apport normal operation and start apport. $> xeyes & $> kill -SEGV $! End SRU Description data/apport which processes core files expects a certain quantity of arguments in a specific order. This ended up causing an issue with some security updates where we were trying to support a new version of apport on a host system and one inside a container. Here's something of an example: 347 # Normal startup 348 if len(sys.argv) not in (5, 6): 349 try: 350 print('Usage: %s <pid> <signal number> <core file ulimit> <dump mode> [global pid]' % sys.argv[0]) 351 print('The core dump is read from stdin.') We could not maintain backwards compatibility because "global pid" is an optional argument and "dump mode" was a new argument. So if there were five arguments its possible the last one was "dump mode" (no global pid) or "global pid" (no support for dump mode). Its possible to use strings in /proc/sys/kernel/core_pattern so we could use those and have apport accept named arguments e.g: $ cat /proc/sys/kernel/core_pattern |/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d --global-pid=%P ['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870', '--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870'] Tyler said "that's probably a nice cleanup to make no matter what because the magic arg ordering is dangerous".
2020-09-25 15:33:41 Timo Aaltonen apport (Ubuntu Bionic): status In Progress Fix Committed
2020-09-25 15:33:43 Timo Aaltonen bug added subscriber Ubuntu Stable Release Updates Team
2020-09-25 15:33:45 Timo Aaltonen bug added subscriber SRU Verification
2020-09-25 15:33:48 Timo Aaltonen tags id-5a0f2a3d5a9357e93d7f6816 id-5a0f2a3d5a9357e93d7f6816 verification-needed verification-needed-bionic
2020-09-25 15:35:39 Timo Aaltonen apport (Ubuntu Xenial): status In Progress Fix Committed
2020-09-25 15:35:45 Timo Aaltonen tags id-5a0f2a3d5a9357e93d7f6816 verification-needed verification-needed-bionic id-5a0f2a3d5a9357e93d7f6816 verification-needed verification-needed-bionic verification-needed-xenial
2020-10-05 20:10:15 Matthieu Clemenceau tags id-5a0f2a3d5a9357e93d7f6816 verification-needed verification-needed-bionic verification-needed-xenial id-5a0f2a3d5a9357e93d7f6816 verification-done verification-done-bionic verification-done-xenial
2020-10-06 23:13:25 Launchpad Janitor apport (Ubuntu Xenial): status Fix Committed Fix Released
2020-10-06 23:13:29 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2020-10-06 23:13:41 Launchpad Janitor apport (Ubuntu Bionic): status Fix Committed Fix Released
2022-06-27 10:34:17 Benjamin Drung apport: milestone 2.21.0
2022-06-27 10:34:19 Benjamin Drung apport: status Fix Committed Fix Released
2023-04-12 15:02:50 Benjamin Drung apport (Ubuntu): importance Undecided Low